From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 886D2C3DA61 for ; Mon, 29 Jul 2024 06:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9LhZsel+ZXOFBLouKmnPn+e0gC2RjgaR8JO/hzKLRAg=; b=yMazk+5rOZQ08h95kTCSQ26xPL cqMRiB+oafw1EiKh8ef/SamPfFLVWK6BwvWcRrDDifXfiwvWl3ULP0bEq+HwLqNnZwV+Y9DVxAKvW dxHBhOqKUU18pWzh+9z4JcJBp6aqvpuZMKE9SBC0lLxiTporId0bnaotGTzfBzckbEM032k5opyXt Q9CnkTQOBhmkQveOPBAgOCw6KEy5YqzUo1aZwauOFTnELBKnzg7UpbKYFD4yUamL6DqaztjQCOy1K wmJn/5XxULn+IYGt9RDTu98PnMmTKXXiChJLXxs+slmeumsOu5FF0MyCc982qCbA6c0xqmTzj4Dic eyQDx8Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYJsZ-0000000AANH-0rhW; Mon, 29 Jul 2024 06:29:07 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYJrt-0000000AA5q-0X6E for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2024 06:28:41 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-70d19d768c2so2016526b3a.3 for ; Sun, 28 Jul 2024 23:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722234503; x=1722839303; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9LhZsel+ZXOFBLouKmnPn+e0gC2RjgaR8JO/hzKLRAg=; b=jDohomnwtaxYwCezln31Kwl99AtA4uaq09D+SwlLsqsBDOMBmz7i1brO+0z6q7sW2H p85H9mN/9OCv498/j1s3iEuiy1C0nyv0EOiqkEvhKYIoQfoMZRZM/kFcK0OqT2C03vGA 52/P7YkBNwTHbZeE65lu0WI75oO0DQgac5eGLLaKwePObQW8Omn4iGGo3+iRufGn16hZ c1ojw3dxtQpnmqsbSI5D3e5HZ1NYzA0DpCX1uwWhhI/XOgtIhQHeRMa75CkxTffV/DGW nIDBGMZHbEZ/wCtw/ZClcHDTAgW7SlYWO4QYFSQmSe/otC0TaXGeZIFM45Xgn7quE8Ta Cl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722234503; x=1722839303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9LhZsel+ZXOFBLouKmnPn+e0gC2RjgaR8JO/hzKLRAg=; b=rbTMvaaNbLyLfOP7qGs87WZFpuxrot+OiYodAKckbiDwjfZy7SdhmXiuUh0JSDqfbH e9AUbX8mDmtDRgXWdqglZvwyEWQuxMKP1YuesgIpgrFd7P08wW5Rb4cyp5XJczDQZZyX sY/Wou9BRqqkHDUyYQxhUq5ILD8pC+LIGM+Mo3Vagnxn9pkmsbkrui1Dhdj/ruAdUiWm UH9DSQiiCSoxboW/YN4/XzNFNXyp6kotan7tDBjR+aL3ewcjG7qaB+DTmYc9NnpP8Mhy qyNebFbpjryGv4edtBvfkU5tds5UwAwXPPILgKHOLHVnwVMsYKr/Gia+Mlp/WZJv7dIP fYKg== X-Forwarded-Encrypted: i=1; AJvYcCVkAm+gxk4v3U94bloTJ8IWB9SEpnstNmU/yQnC7wXJP+H8Ie5D/uPq/Vi0Zl6rJOnvuVQrkeEn/2odNGkkIQW8K89SEiWo1iT+wFdrgjLU6JoaUe4= X-Gm-Message-State: AOJu0YyDJf3gLTWidwBmfiwsTlTzonYlxAF3McLl54MA2DW156lGmqGf hATrvWcBei02H4tgxZBbdYrXmdsYZbh33E63Y0U9YkTqI4uQfeSAa2kWOWP7wpw= X-Google-Smtp-Source: AGHT+IFxLwq27q0Hdj/w8FwvESdnHQBwsPuqDTmOipebs/uzejoVKO14hWPOPPbb4dFbQ7eyO/Gv0w== X-Received: by 2002:a05:6a00:6f64:b0:706:6bdc:4de5 with SMTP id d2e1a72fcca58-70ecea1dd24mr4120390b3a.7.1722234502813; Sun, 28 Jul 2024 23:28:22 -0700 (PDT) Received: from sunil-laptop ([106.51.198.16]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead715540sm6132019b3a.45.2024.07.28.23.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jul 2024 23:28:22 -0700 (PDT) Date: Mon, 29 Jul 2024 11:58:13 +0530 From: Sunil V L To: Haibo Xu Cc: xiaobo55x@gmail.com, ajones@ventanamicro.com, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Cameron , Gavin Shan , "Russell King (Oracle)" , James Morse , Hanjun Guo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Message-ID: References: <20240729035958.1957185-1-haibo1.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729035958.1957185-1-haibo1.xu@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240728_232825_176371_EA2462AB X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 29, 2024 at 11:59:55AM +0800, Haibo Xu wrote: > Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE. > To ensure all the values were properly initialized, switch to initialize > all of them to NUMA_NO_NODE. > > Suggested-by: Andrew Jones > Signed-off-by: Haibo Xu > --- > arch/arm64/kernel/acpi_numa.c | 2 +- > arch/riscv/kernel/acpi_numa.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > index 0c036a9a3c33..2465f291c7e1 100644 > --- a/arch/arm64/kernel/acpi_numa.c > +++ b/arch/arm64/kernel/acpi_numa.c > @@ -27,7 +27,7 @@ > > #include > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; > > int __init acpi_numa_get_nid(unsigned int cpu) > { > diff --git a/arch/riscv/kernel/acpi_numa.c b/arch/riscv/kernel/acpi_numa.c > index 0231482d6946..ff95aeebee3e 100644 > --- a/arch/riscv/kernel/acpi_numa.c > +++ b/arch/riscv/kernel/acpi_numa.c > @@ -28,7 +28,7 @@ > > #include > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; > The change looks good to me. However, I was wondering whether it needs "Fixes" tag in which case I think you will have to split this patch into two. Otherwise, Reviewed-by: Sunil V L Thanks! Sunil > int __init acpi_numa_get_nid(unsigned int cpu) > { > -- > 2.34.1 >