From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A1A9C3DA4A for ; Mon, 29 Jul 2024 15:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R3oyZEs5pd+yus/xSJY0J3CYufbcoKy2KGG+eQ20D0A=; b=m6RmWHsV3itixjBS3mVUvsMFm2 nQwV141DwC1WUsbtD2xFnKPyw7g362mKv50cBzHJ5in1qO4R91TF1dj1K/mQDRmkbMWD0Rv19b0Po sOM7TTgaK9iPDuaY1mLLQ5s0lL+66cIkK/aX0cuuU/7eHfm2u91waO2YQzOkGMpbNG6NXCC9MFqwW wPCzF7T7MVHDBZvxZNLMha8qKyjCcXRFOdhvOckdV/YvuP4wk2bqaAZZoCKzQkP19EZ68mFPpxRah 6481AW60yE1nAEmy3udmXMMiG6hgQsVptDphs1dqje0bbcAq/PHrEcUFnCpCFwnLRHm3TVn7FVsBL sSOjuGjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYSQQ-0000000Bt3B-0r2D; Mon, 29 Jul 2024 15:36:38 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYSPp-0000000Bsvs-0iZV for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2024 15:36:12 +0000 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-7a103ac7be3so1890997a12.3 for ; Mon, 29 Jul 2024 08:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722267360; x=1722872160; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R3oyZEs5pd+yus/xSJY0J3CYufbcoKy2KGG+eQ20D0A=; b=hZqEgGonfQ/tK+uatsjZIQkgqLnrd6lZyN9Pyxcy+ZLQasbWEMd5d+sxHAF/Txt9c7 hElsVJ3L0XNrTuwOqGa/YBpAEqA2O+iOzvaweeO9meoEy3MTwbDAgTzqEaNu6Lx3y+OP wLrrUb3lap9IIlMDrBvSgZzBIHQUl2IiryFFUC1d01OqWs67Cf1o+HygNXRceHEyuWS4 cexp3b8jCjWuyAiib8L4TrJdvitw2bu9sZ54uFGJKzhqbx3c3EAaCAnhpwKdqySkPXin /szx84jA9uWUpPhXIv3zOlthixfksplQwc77qMi5zZV5wzhrb3gJM56JOeHFKIzpNBdV VyKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722267360; x=1722872160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R3oyZEs5pd+yus/xSJY0J3CYufbcoKy2KGG+eQ20D0A=; b=Z5yZ8znS9+YOS5fqrCgwFInr8o6k3xepFiFoIn1xP4irENj9IMJ2tDZLgI4xIna3N4 CUwb6B6gwwt8iLXh9zNgucNduuJCpV14ep5h19AbcrmFx+3BUhlvnyUkc+eqJAr9GNJg cNO1Z9GQ2kFkrZ5+jyThpJ69FqrOXVmcbmAebGqX3OFNbVQcL2j6WHjqcAS8A1biSeVa V7ZbUdsYTilUPS70EteEVLZib5bhcLnLvcglMGxC5OKAyGu/fRLECS5JgJU9OmrRtiQl v3j2opSuBj/u0LLP2MhhFqBsgProec0aWf2gwvu26/JpQ8ZrHDRpuKtGe2Ig+C02n523 WHiw== X-Forwarded-Encrypted: i=1; AJvYcCWYhG9MvXtGnDJbUSDNG3j45X7dWmLlyOJETAZk1eZlp+Tm5HUlhdD/BQTkeDu3tFpTLVSVlx2fBH1wN8WgzHO7OztIHKukKlT2WxjSdkuyF1GzX7U= X-Gm-Message-State: AOJu0Ywnj80VgHesk0fQHHqMQI3gGtO7aNba2leusK/m4p9v0j+YPIdN bhsjdz4AJvMyn6FcQIAg98VSbqivf9bcmppFXZb1nlMzqGkeQu/HoJJ+3gYC0MU= X-Google-Smtp-Source: AGHT+IFv84T5GiiA/Y8AELuClni1irIXmvrexGVaWXq7ByE0ZTiWAk3x3pV3qNV4LBt5YfUQwHgEqw== X-Received: by 2002:a05:6a21:3414:b0:1c0:eb1e:868e with SMTP id adf61e73a8af0-1c4a12aed16mr5789802637.19.1722267359947; Mon, 29 Jul 2024 08:35:59 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:b771:7ecc:900e:e070]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7fccb63sm84195465ad.284.2024.07.29.08.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 08:35:59 -0700 (PDT) Date: Mon, 29 Jul 2024 09:35:56 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Daniel Baluta , Iuliana Prodan , Marek Vasut , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP Message-ID: References: <20240719-imx_rproc-v2-0-cd8549aa3f1f@nxp.com> <20240719-imx_rproc-v2-2-cd8549aa3f1f@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719-imx_rproc-v2-2-cd8549aa3f1f@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240729_083601_242720_535DDF44 X-CRM114-Status: GOOD ( 30.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 19, 2024 at 04:49:04PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to > configure the i.MX7ULP power controller properly. > > However the reboot and restart kernel common code use atomic notifier, > so with blocking tx mailbox will trigger kernel dump, because of > blocking mailbox will use wait_for_completion_timeout. In such case, > linux no need to wait for completion. > > Current patch is to use non-blocking tx mailbox channel when system > is going to poweroff or restart. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 01cf1dfb2e87..e1abf110abc9 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -114,6 +115,7 @@ struct imx_rproc { > u32 entry; /* cpu start address */ > u32 core_index; > struct dev_pm_domain_list *pd_list; > + struct sys_off_data data; What is this for? I don't see it used in this patch. > }; > > static const struct imx_rproc_att imx_rproc_att_imx93[] = { > @@ -1050,6 +1052,22 @@ static int imx_rproc_clk_enable(struct imx_rproc *priv) > return 0; > } > > +static int imx_rproc_sys_off_handler(struct sys_off_data *data) > +{ > + struct rproc *rproc = data->cb_data; > + int ret; > + > + imx_rproc_free_mbox(rproc); > + > + ret = imx_rproc_xtr_mbox_init(rproc, false); > + if (ret) { > + dev_err(&rproc->dev, "Failed to request non-blocking mbox\n"); > + return NOTIFY_BAD; > + } > + > + return NOTIFY_DONE; > +} > + > static int imx_rproc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -1104,6 +1122,24 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (rproc->state != RPROC_DETACHED) > rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > > + if (of_device_is_compatible(dev->of_node, "fsl,imx7ulp-cm4")) { > + ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_POWER_OFF_PREPARE, > + SYS_OFF_PRIO_DEFAULT, > + imx_rproc_sys_off_handler, rproc); Why does the mailbox needs to be set up again when the system is going down... > + if (ret) { > + dev_err(dev, "register power off handler failure\n"); > + goto err_put_clk; > + } > + > + ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_RESTART_PREPARE, > + SYS_OFF_PRIO_DEFAULT, > + imx_rproc_sys_off_handler, rproc); ... and why does it need to be free'd when the system is going up? > + if (ret) { > + dev_err(dev, "register restart handler failure\n"); > + goto err_put_clk; > + } > + } > + > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > > -- > 2.37.1 > >