linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Joey Gouly <joey.gouly@arm.com>
Subject: Re: [PATCH] arm64: signal: Update sigcontext reservations table
Date: Wed, 31 Jul 2024 17:09:36 +0100	[thread overview]
Message-ID: <ZqphwJPLXWttdUzC@e133380.arm.com> (raw)
In-Reply-To: <4c847f4c-6a99-49c2-a3a9-60c1e30a4e7b@sirena.org.uk>

On Wed, Jul 31, 2024 at 03:58:00PM +0100, Mark Brown wrote:
> On Wed, Jul 31, 2024 at 03:38:40PM +0100, Dave Martin wrote:
> 
> > For the patch itself, can you say whether the proposed update is right
> > or wrong, and whether you think we need to document this better and/or
> > change the approach?
> 
> I haven't double checked the sizeofs but it covers all the things in the
> frame and like I said before there's no exclusion between PSTATE.{SM,ZA}.
> I do think this should be clearer about what it's supposed to be
> tracking.
> 
> + * where vl is the non-streaming SVE vector length, as set with PR_SVE_SET_VL,
> + * and svl is the streaming SVE vector length, as set with PR_SME_SET_VL.
> 
> I'd just say VL is the vector length, that's the term the architecture
> uses and it says it's set with PR_SVE_SET_VL to clarify.

It's the worst-case sigframe size that we care about here, regardless
of what code a signal is delivered in the middle of.  Surely that
depends on both vector length settings?

PSTATE.SM and .ZA can be twiddled on and off in userspace by the
compiler IIUC; other translations units aren't supposed to care (or
notice), so we can't know ahead of time which vector length setting
will be used when generting the sigframe.  User code allocating the
stack must assume the worst.

Can you think of a description that clarifies this?

Cheers
---Dave


  reply	other threads:[~2024-07-31 16:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 14:41 [PATCH] arm64: signal: Update sigcontext reservations table Dave Martin
2024-07-29 14:53 ` Mark Brown
2024-07-29 15:51   ` Dave Martin
2024-07-29 17:01     ` Mark Brown
2024-07-30 12:51       ` Dave Martin
2024-07-30 13:22         ` Mark Brown
2024-07-30 15:07           ` Dave Martin
2024-07-30 16:00             ` Mark Brown
2024-07-31 10:38               ` Dave Martin
2024-07-31 11:49                 ` Mark Brown
2024-07-31 14:38                   ` Dave Martin
2024-07-31 14:58                     ` Mark Brown
2024-07-31 16:09                       ` Dave Martin [this message]
2024-07-31 16:14                         ` Mark Brown
2024-07-31 16:23                           ` Dave Martin
2024-08-20 13:37 ` Will Deacon
2024-08-20 14:38   ` Dave Martin
2024-08-23 11:46     ` Will Deacon
2024-09-03 14:18       ` Dave Martin
2024-09-03 18:26         ` Mark Brown
2024-09-04 11:24           ` Dave Martin
2024-09-04 11:49             ` Mark Brown
2024-09-05 10:59               ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqphwJPLXWttdUzC@e133380.arm.com \
    --to=dave.martin@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).