From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99E31C3DA64 for ; Thu, 1 Aug 2024 16:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SaIPytHxWcAaYza32KmNAPXihLWLj5CDb3e50E+sMRQ=; b=uaJO976nHtCDuukxAYwu0uT1Wm xJLoIUTYZFvTu7+yTR/C+wYOQ614r30dltfaFU8nmE8I8Ow3wTfWcd3WSVchVzwUfeBcplVls++pu NwhPr6cNxk2v+Zm4PGjkfdYjZcgCpPJKUD3MEVabEpV11vWmqwQf2izw77YvNop2jLwpaS/1MJHdz Xrs/12YgBGDDQaebFYnBIuzSsE4NlGiFs+Zjnzcr7TvYzgpnLLB2g2EaMs0SxpAOoC+yfuyyaEEBR NzJcTn3lisp6KESSzDn+f579NPQHvwqHXlXLyVo+OcV1hAxLtxupYMVsbuNhYsYhMbnebvoSAhUNN C1Iv6pwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYqU-000000066zU-2XrX; Thu, 01 Aug 2024 16:40:06 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYok-000000065Ir-2REi for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 16:38:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SaIPytHxWcAaYza32KmNAPXihLWLj5CDb3e50E+sMRQ=; b=cddZt4X2EOKhHMr2SS7Oecnifx oGjj4+9YuXZMQi4YdWfEX0j4UPccH3G9E5JzTCDEBoMRBFwNoSsQ302iKdPkZJRknC9vcMxcyXkG4 QYfxVOJZbFZfqbAm5/lxLGoawvXH8rJbDYQ8W0WXd91IMuof5olo9xZwkLdlK+WNEpdfmpT8GaRDM n9wMctRP9JawI+VOOb5vqOLhdnyBEe1BR4FMYQbFU0ZfRSy32Zlwb6sGVIzKX3o8/XhfqyxMaIFgD a1PU3J7EB1zt8RVNoF6QSILWEGqkg9gGwNXEx5dwoNFQi6Vfcprmm4gqPLJKcAplRdxGLGhnDbOys Sm1GZFMQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36698) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZYmV-0003Wu-3C; Thu, 01 Aug 2024 17:36:00 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sZYmY-0007EW-5x; Thu, 01 Aug 2024 17:36:02 +0100 Date: Thu, 1 Aug 2024 17:36:02 +0100 From: "Russell King (Oracle)" To: Jinjie Ruan Cc: dianders@chromium.org, mhocko@suse.com, akpm@linux-foundation.org, maz@kernel.org, vschneid@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: smp: Fix missing backtrace IPI statics Message-ID: References: <20240801094022.1402616-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801094022.1402616-1-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_093818_646610_470973A4 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 01, 2024 at 05:40:22PM +0800, Jinjie Ruan wrote: > It is similar to ARM64 commit 916b93f4e865 ("arm64: smp: Fix missing IPI > statistics"), commit 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal > interrupts") set CPU_BACKTRACE IPI "IRQ_HIDDEN" flag but not show it in > show_ipi_list(), which cause the interrupt kstat_irqs accounting > is missing in display. I don't see why this needs to be included. If this IPI fires, it means that the kernel has suffered a lockup and is probably not very useful. So the chances of being able to read out from /proc/interrupts a non- zero "CPU backtrace interrupts" figure is highly unlikely. So, I don't see much point to this change. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!