From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: bhe@redhat.com, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ARM: Support allocating crashkernel above 4G for LPAE
Date: Fri, 2 Aug 2024 12:01:43 +0100 [thread overview]
Message-ID: <Zqy8lwZM2Z6RlV5H@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240802092510.3915986-1-ruanjinjie@huawei.com>
On Fri, Aug 02, 2024 at 05:25:10PM +0800, Jinjie Ruan wrote:
> As ARM LPAE feature support accessing memory beyond the 4G limit, define
> HAVE_ARCH_CRASHKERNEL_RESERVATION_HIGH macro to support reserving crash
> memory above 4G for ARM32 LPAE.
>
> No test because there is no LPAE ARM32 hardware.
Why are you submitting patches for features you can't test?
I'm not going to apply this without it being properly tested, because I
don't believe that this will work in the generic case.
If the crash kernel is located in memory outside of the lower 4GiB of
address space, and there is no alias within physical address space
for that memory, then there is *no* *way* for such a kernel to boot.
So, right now I believe this patch to be *fundamentally* wrong.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-08-02 11:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 9:25 [RFC PATCH] ARM: Support allocating crashkernel above 4G for LPAE Jinjie Ruan
2024-08-02 11:01 ` Russell King (Oracle) [this message]
2024-08-05 1:23 ` Jinjie Ruan
2024-08-05 2:56 ` Baoquan He
2024-08-06 2:46 ` Jinjie Ruan
2024-08-06 8:11 ` Baoquan He
2024-08-06 8:34 ` Russell King (Oracle)
2024-08-06 11:02 ` Baoquan He
2024-08-06 11:10 ` Jinjie Ruan
2024-08-06 11:08 ` Jinjie Ruan
2024-08-05 13:18 ` Catalin Marinas
2024-08-06 2:19 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqy8lwZM2Z6RlV5H@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).