From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B923BC3DA7F for ; Thu, 15 Aug 2024 13:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uaMrOl7q56e1aVEVjXeEL0yoDAcW38ZFXTM7d0ChtPM=; b=f/0MaD3V0vZynBGsATcGYNHGih UBgVynNdnBgQZHLeaNmRjQ9seXeRWTCfg1qTmalY9NOYJCW0z8btbXgoUtrmzbgAQDzS7mbrXJx6+ wxEiiPOCbxoDbsiXC3hE7RForMd9rkzV/0uXClXP+g6QmniNWbT2S7Neh52JDm26klpfEwID4VJ5B MfEacqJQoqMO34OHWm4eLMGfv0Mz9DNJ4z8SySUcqw00PlFtt4P216zxlLEn5tO4v1d3RWCphfg4A O/fE3y5LPUv3XqHhW7SyCSotwyFCoKK2xsl3OU4qNKmIP2ia/4qjJD6qrLz/tdgrQDbXf2WXDnJby +pAlwBXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seaos-0000000A5rO-0f33; Thu, 15 Aug 2024 13:47:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seaoD-0000000A5js-1jqr for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 13:46:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34EF914BF; Thu, 15 Aug 2024 06:46:54 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A72063F6A8; Thu, 15 Aug 2024 06:46:26 -0700 (PDT) Date: Thu, 15 Aug 2024 14:46:24 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Sibi Sankar , cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com, johan@kernel.org, Sudeep Holla , Peng Fan Subject: Re: [PATCH] pmdomain: arm: Fix debugfs node creation failure Message-ID: References: <20240703110741.2668800-1-quic_sibis@quicinc.com> <064274c4-3783-c59e-e293-dd53a8595d8e@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_064633_692993_526996B6 X-CRM114-Status: GOOD ( 30.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2024 at 12:46:15PM +0200, Ulf Hansson wrote: > On Wed, 14 Aug 2024 at 15:31, Sudeep Holla wrote: > > > > On Wed, Aug 14, 2024 at 02:38:24PM +0200, Ulf Hansson wrote: > > > > > > Sudeep, while I understand your point and I agree with it, it's really > > > a simple fix that $subject patch is proposing. As the unique name > > > isn't mandated by the SCMI spec, it looks to me that we should make a > > > fix for it on the Linux side. > > > > > > > Yes, I did come to the conclusion that this is inevitable but hadn't > > thought much on the exact solution. This email and you merging the original > > patch made me think a bit quickly now 😉 > > Alright, great! > > > > > > I have therefore decided to queue up $subject patch for fixes. Please > > > let me know if you have any other proposals/objections moving forward. > > > > The original patch may not work well with the use case Peng presented. > > As the name and id may also match in their case, I was wondering if we > > need to add some prefix like perf- or something to avoid the potential > > clash across power and perf genpds ? I may be missing something still as > > it is hard to visualise all possible case that can happen with variety > > of platform and their firmware. > > > > In short, happy to have some fix for the issue in some form whichever > > works for wider set of platforms. > > Okay, so I have dropped the $subject patch from my fixes branch for > now, to allow us and Sibi to come up with an improved approach. > > That said, it looks to me that the proper fix needs to involve > pm_genpd_init() in some way, as this problem with unique device naming > isn't really limited to SCMI. Normally we use an "ida" to get a unique > index that we tag on to the device's name, but maybe there is a better > strategy here!? Yes using "ida" for unique index might work here as well AFAIU. It can be one of the possible solution for sure. -- Regards, Sudeep