* [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso
@ 2024-07-01 23:12 Fabio Estevam
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Fabio Estevam @ 2024-07-01 23:12 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, tharvey, parthiban, devicetree,
linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
There is no need to describe the compatible string inside
a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
.../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso | 5 -----
.../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso | 5 -----
.../dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso | 6 ------
3 files changed, 16 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
index bf3e04651ba0..9dd070342363 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
@@ -14,11 +14,6 @@
/dts-v1/;
/plugin/;
-&{/} {
- compatible = "phytec,imx8mm-phygate-tauri-l";
-
-};
-
&gpio3 {
pinctrl-names = "default";
pinctrcl-0 = <&pinctrl_gpio3_hog>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
index f4448cde0407..045cd8082781 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
@@ -15,11 +15,6 @@
/dts-v1/;
/plugin/;
-&{/} {
- compatible = "phytec,imx8mm-phygate-tauri-l";
-
-};
-
&gpio3 {
pinctrl-names = "default";
pinctrcl-0 = <&pinctrl_gpio3_hog>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
index 107f743fbb1c..4719f5fbad03 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
@@ -14,12 +14,6 @@
/dts-v1/;
/plugin/;
-
-&{/} {
- compatible = "phytec,imx8mm-phygate-tauri-l";
-
-};
-
&uart2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
2024-07-01 23:12 [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso Fabio Estevam
@ 2024-07-01 23:12 ` Fabio Estevam
2024-07-02 10:31 ` Parthiban
2024-07-02 18:05 ` Tim Harvey
2024-07-02 10:32 ` [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: " Parthiban
2024-08-05 8:10 ` Shawn Guo
2 siblings, 2 replies; 7+ messages in thread
From: Fabio Estevam @ 2024-07-01 23:12 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, tharvey, parthiban, devicetree,
linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
There is no need to describe the compatible string inside
a dtso file.
dt-schema produces super verbose warnings about that.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
.../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
.../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ----
.../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ----
3 files changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
index f6ad1a4b8b66..47d3c0c49e8a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
@@ -15,10 +15,6 @@
/dts-v1/;
/plugin/;
-&{/} {
- compatible = "gw,imx8mm-gw72xx-0x";
-};
-
&gpio4 {
rs485_en {
gpio-hog;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
index c3cd9f2b0db3..7fcd8c851159 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
@@ -18,10 +18,6 @@
/dts-v1/;
/plugin/;
-&{/} {
- compatible = "gw,imx8mm-gw72xx-0x";
-};
-
&gpio4 {
rs485_en {
gpio-hog;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
index cc0a287226ab..b19e38fc27ba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
@@ -18,10 +18,6 @@
/dts-v1/;
/plugin/;
-&{/} {
- compatible = "gw,imx8mm-gw72xx-0x";
-};
-
&gpio4 {
rs485_en {
gpio-hog;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
@ 2024-07-02 10:31 ` Parthiban
2024-07-02 18:05 ` Tim Harvey
1 sibling, 0 replies; 7+ messages in thread
From: Parthiban @ 2024-07-02 10:31 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh, krzk+dt, conor+dt, tharvey, devicetree, linux-arm-kernel,
Fabio Estevam, Parthiban
Hi,
I missed it, thanks for fixing it.
On 7/2/24 4:42 AM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> There is no need to describe the compatible string inside
> a dtso file.
>
> dt-schema produces super verbose warnings about that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Parthiban Nallathambi <parthiban@linumiz.com>
Thanks,
Parthiban N
> ---
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ----
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> index f6ad1a4b8b66..47d3c0c49e8a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> @@ -15,10 +15,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> index c3cd9f2b0db3..7fcd8c851159 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> @@ -18,10 +18,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> index cc0a287226ab..b19e38fc27ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> @@ -18,10 +18,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
2024-07-02 10:31 ` Parthiban
@ 2024-07-02 18:05 ` Tim Harvey
2024-07-02 18:17 ` Fabio Estevam
1 sibling, 1 reply; 7+ messages in thread
From: Tim Harvey @ 2024-07-02 18:05 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, parthiban, devicetree,
linux-arm-kernel, Fabio Estevam
On Mon, Jul 1, 2024 at 4:12 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> There is no need to describe the compatible string inside
> a dtso file.
>
> dt-schema produces super verbose warnings about that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso | 4 ----
> .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> index f6ad1a4b8b66..47d3c0c49e8a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> @@ -15,10 +15,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> index c3cd9f2b0db3..7fcd8c851159 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> @@ -18,10 +18,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> index cc0a287226ab..b19e38fc27ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> @@ -18,10 +18,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
> &gpio4 {
> rs485_en {
> gpio-hog;
> --
> 2.34.1
>
Hi Fabio,
Thanks for the fixup. Is there a warning now that detects these?
The same likely needs to be done to imx8mm-venice-gw73xx-*.dtso and
imx8mp-venice-gw74xx*.dtso. My original intention with the compatible
strings was to define what the overlay is compatible with but this
certainly was not the right way to do that (i'm not sure what is
honestly).
Acked-by: Tim Harvey <tharvey@gateworks.com>
Best Regards,
Tim
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso
2024-07-02 18:05 ` Tim Harvey
@ 2024-07-02 18:17 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2024-07-02 18:17 UTC (permalink / raw)
To: Tim Harvey
Cc: shawnguo, robh, krzk+dt, conor+dt, parthiban, devicetree,
linux-arm-kernel, Fabio Estevam
Hi Tim,
On Tue, Jul 2, 2024 at 3:05 PM Tim Harvey <tharvey@gateworks.com> wrote:
> Hi Fabio,
>
> Thanks for the fixup. Is there a warning now that detects these?
Yes, super massive warning when running "make dtbs_check":
Here it goes:
https://paste.to/?89f9844dc5b8f637#7s2w1yEc84cwkZVPTZmiqarkrsn99x9mVsjsSgXXukrm
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso
2024-07-01 23:12 [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso Fabio Estevam
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
@ 2024-07-02 10:32 ` Parthiban
2024-08-05 8:10 ` Shawn Guo
2 siblings, 0 replies; 7+ messages in thread
From: Parthiban @ 2024-07-02 10:32 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh, krzk+dt, conor+dt, tharvey, devicetree, linux-arm-kernel,
Fabio Estevam
Hi,
I missed this as well, Thanks for fixing it.
On 7/2/24 4:42 AM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> There is no need to describe the compatible string inside
> a dtso file.
>
> dt-schema produces super verbose warnings about that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Parthiban Nallathambi <parthiban@linumiz.com>
Thanks,
Parthiban N
> ---
> .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso | 5 -----
> .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso | 5 -----
> .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso | 6 ------
> 3 files changed, 16 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
> index bf3e04651ba0..9dd070342363 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
> @@ -14,11 +14,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "phytec,imx8mm-phygate-tauri-l";
> -
> -};
> -
> &gpio3 {
> pinctrl-names = "default";
> pinctrcl-0 = <&pinctrl_gpio3_hog>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
> index f4448cde0407..045cd8082781 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
> @@ -15,11 +15,6 @@
> /dts-v1/;
> /plugin/;
>
> -&{/} {
> - compatible = "phytec,imx8mm-phygate-tauri-l";
> -
> -};
> -
> &gpio3 {
> pinctrl-names = "default";
> pinctrcl-0 = <&pinctrl_gpio3_hog>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
> index 107f743fbb1c..4719f5fbad03 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rts-cts.dtso
> @@ -14,12 +14,6 @@
> /dts-v1/;
> /plugin/;
>
> -
> -&{/} {
> - compatible = "phytec,imx8mm-phygate-tauri-l";
> -
> -};
> -
> &uart2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart2>;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso
2024-07-01 23:12 [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso Fabio Estevam
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
2024-07-02 10:32 ` [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: " Parthiban
@ 2024-08-05 8:10 ` Shawn Guo
2 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2024-08-05 8:10 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, tharvey, parthiban, devicetree,
linux-arm-kernel, Fabio Estevam
On Mon, Jul 01, 2024 at 08:12:28PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> There is no need to describe the compatible string inside
> a dtso file.
>
> dt-schema produces super verbose warnings about that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied both, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-05 8:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 23:12 [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso Fabio Estevam
2024-07-01 23:12 ` [PATCH 2/2] arm64: dts: imx8mm-venice-gw72xx-0x: " Fabio Estevam
2024-07-02 10:31 ` Parthiban
2024-07-02 18:05 ` Tim Harvey
2024-07-02 18:17 ` Fabio Estevam
2024-07-02 10:32 ` [PATCH 1/2] arm64: dts: imx8mm-phygate-tauri-l: " Parthiban
2024-08-05 8:10 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).