From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BAF2C3DA7F for ; Mon, 5 Aug 2024 15:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qdAxDhz4l2VaEsq4ZJWas9swxdQgWjUHfDN1G3OAhZo=; b=Xyy73m/vmSp/MrY47R8iASoIEr TakErgRh6fJP/rQU/Sqqh93/7XkqsXL9Qa/ThDvvdWTacFUa4v7d8RGTyxeer/DKx1W0fTkGkSx6b DSqnL0K3YB0IiLPcgsuHBL7mUoSV/LNRzvLINsRCvAkRzrb4mefXoqZ5Ig85fNWoGjkkE5bsmvDty q4exa7pc22cLVNIsq4pYG+k0zIsL9zzAhWXlUMYHtoda07GMy9Wl4y2gUOGO79p1IOOSEiFkwJ7KR eKtkHX8WTuLuYr25+fUWIGNnVStaiJ/lKKp5vG/+NFVBsR5u5xd8CZ+bXBqg4T4ljsDlJU4nkz3VO l3jILOFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sazXJ-0000000GI6X-2QwM; Mon, 05 Aug 2024 15:22:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sazWm-0000000GHvj-2aAF; Mon, 05 Aug 2024 15:21:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E03F460CEE; Mon, 5 Aug 2024 15:21:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82C30C4AF0B; Mon, 5 Aug 2024 15:21:36 +0000 (UTC) Date: Mon, 5 Aug 2024 16:21:34 +0100 From: Catalin Marinas To: Haibo Xu Cc: ajones@ventanamicro.com, sunilvl@ventanamicro.com, xiaobo55x@gmail.com, Anshuman Khandual , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Cameron , Hanjun Guo , James Morse , "Russell King (Oracle)" , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 2/2] arm64: ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Message-ID: References: <0d362a8ae50558b95685da4c821b2ae9e8cf78be.1722828421.git.haibo1.xu@intel.com> <853d7f74aa243f6f5999e203246f0d1ae92d2b61.1722828421.git.haibo1.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <853d7f74aa243f6f5999e203246f0d1ae92d2b61.1722828421.git.haibo1.xu@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_082140_730632_618C3758 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 05, 2024 at 11:30:24AM +0800, Haibo Xu wrote: > Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE. > To ensure all the values were properly initialized, switch to initialize > all of them to NUMA_NO_NODE. > > Fixes: e18962491696 ("arm64: numa: rework ACPI NUMA initialization") > Reported-by: Andrew Jones > Suggested-by: Andrew Jones > Signed-off-by: Haibo Xu > Reviewed-by: Anshuman Khandual > Reviewed-by: Sunil V L > Reviewed-by: Andrew Jones > --- > arch/arm64/kernel/acpi_numa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > index 0c036a9a3c33..2465f291c7e1 100644 > --- a/arch/arm64/kernel/acpi_numa.c > +++ b/arch/arm64/kernel/acpi_numa.c > @@ -27,7 +27,7 @@ > > #include > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; Acked-by: Catalin Marinas The patch makes sense but is there any issue currently without it? Trying to assess whether it needs a stable backport. -- Catalin