From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Samuel Holland <samuel.holland@sifive.com>,
Charles Ci-Jyun Wu <dminus@andestech.com>,
Locus Wei-Han Chen <locus84@andestech.com>,
Atish Patra <atishp@rivosinc.com>,
Ji Sheng Teoh <jisheng.teoh@starfivetech.com>,
Inochi Amaoto <inochiama@outlook.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Xu Yang <xu.yang_2@nxp.com>, Sandipan Das <sandipan.das@amd.com>,
Guilherme Amadio <amadio@gentoo.org>,
Changbin Du <changbin.du@huawei.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, vincent.chen@sifive.com,
greentime.hu@sifive.com, Eric Lin <eric.lin@sifive.com>
Subject: Re: [PATCH v1 2/5] perf pmu-events: Change dependencies for empty-pmu-events.c test
Date: Mon, 5 Aug 2024 17:03:31 -0300 [thread overview]
Message-ID: <ZrEwE1bzUsfC6Wfl@x1> (raw)
In-Reply-To: <20240805194424.597244-2-irogers@google.com>
On Mon, Aug 05, 2024 at 12:44:21PM -0700, Ian Rogers wrote:
> Switch from $? (all the prerequisites that are newer than the target)
> to $^ (all the prerequisites) as touching jevents.py will mean that
> empty-pmu-events.c won't be passed to the diff command breaking the
> build.
Thanks, added:
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/pmu-events/Build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> index c3fa43c49706..d941bc9d16e9 100644
> --- a/tools/perf/pmu-events/Build
> +++ b/tools/perf/pmu-events/Build
> @@ -39,7 +39,7 @@ $(TEST_EMPTY_PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(ME
>
> $(EMPTY_PMU_EVENTS_TEST_LOG): $(EMPTY_PMU_EVENTS_C) $(TEST_EMPTY_PMU_EVENTS_C)
> $(call rule_mkdir)
> - $(Q)$(call echo-cmd,test)diff -u $? 2> $@ || (cat $@ && false)
> + $(Q)$(call echo-cmd,test)diff -u $^ 2> $@ || (cat $@ && false)
>
> $(PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(METRIC_TEST_LOG) $(EMPTY_PMU_EVENTS_TEST_LOG)
> $(call rule_mkdir)
> --
> 2.46.0.rc2.264.g509ed76dc8-goog
>
next prev parent reply other threads:[~2024-08-05 20:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 19:44 [PATCH v1 1/5] perf test: Add build test for JEVENTS_ARCH=all Ian Rogers
2024-08-05 19:44 ` [PATCH v1 2/5] perf pmu-events: Change dependencies for empty-pmu-events.c test Ian Rogers
2024-08-05 20:03 ` Arnaldo Carvalho de Melo [this message]
2024-08-05 19:44 ` [PATCH v1 3/5] perf pmu-events: Remove duplicated ampereone event Ian Rogers
2024-08-05 19:44 ` [PATCH v1 4/5] perf pmu-events: Remove duplicated riscv firmware event Ian Rogers
2024-08-06 3:54 ` Eric Lin
2024-08-06 4:05 ` Ian Rogers
2024-08-06 13:38 ` Arnaldo Carvalho de Melo
2024-08-06 13:50 ` Arnaldo Carvalho de Melo
2024-08-06 13:51 ` Arnaldo Carvalho de Melo
2024-08-06 15:50 ` Eric Lin
2024-08-06 17:04 ` Arnaldo Carvalho de Melo
2024-08-05 19:44 ` [PATCH v1 5/5] perf jevents.py: Ensure event names aren't duplicated Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrEwE1bzUsfC6Wfl@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amadio@gentoo.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=changbin.du@huawei.com \
--cc=dminus@andestech.com \
--cc=eric.lin@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=inochiama@outlook.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=locus84@andestech.com \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=samuel.holland@sifive.com \
--cc=sandipan.das@amd.com \
--cc=vincent.chen@sifive.com \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).