From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEA2FC3DA4A for ; Mon, 5 Aug 2024 23:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8tNxfozveIy4KhK+t6BTSFuKqZ3CnwWBfLDeoqvVNkU=; b=mz4/bwwgmUplfFq9DG1NP73vbk 6BB0FfdrRIGAxyB7rUTcdsq7VixeNYEdRqYP7H6UFIiCdmfMTtIGc7epHAK6z3CTV9FHzcQOmVp0g MRziRmNtf1PM30Df9dKIBNTYmIRh5GFIMHPbs2HpR0RFXCoWVgkCK57zQ3toVZbVPS+/CFZYuBJg9 xprj7EiJ07tUIu9eYBhKa/m/0HM9Y++HUTv1fa19M0kUt/jlOZ9gGtuC+77mYLi+gTgtc0Pz6H2gS 1wMWzBxNN/K2v/LE8mitpp9IeLVFS6OydEt/4+FlnJU4Kkyyw5HOUX+ylemUQqQVSsUu01+OppeAJ m4AWzWmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb7WC-000000001il-1eex; Mon, 05 Aug 2024 23:53:36 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb7Vg-000000001be-12yz for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 23:53:05 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-666010fb35cso5218237b3.0 for ; Mon, 05 Aug 2024 16:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722901982; x=1723506782; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8tNxfozveIy4KhK+t6BTSFuKqZ3CnwWBfLDeoqvVNkU=; b=CDCZ44WJs5k/K5bPsE63lDSaYhtbDQk9MsFX63K1sAAJizRVBXn78ohQ4bMmytBa1H OBPfU9PLekhHbBh7sspzi7THFRDvzu7RdRsIhsABnwsbq30/QCIoTBNiYA2VpCZ2Ncto aOe7lF8j4mHI4zHPGjPf/VBRcjfWxP4ZRSkpUBM0IAZK41Q16ffXvGV14+ZjbQWUSbkb CyRjcNQrLXRSWgI3Ui4t5XRqpLhNPAwNymgUqeBPRufOBQ5xegSdMHJrte50XbCk4Dol +7Ik8QV0VHdyUDzck2hN2BtqQewmBCLaaLx9sXAvVopE6083oQcRK06+pFjR2GsHwvxI Fosg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722901982; x=1723506782; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tNxfozveIy4KhK+t6BTSFuKqZ3CnwWBfLDeoqvVNkU=; b=iMzHl9oRf3pzpniULZ19rgGYxa2T4SxrJCUEfKrf5AC7oxDFhbQmhrI2yJyVbdaNVs aDV73SCm1bLCLsdNzMc3HRBmJQNdjHP8oE+/ZR/Z+tJBfFHk1RAy+v3975plCr8IgzFm dKjmk0+9Rq+VLY7aEdCFxTFJoWebWeKoiOprIzGmz6WKkZowN7GLR+At+14827awpti5 HZwSAGoBo+yLCe5H2yRniz4boA8gb0Vrgd7SNBCwiM7f9iSrQVwCE4bgajoeX0MUKQXw Hnmh1W7VK+fOStHijiuPw7+fmWldihrYwM8eO9QamXllIYVNJeLKIBxMUatRLDH5VWNj K6/Q== X-Forwarded-Encrypted: i=1; AJvYcCVkl/H1mZoT0CLfKLOiaDm2VLhAk7gKRK4J/hdBSHMgtl8xd7sBaIOGdroPVmiBu2N4/fgZehQs08yqS4+mPt+Vky+SLByrBpq+MWlnezWwNsETT6A= X-Gm-Message-State: AOJu0YxuTqp/K0jd1bh8nYN6WUXd2MAIxlHk2JDkN48eugBmP3X5SYt+ 4GNxY9buwh2j30Awv57eMlrAFg/RyWoF1eh8/3MxOl65nJB3om7Vv7At8HkRRnngQ+PF39LtwDj S8w== X-Google-Smtp-Source: AGHT+IHjgF0Ca8ethUSfrozdkFUFp0o0AUPtEhLPgrNZWa8lbUZ7qZQp3Z7lR+cNHb6EVM2g/AygpE/k1/Q= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:f16:b0:691:a38c:a61d with SMTP id 00721157ae682-691a39bf26cmr3721507b3.3.1722901982364; Mon, 05 Aug 2024 16:53:02 -0700 (PDT) Date: Mon, 5 Aug 2024 16:53:01 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-55-seanjc@google.com> Message-ID: Subject: Re: [PATCH v12 54/84] KVM: arm64: Mark "struct page" pfns accessed/dirty before dropping mmu_lock From: Sean Christopherson To: Oliver Upton Cc: Paolo Bonzini , Marc Zyngier , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens , Fuad Tabba Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_165304_297031_4B178E96 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 05, 2024, Oliver Upton wrote: > > > --- > > > arch/arm64/kvm/mmu.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > > index 22ee37360c4e..ce13c3d884d5 100644 > > > --- a/arch/arm64/kvm/mmu.c > > > +++ b/arch/arm64/kvm/mmu.c > > > @@ -1685,15 +1685,17 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > > } > > > > > > out_unlock: > > > + if (writable && !ret) > > > + kvm_set_pfn_dirty(pfn); > > > > I'm guessing you meant kvm_release_pfn_dirty() here, because this leaks > > a reference. Doh, I did indeed. Alternatively, this could be: if (writable && !ret) kvm_set_pfn_dirty(pfn); kvm_release_pfn_clean(pfn); It won't matter in the end, because this just becomes: kvm_release_faultin_page(kvm, page, !!ret, writable); So I guess the question is if you prefer to make the switch to an if-else in this path, or more implicitly in the conversion to kvm_release_faultin_page(). I made the same goof for RISC-V, perhaps to prove that I too can copy+paste arm64's MMU code ;-)