linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Baoquan He <bhe@redhat.com>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
	akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ARM: Support allocating crashkernel above 4G for LPAE
Date: Tue, 6 Aug 2024 09:34:39 +0100	[thread overview]
Message-ID: <ZrHgH9hFADBJrtJ6@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZrHasuAXM2Ph9V5p@MiWiFi-R3L-srv>

On Tue, Aug 06, 2024 at 04:11:30PM +0800, Baoquan He wrote:
> I am fine with it. BUT have you addressed Russell's concern, e.g how to
> test it actually?

Thanks for bringing that up.

Let me reinforce my position on this. I will _not_ be accepting a patch
that allows the crash kernel to be placed into high memory on 32-bit
ARM unless it has been thoroughly tested to prove that it can actually
work.

Right now, I don't believe it can work as placing the kernel in highmem
likely means it will be located *outside* of the lower 4GiB of physical
memory which is all that will be accessible when the MMU is turned off.
This is a pre-condition to boot a kernel - the kernel image _must_ be
located within a region of memory which is exposed to the CPU when the
MMU is turned off.

Unless it can be proven that placing the kernel in highmem means that
the kernel will be located in the lower 4GiB of physical memory space
with the MMU off, then further work on this patch is a waste of time.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!


  reply	other threads:[~2024-08-06  8:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02  9:25 [RFC PATCH] ARM: Support allocating crashkernel above 4G for LPAE Jinjie Ruan
2024-08-02 11:01 ` Russell King (Oracle)
2024-08-05  1:23   ` Jinjie Ruan
2024-08-05  2:56     ` Baoquan He
2024-08-06  2:46       ` Jinjie Ruan
2024-08-06  8:11         ` Baoquan He
2024-08-06  8:34           ` Russell King (Oracle) [this message]
2024-08-06 11:02             ` Baoquan He
2024-08-06 11:10             ` Jinjie Ruan
2024-08-06 11:08           ` Jinjie Ruan
2024-08-05 13:18   ` Catalin Marinas
2024-08-06  2:19     ` Jinjie Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrHgH9hFADBJrtJ6@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruanjinjie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).