From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53853C52D6D for ; Tue, 6 Aug 2024 08:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6a8UVs78b8Kbnh8esRwUDysH0sXB9nMDXzMjC+Yj8WM=; b=KADe6SC0iFTAHx7VBUlZyEH3Cv JAmY5NuCk1GtvV1wSBuCHl6pHdk0m+NDsmsNJ5eDZU9IlFLBTmuoUPqXM+BaRBnzIPDzUgjUCdVWx iuqX3FO7j6d9gUwywwMfTFIW/3pLhxkA7MA0vXgFhULdzp3/ptjsf+tya8rO5uxiqcwm0uPHMAlz5 O+C+6u4B6vZnXejKose9o4Cww15PJ5mRHbk5cWzadI/Q0IunZcE6fbgzHIty0V/0Cmsc6lrOz7A9t zKIDlWU2km8X4f/pm5uTzdtBJY1jTT52SJlT6wwyC8tz1A7TJ85L65KN2yJGzM964PeF8tdkb3S6n qH+0qptA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbFf8-00000000xsS-3X8I; Tue, 06 Aug 2024 08:35:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbFeb-00000000xmA-19hO for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 08:34:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6a8UVs78b8Kbnh8esRwUDysH0sXB9nMDXzMjC+Yj8WM=; b=agqLfE/bqeTfnGM0i9TRH67frb r6OVfT2d3A45dHBABoMMa+Xabhdzi1kQ1gNS0ZET2twKmiAOODaOg0WZaZW84vNpUfmv/egh8Mvf4 o0+spDamwvdeIp4JWUL44pGIOunP63tkUUmgdz65mzxX3iq8kpZLpWpgkdjlRPUnZQBSaDvqTkc8+ eMsYuZx53gjzpVyWHL+msEC6z4kfDkFxzndD7pXYlU1mWs0cXmzmc9n7fMUhluuw8ej43L+kHkpGo zmLVL9MZgG9e1JgJ5hNPhlhmOQ3C+Jsb6/b0FS8KagHvXkSpUnhRu83V9hpNrWV76G4wWE0Ez6oBj 4or0Wfxw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46594) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sbFeP-0004IE-1I; Tue, 06 Aug 2024 09:34:37 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sbFeR-0003CL-WC; Tue, 06 Aug 2024 09:34:40 +0100 Date: Tue, 6 Aug 2024 09:34:39 +0100 From: "Russell King (Oracle)" To: Baoquan He Cc: Jinjie Ruan , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] ARM: Support allocating crashkernel above 4G for LPAE Message-ID: References: <20240802092510.3915986-1-ruanjinjie@huawei.com> <6c0a45c3-08a2-f889-9e66-ab8aff66ae8c@huawei.com> <8f051483-46be-87b6-03bb-5e0d145a2ac3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_013449_336024_628A945B X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2024 at 04:11:30PM +0800, Baoquan He wrote: > I am fine with it. BUT have you addressed Russell's concern, e.g how to > test it actually? Thanks for bringing that up. Let me reinforce my position on this. I will _not_ be accepting a patch that allows the crash kernel to be placed into high memory on 32-bit ARM unless it has been thoroughly tested to prove that it can actually work. Right now, I don't believe it can work as placing the kernel in highmem likely means it will be located *outside* of the lower 4GiB of physical memory which is all that will be accessible when the MMU is turned off. This is a pre-condition to boot a kernel - the kernel image _must_ be located within a region of memory which is exposed to the CPU when the MMU is turned off. Unless it can be proven that placing the kernel in highmem means that the kernel will be located in the lower 4GiB of physical memory space with the MMU off, then further work on this patch is a waste of time. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!