From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD3D7C3DA64 for ; Tue, 6 Aug 2024 13:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DHHyZAVPdBTuaJL0Fvbykwyj/SRZ2vJZKc6eZY0VMnQ=; b=gcF+JCRzXck8zXQ4RWQyjIXpjf cR4FQ2UkfjAdZ1bQyJgEz8OmOA+2AOWKm+SGAHvPJEeXDFLFv5ogxyhKmUv57n+NPDZtV6jCf1SFr +OjrG+OfwTtTmirWIBNaqHyfyTxbbjQBHSem2exHa3+EojRNbv3tZRCyvW3c7PTHeOnX+1Jw0JUUM RA01+ekQ618xBt4ntEs8pD4flkQXYMd0rdP8OJgYmeiNfe6O2URhLiv2892Gdj0oViwo8oQHDi2LG 8Q7MPNe6+98SNKqwmT7tr6kH6xaJA6uEe1oaC02DXbIjFpIzbwv76rcBc608eEav34Ppxb68EvUK7 25fH00Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbK11-00000001g5P-2mKI; Tue, 06 Aug 2024 13:14:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbJzb-00000001fTT-2mBP for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 13:12:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21091FEC; Tue, 6 Aug 2024 06:13:10 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C2BC23F766; Tue, 6 Aug 2024 06:12:41 -0700 (PDT) Date: Tue, 6 Aug 2024 14:12:39 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, ptosi@google.com, dan.carpenter@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v3 5/9] firmware: arm_scmi: Make MBOX transport a standalone driver Message-ID: References: <20240730133318.1573765-1-cristian.marussi@arm.com> <20240730133318.1573765-6-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240730133318.1573765-6-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_061247_763300_33B78C8E X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 30, 2024 at 02:33:14PM +0100, Cristian Marussi wrote: > Make SCMI mailbox transport a standalne driver that can be optionally > loaded as a module. > > Signed-off-by: Cristian Marussi > --- > v2 --> v3 > - fixed spacing in Kconfig > - updated Copyright > - use new params in DEFINE_SCMI_TRANSPORT_DRIVER > --- > drivers/firmware/arm_scmi/Kconfig | 4 +- > drivers/firmware/arm_scmi/Makefile | 3 +- > drivers/firmware/arm_scmi/common.h | 3 -- > drivers/firmware/arm_scmi/driver.c | 3 -- > .../{mailbox.c => scmi_transport_mailbox.c} | 47 +++++++++++++------ > 5 files changed, 38 insertions(+), 22 deletions(-) > rename drivers/firmware/arm_scmi/{mailbox.c => scmi_transport_mailbox.c} (87%) I am happy with the changes in the series, they all look good. I wonder if it makes sense to move transport drivers into a separate folder drivers/firmware/arm_scmi/transport/{mailbox,smc,optee,virtio}.c In scmi_transport_*.c, I see scmi is redundant and transport can be eliminated by moving all under the folder with that name. Thoughts ? -- Regards, Sudeep