From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AFDCC3DA64 for ; Tue, 6 Aug 2024 13:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bn9b3zbad8ULRvUrxqa2F+594BAELRQI/HGI+8OMUpw=; b=NVtfn1d12kgahkswx8aancM7Nw n8m6fdu+FhMsoMTWghBxLhG/LS/7Xn/ud+bjQ7SKWBjBSNKgDL4b8kZ14km4KHEXJf+AQNrA6hp7r MVVMstjsX0z65cTDTTOZQr4QAYo7aXAVk/mou93In8WyXGBYGOWLFG2fJybBwzqt0sh4Qi/GWyfjw m/Qk+XBI1cnAB78RzGLc7MJ2w4CovRdvlMhujryaEpbpOuLUDiQLpJOh4+xp6oV1EfR2pBqVRGqSs z23cYG/MrNHm80V/qLsOq/Y/wr/kmOFoQKb5v+VHsoJt9LnMRrdKeJxsy9AZkom6203DMW0Rb2D6Y TI69TqYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbKaV-00000001rII-3HbB; Tue, 06 Aug 2024 13:50:55 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbKZm-00000001r3p-33Z3; Tue, 06 Aug 2024 13:50:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6CEFACE0B5F; Tue, 6 Aug 2024 13:50:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CF8AC32786; Tue, 6 Aug 2024 13:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722952207; bh=ViNFQZX1KF1hgpgV7zrHw49j/8aYGn1Bq6dW4VSWMQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BhZvdBoZrlmlZpD01wdDp/IWpLtwBKX/SA9QtGZU9A8MTSXpgHAmxDVr5RxmMD9ZR efw/I/gK/ELlECqGASEcUDUgXegxHJsPQrtU211cM6tK/lGd+j9f+LNG/DO0tmiYvR 0Cih9Gs+cEX8Rf8lfQjRFqEGQYNf9tKc6HvHOcQNtAg3nkinHVYSQ92RyHxuABfj0E DWEhTjX9Z56jKtf6GNxwIGeoFPWvXAbBi42rdAEgY+NIRC7AhImGz0YPGnQTjy2HYT 6AqILYuQvu9QoLe4AZ7nuN5XSgq0zaHTaLA2k/mRNhhnl1McyTfJvN8ys8/KYC5b5+ 5lcTx1P5JmtDw== Date: Tue, 6 Aug 2024 10:50:04 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Eric Lin , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , Charles Ci-Jyun Wu , Locus Wei-Han Chen , Atish Patra , Ji Sheng Teoh , Inochi Amaoto , Jing Zhang , Xu Yang , Sandipan Das , Guilherme Amadio , Changbin Du , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, vincent.chen@sifive.com, greentime.hu@sifive.com Subject: Re: [PATCH v1 4/5] perf pmu-events: Remove duplicated riscv firmware event Message-ID: References: <20240805194424.597244-1-irogers@google.com> <20240805194424.597244-4-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_065011_170656_4E2D41BE X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2024 at 10:38:07AM -0300, Arnaldo Carvalho de Melo wrote: > On Mon, Aug 05, 2024 at 09:05:26PM -0700, Ian Rogers wrote: > > On Mon, Aug 5, 2024 at 8:54 PM Eric Lin wrote: > > > I've sent a patch to fix it and the patch already merged. Thanks. > > > https://lore.kernel.org/all/20240719115018.27356-1-eric.lin@sifive.com/ > > Right, I already commented this should have gone through the > > perf-tools-next tree: > > https://lore.kernel.org/all/CAP-5=fV3NXkKsCP1WH0_qLRNpL+WuP8S3h1=cHaUMH5MFkVHQg@mail.gmail.com/ > > Arnaldo, please take Eric's patch in preference to this one. > So I removed your version from perf-tools-next, eventually we'll get > this merged upstream, I'm just checking this isn't going to get in our > way of testing what we have in perf-tools-next... As expected: ⬢[acme@toolbox perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test make_no_libdw_dwarf_unwind_O: cd . && make NO_LIBDW_DWARF_UNWIND=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.1xBTPCPJh1 DESTDIR=/tmp/tmp.6upZRBhUpN make_jevents_all_O: cd . && make JEVENTS_ARCH=all FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.ncjKsS9Ddm DESTDIR=/tmp/tmp.z2lxV44jzL cd . && make JEVENTS_ARCH=all FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j28 O=/tmp/tmp.ncjKsS9Ddm DESTDIR=/tmp/tmp.z2lxV44jzL BUILD: Doing 'make -j28' parallel build Warning: Kernel ABI header differences: diff -u tools/include/uapi/drm/i915_drm.h include/uapi/drm/i915_drm.h LD /tmp/tmp.ncjKsS9Ddm/util/perf-util-in.o LD /tmp/tmp.ncjKsS9Ddm/perf-util-in.o AR /tmp/tmp.ncjKsS9Ddm/libperf-util.a Traceback (most recent call last): File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 1317, in main() File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 1308, in main ftw(arch_path, [], process_one_file) File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 1245, in ftw ftw(item.path, parents + [item.name], action) File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 1243, in ftw action(parents, item) File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 646, in process_one_file print_pending_events() File "/home/acme/git/perf-tools-next/tools/perf/pmu-events/jevents.py", line 510, in print_pending_events assert event.name != last_name, f"Duplicate event: {last_pmu}/{last_name}/ in {_pending_events_tblname}" ^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: Duplicate event: default_core/fw_sfence_vma_received/ in pmu_events__andes_ax45 make[5]: *** [pmu-events/Build:46: /tmp/tmp.ncjKsS9Ddm/pmu-events/pmu-events.c] Error 1 make[5]: *** Deleting file '/tmp/tmp.ncjKsS9Ddm/pmu-events/pmu-events.c' make[4]: *** [Makefile.perf:763: /tmp/tmp.ncjKsS9Ddm/pmu-events/pmu-events-in.o] Error 2 So I'll have to cherry pick that patch and have it in perf-tools-next, we'll get notified at some point that linux-next has the same patch, will ack that, etc. Please send patches for this area in the future to the perf-tools-next tree. - Arnaldo