From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A573FC52D71 for ; Tue, 6 Aug 2024 16:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dFx8muPjgUqlOVvO7zvC8LDKQtAMD4lcVClXfhcbY6c=; b=4qAEalf92/Gynxt6sl/CDhcyE5 LslEAOF05F6tMYpGyrXwwjP72/Q1EJSQvnoqs5IkyxMHNsvaLkMDc+QEzborerQ6LwHSYRhRxbcXh 1UNOFwisspcymVRsYMXHEOnXmzBnopuDjxNLQT8py2MiXkydf1Fcvikku22YhNlierk8pMSzMFhxV JoQ2N0UEI0jYiiBowlS0phhjA/AknKFn1fSe5WkM9sHZLeaZ83zFlr9Tww2v0rOr+tdArxRzpdheH QzydluDYosAzgxWYnhgokSuPJQBIv55ImbfNi6UP52K9ZYfT5WXoHq5uym/Pl4YsyKAELZaxeAcFx 7iqzNMKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbN9z-00000002Mry-0uEo; Tue, 06 Aug 2024 16:35:43 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbN9Q-00000002MjI-2cHx; Tue, 06 Aug 2024 16:35:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id ACCF8CE0EEE; Tue, 6 Aug 2024 16:35:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C09AAC32786; Tue, 6 Aug 2024 16:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722962105; bh=uQqSa2ju/OwNtv4V5r1lb+pBWDYjfdDGks/rRhWKkQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rFbtzxU/9vfJ1XsILpQQPsivG1Pyogx2CI6NstcraYijdi2mzSCTxW4WvVPUs08Ko 6z0T8GGW5fCwuNikTj97SLFnGlJu3JkkfFsXiXnyII7JsnfqT1RxUwAQgkWX9v/zhS 4lGBViEWOHfWrzNRBp/GU5zVFKovj0T5LsBLwbtM/S0raRISU/kgybv+XkL39qeII1 vUpfdm2a4Z1/px0JCHRgBvGxTHDKC3dP8BFcfDo8iWier3zg/ajS+ejh6Oz+MzSPUt yXkh0sFiqQ3wf+mN4LIb2snalsqq3hDlVCEbir0xKdtHa95lfwG+CoGXv8lXzKI+TU 4EntyrvOy7bkQ== Date: Tue, 6 Aug 2024 18:34:58 +0200 From: Lorenzo Pieralisi To: Catalin Marinas Cc: Haibo Xu , ajones@ventanamicro.com, sunilvl@ventanamicro.com, xiaobo55x@gmail.com, Anshuman Khandual , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Cameron , Hanjun Guo , James Morse , "Russell King (Oracle)" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 2/2] arm64: ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Message-ID: References: <0d362a8ae50558b95685da4c821b2ae9e8cf78be.1722828421.git.haibo1.xu@intel.com> <853d7f74aa243f6f5999e203246f0d1ae92d2b61.1722828421.git.haibo1.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_093509_146454_1A3532AF X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 05, 2024 at 04:21:34PM +0100, Catalin Marinas wrote: > On Mon, Aug 05, 2024 at 11:30:24AM +0800, Haibo Xu wrote: > > Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE. > > To ensure all the values were properly initialized, switch to initialize > > all of them to NUMA_NO_NODE. > > > > Fixes: e18962491696 ("arm64: numa: rework ACPI NUMA initialization") > > Reported-by: Andrew Jones > > Suggested-by: Andrew Jones > > Signed-off-by: Haibo Xu > > Reviewed-by: Anshuman Khandual > > Reviewed-by: Sunil V L > > Reviewed-by: Andrew Jones > > --- > > arch/arm64/kernel/acpi_numa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > > index 0c036a9a3c33..2465f291c7e1 100644 > > --- a/arch/arm64/kernel/acpi_numa.c > > +++ b/arch/arm64/kernel/acpi_numa.c > > @@ -27,7 +27,7 @@ > > > > #include > > > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; Bah, silly me, sorry. > Acked-by: Catalin Marinas > > The patch makes sense but is there any issue currently without it? I suspect there might be - a cpu associated with NUMA node 0 when it is actually unspecified in ACPI tables (well, probably not even a real world bug - I don't know, that's why it was not caught earlier I believe) but still. > Trying to assess whether it needs a stable backport. Whether that's a real bug or not depends on deployed ACPI firmware tables; if all cores have a proximity domain assigned in the respective SRAT entries this patch is irrelevant but technically it is a bug to fix, yes. Backporting would make sense, it should be innocuous. Acked-by: Lorenzo Pieralisi