From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54771C52D71 for ; Tue, 6 Aug 2024 17:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LQE6YoiTBc8a0Cn9HW3mmOCyJJfigN5dOuX+8QQgnUY=; b=qIeUTMnwEtqZO+4zzTD/0WvsaT b/eHTntu4g26Bmmx60z7tkqlwE7d/s2XsL9EeNVz2Ioh8PF6SXsisLRAM8wq+I4PFeXImtgSIqZ1/ h8yG1XpR1bJ2aI2z9nAqHtnBXCjPrCAEHcLw1L055JPECpV8b3R34e3Zx5n4wjgCCBuSxijBv34fW 1vGVfTM/Rf9EzGoUOzpmjIlk16SHMnWHljIv8VjdVgny4pGewrfimelmFVQ2DnAZS0/qWYh79v0zu gQ29jGd8bSBbJZofAhZTFi55zwPyA3GIlVC81tRzVohifAMHCr2ZlIDVkNOigk3Pc1faQ4opcF/Pr bR9UzI3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbNZi-00000002QaU-1dp5; Tue, 06 Aug 2024 17:02:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbNZ9-00000002QNt-1H89 for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 17:01:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC8ACFEC; Tue, 6 Aug 2024 10:02:06 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D26243F766; Tue, 6 Aug 2024 10:01:38 -0700 (PDT) Date: Tue, 6 Aug 2024 18:01:26 +0100 From: Cristian Marussi To: Florian Fainelli Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, ptosi@google.com, dan.carpenter@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v3 0/9] Make SCMI transport as standalone drivers Message-ID: References: <20240730133318.1573765-1-cristian.marussi@arm.com> <6c2b185e-42d4-408b-a7f5-972b2099067b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c2b185e-42d4-408b-a7f5-972b2099067b@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_100143_447890_C949ED11 X-CRM114-Status: GOOD ( 32.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2024 at 09:47:17AM -0700, Florian Fainelli wrote: > On 7/30/24 06:33, Cristian Marussi wrote: > > Hi all, > > > > Till now the SCMI transport layer was being built embedded into in the core > > SCMI stack. > > > > Some of these transports, despite being currently part of the main SCMI > > module, are indeed also registered with different subsystems like optee or > > virtio, and actively probed also by those: this led to a few awkward and > > convoluted tricks to properly handle such interactions at boot time in the > > SCMI stack. > > > > Moreover some partner expressed the desire to be able to fully modularize > > the transports components. > > > > This series aim to make all such transports as standalone drivers that can > > be optionally loaded as modules. > > > > In order to do this, at first some new mechanism is introduced to support > > this new capability while maintaining, in parallel, the old legacy embedded > > transports; then each transport, one by one, is transitioned to be a > > standalone driver and finally the old legacy support for embedded transport > > is removed. > > > > Patch [1/9] is a fix around the chan_free method for OPTEE transport; it is > > really unrelated to this series, but included to avoid conflicts. > > > > Patch [2/9] is a mostly unrelated (but much needed) clean-up from Peng, > > which I included in this series to avoid conflicts at merge. > > > > Patch [3/9] simply collects the existing datagram manipulation helpers in a > > pair of function pointers structures, in preparation for later reworks. > > > > Patch [4/9] adds the bulk of the new logic to the core SCMI stack and then > > each existing transport is transitioned to be a standalone driver in > > patches 5,6,7,8 while shuffling around the compatibles. (no DT change is > > needed of curse for backward compatibility) > > While doing this I kept the module authorship in line with the main > > author(S) as spitted out by git-blame. > > > > Finally patch [9/9] removes all the legacy dead code from the core SCMI > > stack. > > > > No new symbol EXPORT has been added. > > > > The new transport drivers have been tested, as built-in and LKM, as > > follows: > > > > - mailbox on JUNO > > - virtio on emulation > > - optee on QEMU/optee using Linaro setup > > > > Exercised using the regular SCMI drivers stack and the SCMI ACS suite, > > testing commands, replies, delayed responses and notification. > > > > Multiple virtual SCMI instances support has been tested too. > > > > SMC has NOT been tested/exercised at run-time, only compile-tested. > > (due to lack of hardware) > > > > Note that in this new setup, all the probe deferral and retries between the > > SCMI core stack and the transports has been removed, since no more needed. > > > > Moreover the new drivers have been tested also with a fully modularized > > SCMI stack, i.e.: > > > > scmi-core.ko + scmi-module.ko + scmi_transport_*.ko [ + vendor modules ] > > > > Based on v6.11-rc1 > > > > Any feedback, and especially testing (:D) is welcome. > > Tested-by: Florian Fainelli Thanks ! Cristian