From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6CC9C3DA7F for ; Wed, 7 Aug 2024 09:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=alrAEwTk/9ZGL+1f7lSqNYp1lnxaGoa+HaCOobuYYh0=; b=AtOE43stwvYH8sdEG75VMlf0m5 /IjaatjI50rjJ0zReI7tPRtOP/LeBlGpoHU+X0T0I3N2SqSU7HsQe6py21R4+DKWLc29rGD16SZK9 0HeVB7w4MfhSJZwRfAyQXfwI4Tu7M+KBTZ26zrHjkVLWsrv43WYV508tPug+3MDBlHrJpnTVfwIAs mrg3NQx47sLZQ/nO2aw176wOjOymoZRkMPbopsIaCO/Fu1CPabs662PDwm4jxflg5LSkR0DdHbt8t 9P5R418SqlWkamH7eBYY4CyMBLynb+jQS+bxEv5fspc7qMT3EwDBwNFFTdM9MxbWncI78mcF8F7bB I06ig0cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbcyx-00000004YHk-288y; Wed, 07 Aug 2024 09:29:23 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbcyQ-00000004YCm-2vJN for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 09:28:51 +0000 Received: by mail-il1-x134.google.com with SMTP id e9e14a558f8ab-39728bbf949so7225705ab.3 for ; Wed, 07 Aug 2024 02:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1723022928; x=1723627728; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=alrAEwTk/9ZGL+1f7lSqNYp1lnxaGoa+HaCOobuYYh0=; b=OiZOsa4nHGXJ2bwGQxDZjh1PLNj+yf8kebFOQ322Jjj59/r3gtaninoQcEiZUVTtIX 60j9slft7yx/8dymrQUGrxANcfkd8FrJ5UgD7iwYI8qU9wIniUe/l0pkWeCpc/8/Geuz IYBwY+NIvlhXXlrMcxAOKzNexdpe9pNxOxvgAKOYXcGWgXQrvsuqJ8EI5eZSIN7Oqtq0 k05thLgXHhXtpY4fZH3o10cJcB84zwVPkttQB0fit+2aEPTUtSWfHpHaeAdtcVyt90/C hHA+M9LBbZ33YR78ktd4s0R4cJOIwi0X1iI7yMBZt6fPZaxMrQpejbFODUfqB4DsRP0A YJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723022928; x=1723627728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=alrAEwTk/9ZGL+1f7lSqNYp1lnxaGoa+HaCOobuYYh0=; b=qWQvS/+KMMYYWpevAUrA6Z3EGR8X3n8RKjwsSNMMNMreHUkMn9GlgYx47wf+S4O6sL PWqRvfM2C6L9qekHHv+QACmUs54yjn3gWP98K5E0rqPNwAA2llzzjdZTPaX3Q2LpFweh 9mY8ih1LJkT9a786HjHUUzl5mnO6QDPo6hH2TjyZsbXoquW21+mbRTZggUiOnaUm9NAs j+KIRau+PXPltg1+Ea95iSnzkfwAYzlXgvNaJvidVW7lNUZhFILXlHwT8JIYnz57mHG7 Op2eciKhR39//V32hbVWWWX/vrYLdGiARKV7j0cnQkwltvGk6roHvgOWLo34pPsK8+K2 NfHA== X-Forwarded-Encrypted: i=1; AJvYcCXhghLCLVlDD+1GSJCJtctboyR0tgTSMmJ0oKelPTE0HVlmpkuo5Aoj269J61hyfUyMRmXrn5nV7MIGSX9w/Z1Qe9ISE2Wb3LxdRj0KApQNZZGitCc= X-Gm-Message-State: AOJu0Yz4TR5m9y1myQn78vBZoyIQHO5fADLVRiQQSQ6taKhiEj7wP+4Z fqgS1RgPYo8RXtXhKT0M9fu7ldKDAFoCdEc8RmfD98w0GonKP1AEerxkduw8V8s= X-Google-Smtp-Source: AGHT+IGFi2yTi8mjGa/JDQgJ5ePUMCC2uiP0+ISk+Z8ei9aOJgQKjnFm1sJATScT5YUF9A+EBCrw2g== X-Received: by 2002:a92:d8d1:0:b0:39a:e9c4:6baf with SMTP id e9e14a558f8ab-39b1fc37596mr158866065ab.26.1723022927664; Wed, 07 Aug 2024 02:28:47 -0700 (PDT) Received: from sunil-laptop ([106.51.198.16]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b762e9f5aasm8091871a12.6.2024.08.07.02.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 02:28:47 -0700 (PDT) Date: Wed, 7 Aug 2024 14:58:42 +0530 From: Sunil V L To: shankerwangmiao@gmail.com Cc: Hanjun Guo , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ACPI: introduce acpi_arch_init Message-ID: References: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_022850_759085_DBED47F9 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 07, 2024 at 02:36:12PM +0800, Miao Wang via B4 Relay wrote: > From: Miao Wang > > To avoid arch-specific code in general ACPI initialization flow, > we introduce a weak symbol acpi_arch_init. Currently, arm64 can > utillize this to insert its specific flow. In the future, > other architectures can also have chance to define their own > arch-specific acpi initialization process if necessary. > > Signed-off-by: Miao Wang > --- > Changes from v1 > - Change acpi_arch_init from a static inline stub to a weak function > according to Haijun Guo's advice > --- > drivers/acpi/arm64/init.c | 2 +- > drivers/acpi/bus.c | 4 +++- > include/linux/acpi.h | 6 +----- > 3 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c > index d0c8aed90fd1..7a47d8095a7d 100644 > --- a/drivers/acpi/arm64/init.c > +++ b/drivers/acpi/arm64/init.c > @@ -2,7 +2,7 @@ > #include > #include "init.h" > > -void __init acpi_arm_init(void) > +void __init acpi_arch_init(void) > { > if (IS_ENABLED(CONFIG_ACPI_AGDI)) > acpi_agdi_init(); > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 284bc2e03580..b47541e45a5a 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void) > struct kobject *acpi_kobj; > EXPORT_SYMBOL_GPL(acpi_kobj); > > +void __weak acpi_arch_init(void) { } > + > static int __init acpi_init(void) > { > int result; > @@ -1458,7 +1460,7 @@ static int __init acpi_init(void) > acpi_viot_early_init(); > acpi_hest_init(); > acpi_ghes_init(); > - acpi_arm_init(); > + acpi_arch_init(); > acpi_scan_init(); > acpi_ec_init(); > acpi_debugfs_init(); > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 0687a442fec7..52862c377747 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1523,11 +1523,7 @@ static inline int find_acpi_cpu_topology_hetero_id(unsigned int cpu) > } > #endif > > -#ifdef CONFIG_ARM64 > -void acpi_arm_init(void); > -#else > -static inline void acpi_arm_init(void) { } > -#endif > +void acpi_arch_init(void); > LGTM. Reviewed-by: Sunil V L Thanks, Sunil