* [PATCH v2] ACPI: introduce acpi_arch_init
@ 2024-08-07 6:36 Miao Wang via B4 Relay
2024-08-07 9:28 ` Sunil V L
2024-08-08 8:46 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Miao Wang via B4 Relay @ 2024-08-07 6:36 UTC (permalink / raw)
To: Hanjun Guo, Rafael J. Wysocki, Len Brown, Sunil V L
Cc: linux-acpi, linux-arm-kernel, Miao Wang
From: Miao Wang <shankerwangmiao@gmail.com>
To avoid arch-specific code in general ACPI initialization flow,
we introduce a weak symbol acpi_arch_init. Currently, arm64 can
utillize this to insert its specific flow. In the future,
other architectures can also have chance to define their own
arch-specific acpi initialization process if necessary.
Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
---
Changes from v1
- Change acpi_arch_init from a static inline stub to a weak function
according to Haijun Guo's advice
---
drivers/acpi/arm64/init.c | 2 +-
drivers/acpi/bus.c | 4 +++-
include/linux/acpi.h | 6 +-----
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c
index d0c8aed90fd1..7a47d8095a7d 100644
--- a/drivers/acpi/arm64/init.c
+++ b/drivers/acpi/arm64/init.c
@@ -2,7 +2,7 @@
#include <linux/acpi.h>
#include "init.h"
-void __init acpi_arm_init(void)
+void __init acpi_arch_init(void)
{
if (IS_ENABLED(CONFIG_ACPI_AGDI))
acpi_agdi_init();
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 284bc2e03580..b47541e45a5a 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void)
struct kobject *acpi_kobj;
EXPORT_SYMBOL_GPL(acpi_kobj);
+void __weak acpi_arch_init(void) { }
+
static int __init acpi_init(void)
{
int result;
@@ -1458,7 +1460,7 @@ static int __init acpi_init(void)
acpi_viot_early_init();
acpi_hest_init();
acpi_ghes_init();
- acpi_arm_init();
+ acpi_arch_init();
acpi_scan_init();
acpi_ec_init();
acpi_debugfs_init();
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 0687a442fec7..52862c377747 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -1523,11 +1523,7 @@ static inline int find_acpi_cpu_topology_hetero_id(unsigned int cpu)
}
#endif
-#ifdef CONFIG_ARM64
-void acpi_arm_init(void);
-#else
-static inline void acpi_arm_init(void) { }
-#endif
+void acpi_arch_init(void);
#ifdef CONFIG_ACPI_PCC
void acpi_init_pcc(void);
---
base-commit: d4560686726f7a357922f300fc81f5964be8df04
change-id: 20240807-intro-acpi-arch-init-fc99fe33e62d
Best regards,
--
Miao Wang <shankerwangmiao@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: introduce acpi_arch_init
2024-08-07 6:36 [PATCH v2] ACPI: introduce acpi_arch_init Miao Wang via B4 Relay
@ 2024-08-07 9:28 ` Sunil V L
2024-08-08 8:46 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sunil V L @ 2024-08-07 9:28 UTC (permalink / raw)
To: shankerwangmiao
Cc: Hanjun Guo, Rafael J. Wysocki, Len Brown, linux-acpi,
linux-arm-kernel
On Wed, Aug 07, 2024 at 02:36:12PM +0800, Miao Wang via B4 Relay wrote:
> From: Miao Wang <shankerwangmiao@gmail.com>
>
> To avoid arch-specific code in general ACPI initialization flow,
> we introduce a weak symbol acpi_arch_init. Currently, arm64 can
> utillize this to insert its specific flow. In the future,
> other architectures can also have chance to define their own
> arch-specific acpi initialization process if necessary.
>
> Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
> ---
> Changes from v1
> - Change acpi_arch_init from a static inline stub to a weak function
> according to Haijun Guo's advice
> ---
> drivers/acpi/arm64/init.c | 2 +-
> drivers/acpi/bus.c | 4 +++-
> include/linux/acpi.h | 6 +-----
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c
> index d0c8aed90fd1..7a47d8095a7d 100644
> --- a/drivers/acpi/arm64/init.c
> +++ b/drivers/acpi/arm64/init.c
> @@ -2,7 +2,7 @@
> #include <linux/acpi.h>
> #include "init.h"
>
> -void __init acpi_arm_init(void)
> +void __init acpi_arch_init(void)
> {
> if (IS_ENABLED(CONFIG_ACPI_AGDI))
> acpi_agdi_init();
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 284bc2e03580..b47541e45a5a 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void)
> struct kobject *acpi_kobj;
> EXPORT_SYMBOL_GPL(acpi_kobj);
>
> +void __weak acpi_arch_init(void) { }
> +
> static int __init acpi_init(void)
> {
> int result;
> @@ -1458,7 +1460,7 @@ static int __init acpi_init(void)
> acpi_viot_early_init();
> acpi_hest_init();
> acpi_ghes_init();
> - acpi_arm_init();
> + acpi_arch_init();
> acpi_scan_init();
> acpi_ec_init();
> acpi_debugfs_init();
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 0687a442fec7..52862c377747 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -1523,11 +1523,7 @@ static inline int find_acpi_cpu_topology_hetero_id(unsigned int cpu)
> }
> #endif
>
> -#ifdef CONFIG_ARM64
> -void acpi_arm_init(void);
> -#else
> -static inline void acpi_arm_init(void) { }
> -#endif
> +void acpi_arch_init(void);
>
LGTM.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks,
Sunil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: introduce acpi_arch_init
2024-08-07 6:36 [PATCH v2] ACPI: introduce acpi_arch_init Miao Wang via B4 Relay
2024-08-07 9:28 ` Sunil V L
@ 2024-08-08 8:46 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2024-08-08 8:46 UTC (permalink / raw)
To: shankerwangmiao
Cc: Hanjun Guo, Sudeep Holla, Rafael J. Wysocki, Len Brown, Sunil V L,
linux-acpi, linux-arm-kernel
On Wed, Aug 07, 2024 at 02:36:12PM +0800, Miao Wang via B4 Relay wrote:
> From: Miao Wang <shankerwangmiao@gmail.com>
>
> To avoid arch-specific code in general ACPI initialization flow,
> we introduce a weak symbol acpi_arch_init. Currently, arm64 can
> utillize this to insert its specific flow. In the future,
> other architectures can also have chance to define their own
> arch-specific acpi initialization process if necessary.
>
> Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
> ---
> Changes from v1
> - Change acpi_arch_init from a static inline stub to a weak function
> according to Haijun Guo's advice
> ---
> drivers/acpi/arm64/init.c | 2 +-
> drivers/acpi/bus.c | 4 +++-
> include/linux/acpi.h | 6 +-----
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c
> index d0c8aed90fd1..7a47d8095a7d 100644
> --- a/drivers/acpi/arm64/init.c
> +++ b/drivers/acpi/arm64/init.c
> @@ -2,7 +2,7 @@
> #include <linux/acpi.h>
> #include "init.h"
>
> -void __init acpi_arm_init(void)
> +void __init acpi_arch_init(void)
> {
> if (IS_ENABLED(CONFIG_ACPI_AGDI))
> acpi_agdi_init();
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 284bc2e03580..b47541e45a5a 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void)
> struct kobject *acpi_kobj;
> EXPORT_SYMBOL_GPL(acpi_kobj);
>
> +void __weak acpi_arch_init(void) { }
> +
Why is __init dropped or not needed above ?
Otherwise looks good. With the above __init fixed, you can add
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-08 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 6:36 [PATCH v2] ACPI: introduce acpi_arch_init Miao Wang via B4 Relay
2024-08-07 9:28 ` Sunil V L
2024-08-08 8:46 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).