From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F2FEC52D71 for ; Thu, 8 Aug 2024 08:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+51IsLQKwIJyRX7Ba7DBlT1eD4daXaVaYt8l3K+1cRs=; b=bYKPpOQh2lASe+/hMumAsgWlrt LNxrAKBMzHyQ4PXPnJ+KbYWaxYGmpZBwMsXElBsu9HXkLrpeCVEhnRtqQAsrhk9mo8nVqh6R5OsuP JrgW+VDzRN+CyicaVw8g69A3Ehrq9Un158LlycWOa+XazFdmqP+Zxq5T/88wbloID/sU9+215Ywrl LjNjUO8OYUjBUJvowLVxh0k+L8hZDj95isw9qH3klFgIuQKah5GxOSU9ULF5a8t1R5IcpzwdblJ4X gVtz+Um+zX9YVLcg7EnQg22J+/rq1pRp/jkjDz7G6yKcaQXgLRWI9Sdm5ywz8iSb6Cz4SjCg6JwdS zjBsKy/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbynt-00000007d7X-36BP; Thu, 08 Aug 2024 08:47:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbynK-00000007d4k-3axo for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 08:46:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 887BCFEC; Thu, 8 Aug 2024 01:47:13 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE2423F71E; Thu, 8 Aug 2024 01:46:46 -0700 (PDT) Date: Thu, 8 Aug 2024 09:46:44 +0100 From: Sudeep Holla To: shankerwangmiao@gmail.com Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Sunil V L , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ACPI: introduce acpi_arch_init Message-ID: References: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_014650_956183_5FD66791 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 07, 2024 at 02:36:12PM +0800, Miao Wang via B4 Relay wrote: > From: Miao Wang > > To avoid arch-specific code in general ACPI initialization flow, > we introduce a weak symbol acpi_arch_init. Currently, arm64 can > utillize this to insert its specific flow. In the future, > other architectures can also have chance to define their own > arch-specific acpi initialization process if necessary. > > Signed-off-by: Miao Wang > --- > Changes from v1 > - Change acpi_arch_init from a static inline stub to a weak function > according to Haijun Guo's advice > --- > drivers/acpi/arm64/init.c | 2 +- > drivers/acpi/bus.c | 4 +++- > include/linux/acpi.h | 6 +----- > 3 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c > index d0c8aed90fd1..7a47d8095a7d 100644 > --- a/drivers/acpi/arm64/init.c > +++ b/drivers/acpi/arm64/init.c > @@ -2,7 +2,7 @@ > #include > #include "init.h" > > -void __init acpi_arm_init(void) > +void __init acpi_arch_init(void) > { > if (IS_ENABLED(CONFIG_ACPI_AGDI)) > acpi_agdi_init(); > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 284bc2e03580..b47541e45a5a 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void) > struct kobject *acpi_kobj; > EXPORT_SYMBOL_GPL(acpi_kobj); > > +void __weak acpi_arch_init(void) { } > + Why is __init dropped or not needed above ? Otherwise looks good. With the above __init fixed, you can add Reviewed-by: Sudeep Holla -- Regards, Sudeep