From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80144C52D7C for ; Fri, 9 Aug 2024 12:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TuWnCcRCiDamAtNdk0SXiVJG3T2vClSNbqBuGGWkMvg=; b=ISD0iZoj6fVQ1wsp/X8WT+RDte GM9l4+8bVWl1JWIzAbTIz/fvfuF5F6YDTAm7G7Si8SAkAzgViBaupzP2jLza4T0FQwvEvZpyO4lP7 51OnQNtePJM7GF6TAeNMqCN/5/Zv2g0OFBR/u/9cCDyMyCpBDPED33+cvLgAX3X6N7urMHulfRgaR NTYFnk/kkN5euu7OfJ0zIVO4g+mEnPFyr4ibpfVk3CQobmTE2u0qGKMRdEe2u/5AG0yNU46YgjeG8 ALgUPb1ObD3L5ivXaw/n77OzMJVLve1or0NXcyyZi57AYLIiodkZmna77APRJLNrf8SPARLF/qsck 5OgcqO1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scOcM-0000000BBEv-14MK; Fri, 09 Aug 2024 12:21:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scOY8-0000000BALH-29ly for linux-arm-kernel@bombadil.infradead.org; Fri, 09 Aug 2024 12:16:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=TuWnCcRCiDamAtNdk0SXiVJG3T2vClSNbqBuGGWkMvg=; b=ChZfO7mcAWH5A95YMRspvlm4HA eE1kLdugfVrUqZInRex9utVpItKBo77Yct2FNhV/DuDEP8cNuvX3VDfexHGk7R7v/iJO8ZAtbAj5m MdFpo6+wPlgbMIkGBB66xX4STE/VdFiKu6csGpKOC8N+W53QE6vu6FVdzv1g7eGgpGHjY65QKQ7jN qnzVUtAVPWEURzy94HtuYlL6zs1Me017qOAjUCEkmFPzeLND0eOCslpAdeuCJ+06qkkGd/QHhTox6 NFbNMrkoDeTIdOAq3uqq7OLttsZxmbthHZhOjtznaoI9/javZoFYqYkhTCsYkvdNaehS8kt9GGiP4 8P5MCuCA==; Received: from mgamail.intel.com ([192.198.163.17]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scOY4-000000070nk-1lrO for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 12:16:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723205808; x=1754741808; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=JP8VCxbNq7CBoSPJbq8/KBX4hfxCfPDfHkMylr4pZvU=; b=KlQ5GQz8Gyn3Ot6lI1QeDg8mAXCdZbVJqy9Mmw4qpuRhsU4otj6gRmOm JHKif7PSrdh74vr6Mr0KQqWTm2OnoyWS9ERUk/nICmZfMbZdkMYLy4q1N UY4txNMz+SEqF/2CDC0uLzNRdm7n2Fp7YaYx9ZTa7x/KKvice6+Gnot1c L0R6yoYsjdmxxe6nmnfq7t7jcjU2YMuUfZIvkRM+GoaCZa1bV3w3MBc7/ Kvk9cJAzvg7cHsZOwaQ7lHxH0xnL9fM1SMXvUA7sa6HsGwo4bqMnuWX7D hrL7PR3wVR+fnC5o+3dPqkUlE5oaYrLuWIxccO+6argn3I3UbvSjHRUI7 w==; X-CSE-ConnectionGUID: /Ylx4avCSAWASoiUepiFDg== X-CSE-MsgGUID: lx4AW8PdStOVItjY3hC5ow== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="21258693" X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="21258693" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 05:16:39 -0700 X-CSE-ConnectionGUID: yyOzs8w9SnW3By1qr2Qtlg== X-CSE-MsgGUID: E8YCVP4kRnmavvFOSJKCHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="88187943" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 05:16:37 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1scOXq-0000000DPav-1keS; Fri, 09 Aug 2024 15:16:34 +0300 Date: Fri, 9 Aug 2024 15:16:34 +0300 From: Andy Shevchenko To: Hanjun Guo Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Catalin Marinas Subject: Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array() Message-ID: References: <20240606165005.3031490-1-andriy.shevchenko@linux.intel.com> <3a1e0ffe-db11-d18f-db33-881df7d9b18d@huawei.com> <2edd3b72-24a4-8b19-8738-cc82dc4fae6c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2edd3b72-24a4-8b19-8738-cc82dc4fae6c@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_131649_486841_16FFAA8E X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote: > +Cc Catalin > > On 2024/6/11 18:42, Hanjun Guo wrote: > > On 2024/6/7 0:50, Andy Shevchenko wrote: > > > Let the kememdup_array() take care about multiplication and possible > > > overflows. > > > > > > Signed-off-by: Andy Shevchenko > > > --- > > >   drivers/acpi/arm64/iort.c | 2 +- > > >   1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > > index c0b1c2c19444..e596dff20f1e 100644 > > > --- a/drivers/acpi/arm64/iort.c > > > +++ b/drivers/acpi/arm64/iort.c > > > @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc( > > >           return NULL; > > >       /* Create a copy of SIDs array to associate with this rmr_data */ > > > -    sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL); > > > +    sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids), > > > GFP_KERNEL); > > >       if (!sids_copy) { > > >           kfree(rmr_data); > > >           return NULL; > > > > Looks good to me, > > > > Acked-by: Hanjun Guo > > Catalin, would you mind pick this up as well? Any news? I do not see this even in Linux Next... -- With Best Regards, Andy Shevchenko