* [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
@ 2024-06-06 16:50 Andy Shevchenko
2024-06-11 10:42 ` Hanjun Guo
2024-08-16 15:15 ` Will Deacon
0 siblings, 2 replies; 9+ messages in thread
From: Andy Shevchenko @ 2024-06-06 16:50 UTC (permalink / raw)
To: linux-acpi, linux-arm-kernel, linux-kernel
Cc: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, Rafael J. Wysocki,
Len Brown, Andy Shevchenko
Let the kememdup_array() take care about multiplication and possible
overflows.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/arm64/iort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index c0b1c2c19444..e596dff20f1e 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
return NULL;
/* Create a copy of SIDs array to associate with this rmr_data */
- sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
+ sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids), GFP_KERNEL);
if (!sids_copy) {
kfree(rmr_data);
return NULL;
--
2.43.0.rc1.1336.g36b5255a03ac
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-06-06 16:50 [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array() Andy Shevchenko
@ 2024-06-11 10:42 ` Hanjun Guo
2024-06-14 0:54 ` Hanjun Guo
2024-08-16 15:15 ` Will Deacon
1 sibling, 1 reply; 9+ messages in thread
From: Hanjun Guo @ 2024-06-11 10:42 UTC (permalink / raw)
To: Andy Shevchenko, linux-acpi, linux-arm-kernel, linux-kernel
Cc: Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki, Len Brown
On 2024/6/7 0:50, Andy Shevchenko wrote:
> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index c0b1c2c19444..e596dff20f1e 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
> return NULL;
>
> /* Create a copy of SIDs array to associate with this rmr_data */
> - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
> + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids), GFP_KERNEL);
> if (!sids_copy) {
> kfree(rmr_data);
> return NULL;
Looks good to me,
Acked-by: Hanjun Guo <guohanjun@huawei.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-06-11 10:42 ` Hanjun Guo
@ 2024-06-14 0:54 ` Hanjun Guo
2024-08-09 12:16 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Hanjun Guo @ 2024-06-14 0:54 UTC (permalink / raw)
To: Andy Shevchenko, linux-acpi, linux-arm-kernel, linux-kernel
Cc: Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki, Len Brown,
Catalin Marinas
+Cc Catalin
On 2024/6/11 18:42, Hanjun Guo wrote:
> On 2024/6/7 0:50, Andy Shevchenko wrote:
>> Let the kememdup_array() take care about multiplication and possible
>> overflows.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/acpi/arm64/iort.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index c0b1c2c19444..e596dff20f1e 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
>> return NULL;
>> /* Create a copy of SIDs array to associate with this rmr_data */
>> - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
>> + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
>> GFP_KERNEL);
>> if (!sids_copy) {
>> kfree(rmr_data);
>> return NULL;
>
> Looks good to me,
>
> Acked-by: Hanjun Guo <guohanjun@huawei.com>
Catalin, would you mind pick this up as well?
Thanks
Hanjun
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-06-14 0:54 ` Hanjun Guo
@ 2024-08-09 12:16 ` Andy Shevchenko
2024-08-09 12:52 ` Catalin Marinas
2024-08-09 12:52 ` Hanjun Guo
0 siblings, 2 replies; 9+ messages in thread
From: Andy Shevchenko @ 2024-08-09 12:16 UTC (permalink / raw)
To: Hanjun Guo
Cc: linux-acpi, linux-arm-kernel, linux-kernel, Lorenzo Pieralisi,
Sudeep Holla, Rafael J. Wysocki, Len Brown, Catalin Marinas
On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote:
> +Cc Catalin
>
> On 2024/6/11 18:42, Hanjun Guo wrote:
> > On 2024/6/7 0:50, Andy Shevchenko wrote:
> > > Let the kememdup_array() take care about multiplication and possible
> > > overflows.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/acpi/arm64/iort.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> > > index c0b1c2c19444..e596dff20f1e 100644
> > > --- a/drivers/acpi/arm64/iort.c
> > > +++ b/drivers/acpi/arm64/iort.c
> > > @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
> > > return NULL;
> > > /* Create a copy of SIDs array to associate with this rmr_data */
> > > - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
> > > + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
> > > GFP_KERNEL);
> > > if (!sids_copy) {
> > > kfree(rmr_data);
> > > return NULL;
> >
> > Looks good to me,
> >
> > Acked-by: Hanjun Guo <guohanjun@huawei.com>
>
> Catalin, would you mind pick this up as well?
Any news?
I do not see this even in Linux Next...
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-08-09 12:16 ` Andy Shevchenko
@ 2024-08-09 12:52 ` Catalin Marinas
2024-08-09 13:16 ` Hanjun Guo
2024-08-09 13:46 ` Andy Shevchenko
2024-08-09 12:52 ` Hanjun Guo
1 sibling, 2 replies; 9+ messages in thread
From: Catalin Marinas @ 2024-08-09 12:52 UTC (permalink / raw)
To: Andy Shevchenko, Will Deacon
Cc: Hanjun Guo, linux-acpi, linux-arm-kernel, linux-kernel,
Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki, Len Brown
On Fri, Aug 09, 2024 at 03:16:34PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote:
> > +Cc Catalin
> >
> > On 2024/6/11 18:42, Hanjun Guo wrote:
> > > On 2024/6/7 0:50, Andy Shevchenko wrote:
> > > > Let the kememdup_array() take care about multiplication and possible
> > > > overflows.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > drivers/acpi/arm64/iort.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> > > > index c0b1c2c19444..e596dff20f1e 100644
> > > > --- a/drivers/acpi/arm64/iort.c
> > > > +++ b/drivers/acpi/arm64/iort.c
> > > > @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
> > > > return NULL;
> > > > /* Create a copy of SIDs array to associate with this rmr_data */
> > > > - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
> > > > + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
> > > > GFP_KERNEL);
> > > > if (!sids_copy) {
> > > > kfree(rmr_data);
> > > > return NULL;
> > >
> > > Looks good to me,
> > >
> > > Acked-by: Hanjun Guo <guohanjun@huawei.com>
> >
> > Catalin, would you mind pick this up as well?
>
> Any news?
>
> I do not see this even in Linux Next...
Ah, sorry, I missed this. Since it doesn't look like a fix, I guess it's
fine to go in 6.12. Adding Will since he's handling the upcoming merging
window.
--
Catalin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-08-09 12:16 ` Andy Shevchenko
2024-08-09 12:52 ` Catalin Marinas
@ 2024-08-09 12:52 ` Hanjun Guo
1 sibling, 0 replies; 9+ messages in thread
From: Hanjun Guo @ 2024-08-09 12:52 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-acpi, linux-arm-kernel, linux-kernel, Lorenzo Pieralisi,
Sudeep Holla, Rafael J. Wysocki, Len Brown, Catalin Marinas
On 2024/8/9 20:16, Andy Shevchenko wrote:
> On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote:
>> +Cc Catalin
>>
>> On 2024/6/11 18:42, Hanjun Guo wrote:
>>> On 2024/6/7 0:50, Andy Shevchenko wrote:
>>>> Let the kememdup_array() take care about multiplication and possible
>>>> overflows.
>>>>
>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>> ---
>>>> drivers/acpi/arm64/iort.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>>>> index c0b1c2c19444..e596dff20f1e 100644
>>>> --- a/drivers/acpi/arm64/iort.c
>>>> +++ b/drivers/acpi/arm64/iort.c
>>>> @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
>>>> return NULL;
>>>> /* Create a copy of SIDs array to associate with this rmr_data */
>>>> - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
>>>> + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
>>>> GFP_KERNEL);
>>>> if (!sids_copy) {
>>>> kfree(rmr_data);
>>>> return NULL;
>>>
>>> Looks good to me,
>>>
>>> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>>
>> Catalin, would you mind pick this up as well?
>
> Any news?
>
> I do not see this even in Linux Next...
Sudeep, Lorenzo, would you mind giving it a go?
Thanks
Hanjun
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-08-09 12:52 ` Catalin Marinas
@ 2024-08-09 13:16 ` Hanjun Guo
2024-08-09 13:46 ` Andy Shevchenko
1 sibling, 0 replies; 9+ messages in thread
From: Hanjun Guo @ 2024-08-09 13:16 UTC (permalink / raw)
To: Catalin Marinas, Andy Shevchenko, Will Deacon
Cc: linux-acpi, linux-arm-kernel, linux-kernel, Lorenzo Pieralisi,
Sudeep Holla, Rafael J. Wysocki, Len Brown
On 2024/8/9 20:52, Catalin Marinas wrote:
> On Fri, Aug 09, 2024 at 03:16:34PM +0300, Andy Shevchenko wrote:
>> On Fri, Jun 14, 2024 at 08:54:39AM +0800, Hanjun Guo wrote:
>>> +Cc Catalin
>>>
>>> On 2024/6/11 18:42, Hanjun Guo wrote:
>>>> On 2024/6/7 0:50, Andy Shevchenko wrote:
>>>>> Let the kememdup_array() take care about multiplication and possible
>>>>> overflows.
>>>>>
>>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>>> ---
>>>>> drivers/acpi/arm64/iort.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>>>>> index c0b1c2c19444..e596dff20f1e 100644
>>>>> --- a/drivers/acpi/arm64/iort.c
>>>>> +++ b/drivers/acpi/arm64/iort.c
>>>>> @@ -822,7 +822,7 @@ static struct iommu_iort_rmr_data *iort_rmr_alloc(
>>>>> return NULL;
>>>>> /* Create a copy of SIDs array to associate with this rmr_data */
>>>>> - sids_copy = kmemdup(sids, num_sids * sizeof(*sids), GFP_KERNEL);
>>>>> + sids_copy = kmemdup_array(sids, num_sids, sizeof(*sids),
>>>>> GFP_KERNEL);
>>>>> if (!sids_copy) {
>>>>> kfree(rmr_data);
>>>>> return NULL;
>>>>
>>>> Looks good to me,
>>>>
>>>> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>>>
>>> Catalin, would you mind pick this up as well?
>>
>> Any news?
>>
>> I do not see this even in Linux Next...
>
> Ah, sorry, I missed this. Since it doesn't look like a fix, I guess it's
> fine to go in 6.12. Adding Will since he's handling the upcoming merging
> window.
Sorry, I sent another email almost at the same time, so missed this one.
Thanks
Hanjun
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-08-09 12:52 ` Catalin Marinas
2024-08-09 13:16 ` Hanjun Guo
@ 2024-08-09 13:46 ` Andy Shevchenko
1 sibling, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2024-08-09 13:46 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, Hanjun Guo, linux-acpi, linux-arm-kernel,
linux-kernel, Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki,
Len Brown
On Fri, Aug 09, 2024 at 01:52:48PM +0100, Catalin Marinas wrote:
> On Fri, Aug 09, 2024 at 03:16:34PM +0300, Andy Shevchenko wrote:
...
> Ah, sorry, I missed this. Since it doesn't look like a fix, I guess it's
> fine to go in 6.12.
No, it's definitely not a fix, it's a simple cleanup.
Hence v6.12 is quite okay, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array()
2024-06-06 16:50 [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array() Andy Shevchenko
2024-06-11 10:42 ` Hanjun Guo
@ 2024-08-16 15:15 ` Will Deacon
1 sibling, 0 replies; 9+ messages in thread
From: Will Deacon @ 2024-08-16 15:15 UTC (permalink / raw)
To: linux-acpi, linux-arm-kernel, linux-kernel, Andy Shevchenko
Cc: catalin.marinas, kernel-team, Will Deacon, Lorenzo Pieralisi,
Hanjun Guo, Sudeep Holla, Rafael J. Wysocki, Len Brown
On Thu, 06 Jun 2024 19:50:05 +0300, Andy Shevchenko wrote:
> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
>
Applied to arm64 (for-next/acpi), thanks!
[1/1] ACPI/IORT: Switch to use kmemdup_array()
https://git.kernel.org/arm64/c/9cd8062b38e6
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-08-16 15:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-06 16:50 [PATCH v1 1/1] ACPI/IORT: Switch to use kmemdup_array() Andy Shevchenko
2024-06-11 10:42 ` Hanjun Guo
2024-06-14 0:54 ` Hanjun Guo
2024-08-09 12:16 ` Andy Shevchenko
2024-08-09 12:52 ` Catalin Marinas
2024-08-09 13:16 ` Hanjun Guo
2024-08-09 13:46 ` Andy Shevchenko
2024-08-09 12:52 ` Hanjun Guo
2024-08-16 15:15 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox