From: Pranjal Shrivastava <praan@google.com>
To: Rob Clark <robdclark@gmail.com>
Cc: iommu@lists.linux.dev, Rob Clark <robdclark@chromium.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Georgi Djakov <quic_c_gdjako@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg
Date: Fri, 9 Aug 2024 20:10:06 +0000 [thread overview]
Message-ID: <ZrZ3nm2U5ox3a25O@google.com> (raw)
In-Reply-To: <20240809172716.10275-1-robdclark@gmail.com>
On Fri, Aug 09, 2024 at 10:27:14AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Previously this was dev_err_ratelimited() but it got changed to a
> ratelimited dev_dbg(). Change it back to dev_err().
>
> Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> We have crash telemetry watching for "Unhandled context fault", so we
> want to preserve this error msg.
>
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index 723273440c21..8321962b3714 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
> void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
> const struct arm_smmu_context_fault_info *cfi)
> {
> - dev_dbg(smmu->dev,
> + dev_err(smmu->dev,
> "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
> cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
>
> --
> 2.46.0
>
Yup, this should be changed back to dev_err.
Reviewed-by: Pranjal Shrivastava <praan@google.com>
next prev parent reply other threads:[~2024-08-09 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 17:27 [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Rob Clark
2024-08-09 20:10 ` Pranjal Shrivastava [this message]
2024-08-16 15:15 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrZ3nm2U5ox3a25O@google.com \
--to=praan@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).