From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A4CAC52D7C for ; Fri, 9 Aug 2024 20:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lgqce5rXdRX+XwqcnFHtjrWp8PyPm6TN4Q0gJ9i4UiU=; b=aUZVWg9Bb5GYedhzpYLOfNXZci 2fhRplOXr+OACTV1Ys+gATg5xTddTzHgAeNJ4th6WM4w7P3V/6dAorjgNVeqjYOmeXuAWdPCQIEWn HZlGaLGOmVPD6qYb5SENelt3fZHD1tdGvrugkCANg41dAZjJl/MR1MtqbkNV4mv4ychIbmHoEwKfI caFTIcSDV4UC1yelTRVsN2R78x2pMNNa1toDLoECmjs0g/qz3sskGguwOvv+vh4xOftTMea2CUJTd v7od/1jvih48nNtaYDMZgSU+octRhyU6tUFNKiW7P7Ke0HVJiwQ5n5ByUlN3DvrCXnBhF51rSkTFz cJbZIVmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scVws-0000000CT1N-30iM; Fri, 09 Aug 2024 20:10:54 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scVwI-0000000CSsw-1AOT for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 20:10:19 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1fd657c9199so5215ad.1 for ; Fri, 09 Aug 2024 13:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723234216; x=1723839016; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lgqce5rXdRX+XwqcnFHtjrWp8PyPm6TN4Q0gJ9i4UiU=; b=TwIV12PrA3vWQ882wYva97RKLeukPvemmVxX+1t/729NIjXB9FtW6gjN4S7/Fq6Hg2 0U2LvCkt8i8llW+dJGKqVaDnLrPLDBSwJoeJrr00Fs+1Oh3CXzo+7EP1nmgzmciDlOZM oyiVRLQFOnKWNl30OXxBbECEAatQPrTR1gbq16CWGYCaukkVlJH/AJeD8g7IjB+OmcII safGjC3mdvgnpEyHsCOMPsLJMsPQHnDGxIyepSmOkP3g/fXJPERvB6LuDFJcFAhFL93t BLPCSrvbRpYExPf5uzeppEQ2XfGpOUN++CFWp0I3t00hdyKzIgvu+omYQSruSRmhrTOs XdSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723234216; x=1723839016; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lgqce5rXdRX+XwqcnFHtjrWp8PyPm6TN4Q0gJ9i4UiU=; b=Nq4bWNrHD7mXAjUUuLOipmkPtOP0CHKZGWzSLXigVYcwowLAw5GmA00O1dIDUuKsvL CJqyHiKxVuwvTXY2K1atG7dZqGrznkRG0RpRdyN5JrbDYrT7NnDU7h49WgEjZDwsBODX hxPDtg8H6PDhTbLRYgAGMKcyUBlLwWLfv0+WNeInP3FoEcPfw9lF7TGc2RF82XrsnUG5 Vl8sXJftGvs7ndA5y6WktecHCOgiCwINwkOaP7pojMrvy1W7P3ikIIuKjlAhsM6SRqBv L3LZ+0+EHmxVPlQMhs339kP6GJYLB6DC2hUSNHmdZQuhAVPVcnW7rL0OufpM/s7ZaHF6 M08A== X-Forwarded-Encrypted: i=1; AJvYcCVgey/muYSCwAReLaPR2vnD0Tk8sxJA40FZR6rhtfGvtO2rKN+PF5q0kDWLopZ/tgegM74Bdpazp4SVjSSKPT+G5VfFpwOhtZRWpAjna3UW+5AU20E= X-Gm-Message-State: AOJu0YxYM+Q70erfqgkrxdXfB7nhfxSui6zRlb7pjhJe4QTQjq0RqGt7 bj54jLrp/itlenouRBKAax1SzxjqBTQjcRHPtZg1nTUDc36JotAosUrd0wasqw== X-Google-Smtp-Source: AGHT+IGCwF0wDx64AEbXcI1PmYNKlXMXiszjM75RvAm9xC3BTuLx9Ns1kMzSlCVJ3QIjU1KiQ9CWrA== X-Received: by 2002:a17:902:c403:b0:1fc:7357:9076 with SMTP id d9443c01a7336-200bbb3b48fmr557185ad.6.1723234216116; Fri, 09 Aug 2024 13:10:16 -0700 (PDT) Received: from google.com (255.248.124.34.bc.googleusercontent.com. [34.124.248.255]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e5ab7c27sm134892b3a.205.2024.08.09.13.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 13:10:15 -0700 (PDT) Date: Fri, 9 Aug 2024 20:10:06 +0000 From: Pranjal Shrivastava To: Rob Clark Cc: iommu@lists.linux.dev, Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Krzysztof Kozlowski , Georgi Djakov , Dmitry Baryshkov , "moderated list:ARM SMMU DRIVERS" , open list Subject: Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Message-ID: References: <20240809172716.10275-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809172716.10275-1-robdclark@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_131018_340591_71014F11 X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 09, 2024 at 10:27:14AM -0700, Rob Clark wrote: > From: Rob Clark > > Previously this was dev_err_ratelimited() but it got changed to a > ratelimited dev_dbg(). Change it back to dev_err(). > > Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs") > Signed-off-by: Rob Clark > --- > We have crash telemetry watching for "Unhandled context fault", so we > want to preserve this error msg. > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > index 723273440c21..8321962b3714 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > @@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx, > void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx, > const struct arm_smmu_context_fault_info *cfi) > { > - dev_dbg(smmu->dev, > + dev_err(smmu->dev, > "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n", > cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx); > > -- > 2.46.0 > Yup, this should be changed back to dev_err. Reviewed-by: Pranjal Shrivastava