* [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg
@ 2024-08-09 17:27 Rob Clark
2024-08-09 20:10 ` Pranjal Shrivastava
2024-08-16 15:15 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2024-08-09 17:27 UTC (permalink / raw)
To: iommu
Cc: Rob Clark, Will Deacon, Robin Murphy, Joerg Roedel,
Jason Gunthorpe, Krzysztof Kozlowski, Georgi Djakov,
Dmitry Baryshkov, Pranjal Shrivastava,
moderated list:ARM SMMU DRIVERS, open list
From: Rob Clark <robdclark@chromium.org>
Previously this was dev_err_ratelimited() but it got changed to a
ratelimited dev_dbg(). Change it back to dev_err().
Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
We have crash telemetry watching for "Unhandled context fault", so we
want to preserve this error msg.
drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
index 723273440c21..8321962b3714 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
@@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
const struct arm_smmu_context_fault_info *cfi)
{
- dev_dbg(smmu->dev,
+ dev_err(smmu->dev,
"Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg
2024-08-09 17:27 [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Rob Clark
@ 2024-08-09 20:10 ` Pranjal Shrivastava
2024-08-16 15:15 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Pranjal Shrivastava @ 2024-08-09 20:10 UTC (permalink / raw)
To: Rob Clark
Cc: iommu, Rob Clark, Will Deacon, Robin Murphy, Joerg Roedel,
Jason Gunthorpe, Krzysztof Kozlowski, Georgi Djakov,
Dmitry Baryshkov, moderated list:ARM SMMU DRIVERS, open list
On Fri, Aug 09, 2024 at 10:27:14AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Previously this was dev_err_ratelimited() but it got changed to a
> ratelimited dev_dbg(). Change it back to dev_err().
>
> Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> We have crash telemetry watching for "Unhandled context fault", so we
> want to preserve this error msg.
>
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index 723273440c21..8321962b3714 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
> void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
> const struct arm_smmu_context_fault_info *cfi)
> {
> - dev_dbg(smmu->dev,
> + dev_err(smmu->dev,
> "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
> cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
>
> --
> 2.46.0
>
Yup, this should be changed back to dev_err.
Reviewed-by: Pranjal Shrivastava <praan@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg
2024-08-09 17:27 [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Rob Clark
2024-08-09 20:10 ` Pranjal Shrivastava
@ 2024-08-16 15:15 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2024-08-16 15:15 UTC (permalink / raw)
To: iommu, Rob Clark
Cc: catalin.marinas, kernel-team, Will Deacon, Rob Clark,
Robin Murphy, Joerg Roedel, Jason Gunthorpe, Krzysztof Kozlowski,
Georgi Djakov, Dmitry Baryshkov, Pranjal Shrivastava,
linux-arm-kernel, linux-kernel
On Fri, 09 Aug 2024 10:27:14 -0700, Rob Clark wrote:
> Previously this was dev_err_ratelimited() but it got changed to a
> ratelimited dev_dbg(). Change it back to dev_err().
>
>
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu: Un-demote unhandled-fault msg
https://git.kernel.org/will/c/98db56e49008
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-16 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 17:27 [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg Rob Clark
2024-08-09 20:10 ` Pranjal Shrivastava
2024-08-16 15:15 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).