From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32F4FC3DA4A for ; Sat, 10 Aug 2024 09:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PHUqDeJUrmJPSZEaOP5lP78U85fbWhLAIns/TRwyjbI=; b=gWYfSqVwLAiqAAUBRbRp9o2AtW HL7zajSxcLBxjoRnbgbMPvlOvK1Vfu46Gf7X3BnlWGJ7H1k+0eosJs3wq47jdZ7NyqYGfyIxxkhPa 2ghjNZhZbhXCor7m2YxNq30uZXAdwd/IfrXn+STyBtanFDdzxd5uINN0y1ltRy9bVWx1wZBQPXy2k G3j/juiPuBdsDGnUYYKdOvZtoYldAanbsOkxplERkrSOP9gbTttC1cZHSeVf6fJwa891R1lLdV7He xOxeCBXvVn4ZyfATiyMadbkeZtWSsWHe2gwJ7JDa+8nY3vUKuj9V+6dElKwqZHo8dTbAtgXp6BKTl GF9wqU9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sciB0-0000000DoYb-3ZmU; Sat, 10 Aug 2024 09:14:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sci8H-0000000DnGY-257b for linux-arm-kernel@lists.infradead.org; Sat, 10 Aug 2024 09:11:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B8FB76092E; Sat, 10 Aug 2024 09:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4660EC32781; Sat, 10 Aug 2024 09:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723281088; bh=AoiaDiMVpIuVwraGfhlzk6sMJ54zKrVKt3c+uuBiEhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YQ00lh7+ONuVpLE68R0g/VlrsLTVqZ54r46Te9kxxtGcoU4SbvAyO0zhaqwUQi3/d YIeA9FH4dd/OgvzWBDPRAh10MgfKZKCRSLcPwTch5ByN+NCSa60CybfFxLbJ5phZQQ tNmjkuJKD5KPVNDeIpd8ZtVoGrB5esDuioDnBx9xYbWT0enR2zU3wuUCNvhYDaM/br YCx7k4fofsqcCKOuYB+YzLKE6cwWYAIyMwo93BWzqw61ZDMowiLinvzPQAXcRuY2wa 25HPQLbt5193wjTufIDXHmMfDWvI0hlH90y/cFuwRMt2jTByoTgiR80x5kdXM0NRRl eYa/Du1gQ+ERQ== Date: Sat, 10 Aug 2024 05:11:26 -0400 From: Sasha Levin To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, James Morse , Gavin Shan , Miguel Luis , Russell King , Jonathan Cameron , Catalin Marinas , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 6.10 14/16] irqchip/gic-v3: Don't return errors from gic_acpi_match_gicc() Message-ID: References: <20240728004739.1698541-1-sashal@kernel.org> <20240728004739.1698541-14-sashal@kernel.org> <87zfq150r6.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87zfq150r6.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240810_021129_615147_A1C72EB7 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 28, 2024 at 10:22:53AM +0100, Marc Zyngier wrote: >On Sun, 28 Jul 2024 01:47:31 +0100, >Sasha Levin wrote: >> >> From: James Morse >> >> [ Upstream commit fa2dabe57220e6af78ed7a2f7016bf250a618204 ] >> >> gic_acpi_match_gicc() is only called via gic_acpi_count_gicr_regions(). >> It should only count the number of enabled redistributors, but it >> also tries to sanity check the GICC entry, currently returning an >> error if the Enabled bit is set, but the gicr_base_address is zero. >> >> Adding support for the online-capable bit to the sanity check will >> complicate it, for no benefit. The existing check implicitly depends on >> gic_acpi_count_gicr_regions() previous failing to find any GICR regions >> (as it is valid to have gicr_base_address of zero if the redistributors >> are described via a GICR entry). >> >> Instead of complicating the check, remove it. Failures that happen at >> this point cause the irqchip not to register, meaning no irqs can be >> requested. The kernel grinds to a panic() pretty quickly. >> >> Without the check, MADT tables that exhibit this problem are still >> caught by gic_populate_rdist(), which helpfully also prints what went >> wrong: >> | CPU4: mpidr 100 has no re-distributor! >> >> Signed-off-by: James Morse >> Reviewed-by: Gavin Shan >> Tested-by: Miguel Luis >> Signed-off-by: Russell King (Oracle) >> Reviewed-by: Jonathan Cameron >> Signed-off-by: Jonathan Cameron >> Reviewed-by: Marc Zyngier >> Link: https://lore.kernel.org/r/20240529133446.28446-14-Jonathan.Cameron@huawei.com >> Signed-off-by: Catalin Marinas >> Signed-off-by: Sasha Levin > >Please drop this. It has no purpose being backported to stable. Ack, thanks! -- Thanks, Sasha