From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5926C3DA4A for ; Sat, 10 Aug 2024 17:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SfUAVnVhPMgQyDWRqBIv6D17vG3SHZ4cQln5xD8EUcg=; b=oYoETiNyOfmkVFzZjMPYEYibIS GbNwP3E8aDzD8oHgipNYqO+YcQnXUqO5p+pQ3NafZerOkRX4Gq+8csEQkY6vdqFnX0uX9IO3gi5dK U7+eTXdpLQNED3mTikvB3ihpJkF5uYsJ3Y21UaRUNXZgQt4HsK4CEbuNnsou+T2FCKNY7WGLnb9Gy 2QCEL+u8ZUBkrtpqYRjJmONfQ3ou7RSQ/IyzvKOUtLUsBipnxW3Snd7VcbVVKX8cCXL5GqCVY9VIY Ol3Y3AhXvT14qINP+z1mUm4bw9PrsrVukSHIg/69U5BuY/cC4x4lyDlVIBwEGf8CHiC9lYl5EdW+k wD/XKjjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scpkc-0000000ENax-3nFL; Sat, 10 Aug 2024 17:19:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scpk3-0000000ENZL-0wnr for linux-arm-kernel@lists.infradead.org; Sat, 10 Aug 2024 17:19:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 14B7D60C25; Sat, 10 Aug 2024 17:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B679DC32781; Sat, 10 Aug 2024 17:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723310337; bh=ag/bsceGPVeuQ7s4EtclHx9Ksxdoj0dbuKHPiUMwhbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WxKSp7ono43bxCxg30AERUxf9vZQGocrzIzIkShblckbic6/4wC9exVhA0CD1ahZ5 /TbOYsD3qiiAFw2XuvX0wNE9iMYkCAoOGYZDvVTy/LyFSIVN+yFjFN2c9zdTKkRyjk 6Z9TMROvc2uu2H15FKoXdWPTlHkH5t1vruPWhnL0yww0puM2S3ss3w0/eSwmH+OobF UTz3SEEzRUUBwFMtXpW8MZAeK6//7kZmLoHr+18f7/AsMxVlH0SAJw9iy5id2Wb/fB iMb4z8MGK+2bIrnWYUVSqjWFhafZr1+lwShd+FSIENwUWvij+pw5xUvgFiGlBD74yu ExA624YL+6i7A== Date: Sat, 10 Aug 2024 19:18:52 +0200 From: Lorenzo Bianconi To: Krzysztof Kozlowski Cc: linux-pwm@vger.kernel.org, ukleinek@kernel.org, lorenzo.bianconi83@gmail.com, krzk+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, conor+dt@kernel.org, ansuelsmth@gmail.com Subject: Re: [PATCH 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM Message-ID: References: <6a95b1d7fb90045a51a0cf51b9fafff26790904b.1723264979.git.lorenzo@kernel.org> <4c63b64b-b6f2-4e72-95c5-5555681f6d10@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VU60BAksC1EKInjK" Content-Disposition: inline In-Reply-To: <4c63b64b-b6f2-4e72-95c5-5555681f6d10@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240810_101859_354164_02360FF4 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --VU60BAksC1EKInjK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Aug 10, Krzysztof Kozlowski wrote: > On 10/08/2024 06:48, Lorenzo Bianconi wrote: > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pwm@1fbf0224 { > > + compatible =3D "airoha,en7581-pwm"; > > + reg =3D <0x1fbf0224 0x10>, > > + <0x1fbf0238 0x28>, > > + <0x1fbf0298 0x8>; >=20 > These look almost continuous, so I wonder what's in between? E.g. > between 0x1fbf0224+10=3D0x1fbf0234 and 0x1fbf0238? register 0x1fbf0234 will be used by pinctrl driver (I will post it soon) for pwm muxing. The issue here is clock, pinctrl, gpio, pwm and (future) serdes registers are all interleaved in a non-regular fashion in the following IO space: - <0x1fa20000 - 0x1fa20384>=20 - <0x1fb00000 - 0x1fb0096c> - <0x1fbf0200 - 0x1fbf02bc> So in order to avoid conflicts we need a sparse mapping. Regards, Lorenzo >=20 > Rest looks good. >=20 > Best regards, > Krzysztof >=20 --VU60BAksC1EKInjK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZreg+QAKCRA6cBh0uS2t rLA0AP9km4sKCFpLwY5e5Xri0IeNQy7pqAcJXJZmICwTkJHA6AEApRkR1ZsyHcla jesK3yuVFEn7YeMIs816PW1aGwOL6Qk= =gbix -----END PGP SIGNATURE----- --VU60BAksC1EKInjK--