linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card
@ 2024-07-16  8:51 Andrej Picej
  2024-07-26 12:31 ` [Upstream] " Benjamin Hahn
  2024-08-12  9:21 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Andrej Picej @ 2024-07-16  8:51 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream

Micro SD cards can't be physically write-protected like full-sized
cards. Disable this feature in device-tree to get rid of the kernel
warning:

"host does not support reading read-only switch, assuming write-enable"

Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
index 00a240484c25..791909dca6e1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
@@ -267,6 +267,7 @@ &usdhc2 {
 	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_pins>;
 	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_pins>;
 	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+	disable-wp;
 	vmmc-supply = <&reg_usdhc2_vmmc>;
 	bus-width = <4>;
 	status = "okay";
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Upstream] [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card
  2024-07-16  8:51 [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card Andrej Picej
@ 2024-07-26 12:31 ` Benjamin Hahn
  2024-08-12  9:21 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Hahn @ 2024-07-26 12:31 UTC (permalink / raw)
  To: Andrej Picej, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com
  Cc: devicetree@vger.kernel.org, PHYTEC Upstream,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev

On 16.07.24 10:51, Andrej Picej wrote:
> Micro SD cards can't be physically write-protected like full-sized
> cards. Disable this feature in device-tree to get rid of the kernel
> warning:
>
> "host does not support reading read-only switch, assuming write-enable"
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Benjamin Hahn <B.Hahn@phytec.de>
> ---
>   arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> index 00a240484c25..791909dca6e1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> @@ -267,6 +267,7 @@ &usdhc2 {
>   	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_pins>;
>   	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_pins>;
>   	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> +	disable-wp;
>   	vmmc-supply = <&reg_usdhc2_vmmc>;
>   	bus-width = <4>;
>   	status = "okay";



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card
  2024-07-16  8:51 [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card Andrej Picej
  2024-07-26 12:31 ` [Upstream] " Benjamin Hahn
@ 2024-08-12  9:21 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-08-12  9:21 UTC (permalink / raw)
  To: Andrej Picej
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	devicetree, imx, linux-arm-kernel, linux-kernel, upstream

On Tue, Jul 16, 2024 at 10:51:14AM +0200, Andrej Picej wrote:
> Micro SD cards can't be physically write-protected like full-sized
> cards. Disable this feature in device-tree to get rid of the kernel
> warning:
> 
> "host does not support reading read-only switch, assuming write-enable"
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Applied, thanks!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-12  9:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16  8:51 [PATCH] arm64: dts: imx8mp-phyboard-pollux: Disable write-protect on SD card Andrej Picej
2024-07-26 12:31 ` [Upstream] " Benjamin Hahn
2024-08-12  9:21 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).