From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6FCFC52D7F for ; Mon, 12 Aug 2024 13:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lmYajX4gMaVGigJxbQG+9M3259675dZnYWJeb/SxvFA=; b=4X6Z6KVNV0Tt7XOxB1G4mQYpbK qaJxGlzQFpt5wB2Klzw0vg8hKqaym4FL9El5ZmjfTxhK31BURODvMzQvPrYTCKwFjBV0sq54u+6sM 9Spy8MDYYVx9ULTdUrIcjKW0yh9k+nV5aJfMjJ5BLuA1s/EZZJpJ8MIq+y02kpEiR95+4xTXY2VXw HE2IzAlPe/D8kEyaixzAYpMGE0Go668YeC7kMRehcqWeuF2L+DmWsO0MRAsewOfy/WFJc/MpjdLbu g7VVEjLdXvJnosIN9t/QfI4eCpouqsVPMsI3HK1ZbU+bNkaNEpGQJGeYG5Ei3HN+4i8DRBX0ncFf8 fNGEY4xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdV45-00000000PQu-1dI0; Mon, 12 Aug 2024 13:26:25 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdV3S-00000000PEz-3uGH for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 13:25:48 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-200aa53d6d2so325865ad.0 for ; Mon, 12 Aug 2024 06:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723469145; x=1724073945; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lmYajX4gMaVGigJxbQG+9M3259675dZnYWJeb/SxvFA=; b=ZwJgkA/cKQaYykSsNfW7jmQ+rvfAIaAXMPXT9BLNe3SlXm/0nTWvwZa7Id89VdNOaY iZsc7vQ/LOeNu3FJCY/DxuR7NMg/rZH0ITUHVH3/3Zzaadb3c5e8IcLpxcNyF80ObejE FGZWgQR0BK/lDhbTbZhnQOtHBCEX15ZiWjA/fYeTt9c5YBltR1ZvNwnIudEiYQLSozlx jILtXLiKtMMfdeC6ZqyPM9V+8YprL5daIKhSnTa/r4c0MWLYh6n7a+wGFw6Iw6QwaGkJ SJqpj6Ykqj2xTRceJjStCf0cTlvo26kTtrt1t1ETabrdCgxuJY5e9Bsr7A179jrAH26j Y+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723469145; x=1724073945; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lmYajX4gMaVGigJxbQG+9M3259675dZnYWJeb/SxvFA=; b=XGaVm9Kf8buz/85wGFcQ3DYqSOK4asR915+Wbs8FlXM9r4NzDVccvMT9oqkez45aG6 CufSBc6nN1No8jiuebbPffaqKwtIDW7wxGVQsEF+Z8vSz8f0duk8sNoZk6gKaZkkEyOH /i+wXco1oK/tpkBM1HSCeqboqOd90nWr/x+MsgbQZmoSHS5LDvwfXyTTv6Mebj8pkcvn lFO1Fa472B8jDKJuwIyKleE7IzavYSEjyA/IZLkC5GrJ+yls7EYm6JIasAiIBZihDo3d /hRKjNT8JxfF6BY8LQX0GI/UIt2x7drZqRaWgrw6Pn1qc/IQxcpDAjSNTORLLg7NI3J5 ACUg== X-Forwarded-Encrypted: i=1; AJvYcCWEJJhoXOOVGBjzlJ4Yx/Y2uw3lXTgq9uUqaYgufijC77/zClAe7Cj/RjgnYQO5OpVpbl5aeot7aKekCnZXQMu9+m00ZvLGD6ivN7RKJvhsocJXGDg= X-Gm-Message-State: AOJu0YwNoxJDrO2rN0+AFvgVj2XnqKXUWtICQx0jNQq2xhiylbAq5HmX W2tadGHPJ5td0XUZAtwY7JR9BuRuuCl0iNKaI3Bw5OghMiosGCcFbgI5UBd9MYky0hT0AjAYJ/g 3+xqD X-Google-Smtp-Source: AGHT+IHb6qeSJStNs0pVR+CmYkttDl20c4Sd0X9v5RgYO5YZwdbSZX0vov7dB1RIgvFULpIown2sxA== X-Received: by 2002:a17:902:db04:b0:1fb:3e93:79cf with SMTP id d9443c01a7336-200bd27550bmr4027905ad.13.1723469145000; Mon, 12 Aug 2024 06:25:45 -0700 (PDT) Received: from google.com (202.141.197.35.bc.googleusercontent.com. [35.197.141.202]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e5a89e22sm4085935b3a.170.2024.08.12.06.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 06:25:44 -0700 (PDT) Date: Mon, 12 Aug 2024 13:25:36 +0000 From: Pranjal Shrivastava To: Zhenhua Huang Cc: robdclark@gmail.com, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_c_gdjako@quicinc.com, dmitry.baryshkov@linaro.org Subject: Re: [PATCH 1/1] iommu/arm-smmu-qcom: remove runtime pm enabling for TBU driver Message-ID: References: <1722335443-30080-1-git-send-email-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1722335443-30080-1-git-send-email-quic_zhenhuah@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_062546_990615_3F59B428 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 30, 2024 at 06:30:43PM +0800, Zhenhua Huang wrote: > TBU driver has no runtime pm support now, adding pm_runtime_enable() > seems to be useless. Remove it. > > Signed-off-by: Zhenhua Huang > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > index 36c6b36ad4ff..aff2fe1fda13 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > @@ -566,7 +566,6 @@ static struct acpi_platform_list qcom_acpi_platlist[] = { > > static int qcom_smmu_tbu_probe(struct platform_device *pdev) > { > - struct device *dev = &pdev->dev; > int ret; > > if (IS_ENABLED(CONFIG_ARM_SMMU_QCOM_DEBUG)) { > @@ -575,11 +574,6 @@ static int qcom_smmu_tbu_probe(struct platform_device *pdev) > return ret; > } > > - if (dev->pm_domain) { > - pm_runtime_set_active(dev); > - pm_runtime_enable(dev); I assumed that this was required to avoid the TBU from being powered down? If so, then I think we shall move it under the previous if condition, i.e. CONFIG_ARM_SMMU_QCOM_DEBUG? If not, we can remove it give that the TBU would be powered ON as needed > - } > - > return 0; > } > > -- > 2.7.4 > > Thanks, Pranjal