From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FD5DC3DA7F for ; Mon, 12 Aug 2024 19:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8R8Kqxp1SSqk9b+o/Zxa0CgzruYYbBKoQ4rOkBUSYKw=; b=e1rGfMYs1AZivmvqxw1qmjz75o xZXXqG19oGixBDbeB514KJ5AXocRRcEZoeAV9bCUJhC4wCIyatzhGcNRgzAw6tmTf/AhlrcpZ+dCo 9cbsBYqu5m8YPYDozlXJ0ACf8DUY16xP8TdS+xuvni4+o30bqjnfdl2vzZK7PoCFDrrAvDCayoIcK Jn+qaN8l80KBqGlgCZu8ojwt6nNmajEA2LtE3wRde0/LDz9YEww81cORLA5C5AYmanuBvxptxAEKm QN6tE81NNb3Zd7RDaaHepqgJ7OiB8h51oBKFof6OIElfRYX4p85nKf4ur0I1IRMAKCm53WT1zLPb7 8aYw8pIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdb8g-00000001Niq-23rm; Mon, 12 Aug 2024 19:55:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdb85-00000001NdM-2wii for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 19:54:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DBF1B60FB4; Mon, 12 Aug 2024 19:54:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96A8C32782; Mon, 12 Aug 2024 19:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723492496; bh=reJhsp5omuXIkWsSZ3Ffxm81fgceHgX1Zq7uRLpnYpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tdvy1WpI1h0G71UnEXCip6KinAyNU3eY/UIg2uLAWEvOQJGnmgEFwLAvyAhzg1nMA tBL8+Zaf7ULTAR7eNEC8n0WyRvS2qOxZv1ZxxgDZa+AbZVYrmvsDqqlmxcRhG4Ngm+ WERuvBYOgiuY9zPl43kvGoRUDNgfdIJrOnnEQSVlUgxEt8Pk4WsPuxvXRnPOmUvukj uED8q2loidgp04xsk1l2TlrcvLnnYQ8wejnKwpBdOF69jLOHqZKaDEcwQxwXA/BxUo /pax1lp3FlZJII/k2rP0zz2UhU4Cunw8M2rwCAipF0R3t0+qTYwet7KmYqFypJdK6I LrxY5l0sM4lVQ== Date: Mon, 12 Aug 2024 16:54:53 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Adrian Hunter , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 00/27] Constify tool pointers Message-ID: References: <20240718010023.1495687-1-irogers@google.com> <738b5c89-acb2-46a5-92a1-c36bd90abc30@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_125457_877903_BEB61588 X-CRM114-Status: GOOD ( 26.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2024 at 11:10:02AM -0700, Ian Rogers wrote: > On Mon, Aug 12, 2024 at 6:53 AM Arnaldo Carvalho de Melo > wrote: > > > > On Fri, Jul 19, 2024 at 09:26:57AM -0700, Ian Rogers wrote: > > > On Fri, Jul 19, 2024 at 1:51 AM Adrian Hunter wrote: > > > > > > > > On 18/07/24 03:59, Ian Rogers wrote: > > > > > struct perf_tool provides a set of function pointers that are called > > > > > through when processing perf data. To make filling the pointers less > > > > > cumbersome, if they are NULL perf_tools__fill_defaults will add > > > > > default do nothing implementations. > > > > > > > > > > This change refactors struct perf_tool to have an init function that > > > > > provides the default implementation. The special use of NULL and > > > > > perf_tools__fill_defaults are removed. As a consequence the tool > > > > > pointers can then all be made const, which better reflects the > > > > > behavior a particular perf command would expect of the tool and to > > > > > some extent can reduce the cognitive load on someone working on a > > > > > command. > > > > > > > > > > v6: Rebase adding Adrian's reviewed-by/tested-by and Leo's tested-by. > > > > > > > > The tags were really meant only for patch 1, the email that was replied to. > > > > > > > > But now for patches 2 and 3: > > > > > > > > Reviewed-by: Adrian Hunter > > > > Applied 1-3, 4 is not applying, I'll look at it later. > > I have a rebase and can resend. I haven't addressed Adrian's feedback Please resend then. - Arnaldo > as I prefer callers of the tool function pointers not to have to do > NULL tests, I'm trying to minimize spaghetti. Not sure if you're > applying the whole series here or just the beginning. > > Thanks, > Ian