* [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz
@ 2024-08-05 17:48 João Paulo Gonçalves
2024-08-08 2:59 ` Peng Fan
2024-08-13 3:25 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: João Paulo Gonçalves @ 2024-08-05 17:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Marcel Ziswiler, devicetree, imx, linux-arm-kernel, linux-kernel,
João Paulo Gonçalves
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
SDIO frequency was limited to workaround some instabilities, however it
turned out that the instability had nothing to do with the speed but was
because of an issue with the USDHC IP that was fixed in
commit 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD line
auto tuning for SDIO device").
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
index efcab00c0142..cae06cb67cd3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
@@ -75,7 +75,6 @@ bluetooth {
&usdhc1 {
bus-width = <4>;
keep-power-in-suspend;
- max-frequency = <100000000>;
non-removable;
pinctrl-names = "default", "state_100mhz", "state_200mhz";
pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_wifi_ctrl>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz
2024-08-05 17:48 [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz João Paulo Gonçalves
@ 2024-08-08 2:59 ` Peng Fan
2024-08-13 3:25 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2024-08-08 2:59 UTC (permalink / raw)
To: João Paulo Gonçalves, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: Marcel Ziswiler, devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, João Paulo Gonçalves
> Subject: [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi
> frequency to 100 mhz
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> SDIO frequency was limited to workaround some instabilities, however
> it turned out that the instability had nothing to do with the speed but
> was because of an issue with the USDHC IP that was fixed in commit
> 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD
> line auto tuning for SDIO device").
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> index efcab00c0142..cae06cb67cd3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> @@ -75,7 +75,6 @@ bluetooth {
> &usdhc1 {
> bus-width = <4>;
> keep-power-in-suspend;
> - max-frequency = <100000000>;
> non-removable;
> pinctrl-names = "default", "state_100mhz", "state_200mhz";
> pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_wifi_ctrl>;
> --
> 2.34.1
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz
2024-08-05 17:48 [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz João Paulo Gonçalves
2024-08-08 2:59 ` Peng Fan
@ 2024-08-13 3:25 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-08-13 3:25 UTC (permalink / raw)
To: João Paulo Gonçalves
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marcel Ziswiler, devicetree, imx, linux-arm-kernel, linux-kernel,
João Paulo Gonçalves
On Mon, Aug 05, 2024 at 02:48:14PM -0300, João Paulo Gonçalves wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> SDIO frequency was limited to workaround some instabilities, however it
> turned out that the instability had nothing to do with the speed but was
> because of an issue with the USDHC IP that was fixed in
> commit 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD line
> auto tuning for SDIO device").
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-13 3:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-05 17:48 [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz João Paulo Gonçalves
2024-08-08 2:59 ` Peng Fan
2024-08-13 3:25 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).