[PATCH] arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries

[PATCH] arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

According to adi,adv7533.yaml, the order for the reg and reg-names entries
must be: main, edid, cec, and packet.

Fix it accordingly to remove the following dt-schema warnings:

hdmi@3d: reg-names:1: 'edid' was expected
hdmi@3d: reg-names:2: 'cec' was expected

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts | 4 ++--
 arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
index 905c98cb080d..97ff1ddd6318 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d {
 		compatible = "adi,adv7535";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hdmi_bridge>;
-		reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
-		reg-names = "main", "cec", "edid", "packet";
+		reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>;
+		reg-names = "main", "edid", "cec", "packet";
 		adi,dsi-lanes = <4>;
 		avdd-supply = <&reg_hdmi>;
 		a2vdd-supply = <&reg_hdmi>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
index bbd80896db96..1df5ceb11387 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d {
 		compatible = "adi,adv7535";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hdmi_bridge>;
-		reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
-		reg-names = "main", "cec", "edid", "packet";
+		reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>;
+		reg-names = "main", "edid", "cec", "packet";
 		adi,dsi-lanes = <4>;
 		avdd-supply = <&reg_hdmi>;
 		a2vdd-supply = <&reg_hdmi>;
-- 
2.34.1

Re: [PATCH] arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries

[Adam Ford]

On Thu, Aug 8, 2024 at 7:22 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> According to adi,adv7533.yaml, the order for the reg and reg-names entries
> must be: main, edid, cec, and packet.
>
> Fix it accordingly to remove the following dt-schema warnings:
>
> hdmi@3d: reg-names:1: 'edid' was expected
> hdmi@3d: reg-names:2: 'cec' was expected
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

I am traveling, but LGTM.

Reviewed-by:  Adam Ford <aford173@gmail.com>

If this needs a V2 for some reason, we could probably delete the
optional reg settings since I think these are using the defaults
anyway.  I don't have the datasheets in front of me nor the source
code, so I am not 100% sure.


adam

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts | 4 ++--
>  arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> index 905c98cb080d..97ff1ddd6318 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts
> @@ -62,8 +62,8 @@ adv_bridge: hdmi@3d {
>                 compatible = "adi,adv7535";
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pinctrl_hdmi_bridge>;
> -               reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
> -               reg-names = "main", "cec", "edid", "packet";
> +               reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>;
> +               reg-names = "main", "edid", "cec", "packet";
>                 adi,dsi-lanes = <4>;
>                 avdd-supply = <&reg_hdmi>;
>                 a2vdd-supply = <&reg_hdmi>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> index bbd80896db96..1df5ceb11387 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> @@ -62,8 +62,8 @@ adv_bridge: hdmi@3d {
>                 compatible = "adi,adv7535";
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pinctrl_hdmi_bridge>;
> -               reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
> -               reg-names = "main", "cec", "edid", "packet";
> +               reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>;
> +               reg-names = "main", "edid", "cec", "packet";
>                 adi,dsi-lanes = <4>;
>                 avdd-supply = <&reg_hdmi>;
>                 a2vdd-supply = <&reg_hdmi>;
> --
> 2.34.1
>

Re: [PATCH] arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries

[Shawn Guo]

On Thu, Aug 08, 2024 at 09:22:07AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to adi,adv7533.yaml, the order for the reg and reg-names entries
> must be: main, edid, cec, and packet.
> 
> Fix it accordingly to remove the following dt-schema warnings:
> 
> hdmi@3d: reg-names:1: 'edid' was expected
> hdmi@3d: reg-names:2: 'cec' was expected
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!