From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 911BDC52D7B for ; Tue, 13 Aug 2024 15:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oDUamF5J+1XHT0J4TpZt9iUNA0VNngLpHfz1pQpsQFM=; b=Oz8aEvvNrmdQyC9qG0Agd7e12E RGEj9CFaQNH6sGcNoBrtErCdnEWt9sPwNDP+MbYaZSlhmorbZhHiujtoPkRutZyVPQxgeGAUtYVbX IE8yS5GDOBOSkDhyMyZGK4ODJK3VquMa3q1VjtHfR/97WVSEDlTAvmYhm2DHnsPWN4Ws/s5F39upz M4/AuPloX5SsTRSOhgmrWky8/xmQ6IU/iIPKprkT0aMGYO4pX++REQoB/2O+dhoQR6ECDXPK8fGNS ZwvwGCsyCKOLR1zmBmrt/TZr9FNlgNX38pHba41cVRX0SZPLPD4kE50MoZaTBqU7hq/QQVuDPTkl2 vpfFjSLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdtOP-00000004CyO-47gd; Tue, 13 Aug 2024 15:25:01 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdtNn-00000004Cpv-0bO6 for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 15:24:24 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1fec34f94abso48007335ad.2 for ; Tue, 13 Aug 2024 08:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723562661; x=1724167461; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oDUamF5J+1XHT0J4TpZt9iUNA0VNngLpHfz1pQpsQFM=; b=rAoSQuw6m33PjV7QeE/zARg2hA5SqhX2ri2G1EDIk9C2dT9AcNARjT2WltZJccqW47 YVu3DgBlB2hu047YbzTN1nlkfRf7q/DcRlYfWDFhIIoMPGvzQ5T91l1zQ+85tg1f55Z7 nQB/kR5d9Lnj6+pottHuLomF1uIV65rklEXNtfRSF4gGqVsUm/BvU1qLjIGC/S3k3XG+ Sujr5KqiDdqYm44z1hvMNoxiS6ykS2ELKRIRWhKwqQejXu5TTVZB+8Ba3JnPphxUFzoE b4AZN2MQTjeOdh2YKD25veIlTYx2j8DYxt3/R/1ec/DykqllHwJPuxX7kpzqG4AeQh+q Xq5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723562661; x=1724167461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oDUamF5J+1XHT0J4TpZt9iUNA0VNngLpHfz1pQpsQFM=; b=v6lmYXk2PY2Jmn9NBVWY53KVtvB/qRMlpOM/14kzVAqUEJOkJO6xwvzfjkthymFvX3 bMkEYdQHoU4avz11k9ziEkS3GHqBImutOxIpzkJMKd79D+Op+W/2jLmJTLePNyUo6OVH fg9GjIovBpis2BqpD1/jrPiwEyGzIOssXTbmRU+uE1TR52vVOarellah4ZlhrOr2RI2u ZDv9mid4CAbndpx5RWpDfZQQEIEUzvnX+KOuYM0m3peXwPL7bh9kTStZKjvha6McBW66 mricHgidrqwV3IMULPLzF1DVKC3vRZLUFTgxpu2ThMGMiNYM1lgfx4e4VdQsmFdY43ep 5hJw== X-Forwarded-Encrypted: i=1; AJvYcCUwGP2tzYiorOwnIdbOmmbCpvznyckQcYHstrEeOED9YsFbhisdkQG/5QnnlDdfYf0u6mAD37e2ZTO8F6wwQ/GeiOEvj+hoaUzHRRqsbWFm9S3Zuxw= X-Gm-Message-State: AOJu0Ywn4+QPkvymVIRSYY75kMaMpmrKXe88zJhhUjaUMuoBy2Xv7Q34 wsXcbay2yRAAYB+7Roe/PuEc6WoqIxa/Q0NUd+dFYuwNlV0iHXaLttufyk8apOk= X-Google-Smtp-Source: AGHT+IHAxQb7Y6nkxCHFTuV+Yo1GDZU/jfnWNM34Zxjd3gA7zK88WOcad9xQ+GrBaPPGulVSnkAg5A== X-Received: by 2002:a17:902:c408:b0:1fa:8f64:8afd with SMTP id d9443c01a7336-201ca127b19mr53908795ad.11.1723562661371; Tue, 13 Aug 2024 08:24:21 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:d596:d55b:d99d:7ece]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1ab426sm14760975ad.157.2024.08.13.08.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 08:24:20 -0700 (PDT) Date: Tue, 13 Aug 2024 09:24:17 -0600 From: Mathieu Poirier To: "Rob Herring (Arm)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: Use of_property_present() Message-ID: References: <20240731191312.1710417-7-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731191312.1710417-7-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_082423_216130_527BD1A5 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 01:12:45PM -0600, Rob Herring (Arm) wrote: > Use of_property_present() to test for property presence rather than > of_(find|get)_property(). This is part of a larger effort to remove > callers of of_find_property() and similar functions. of_find_property() > leaks the DT struct property and data pointers which is a problem for > dynamically allocated nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) > --- > drivers/remoteproc/imx_dsp_rproc.c | 2 +- > drivers/remoteproc/imx_rproc.c | 2 +- > drivers/remoteproc/xlnx_r5_remoteproc.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > I have applied this patch. Thanks, Mathieu > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index 087506e21508..376187ad5754 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -509,7 +509,7 @@ static int imx_dsp_rproc_mbox_alloc(struct imx_dsp_rproc *priv) > struct mbox_client *cl; > int ret; > > - if (!of_get_property(dev->of_node, "mbox-names", NULL)) > + if (!of_property_present(dev->of_node, "mbox-names")) > return 0; > > cl = &priv->cl; > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 144c8e9a642e..8d7ecc809c67 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -807,7 +807,7 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > if (priv->tx_ch && priv->rx_ch) > return 0; > > - if (!of_get_property(dev->of_node, "mbox-names", NULL)) > + if (!of_property_present(dev->of_node, "mbox-names")) > return 0; > > cl = &priv->cl; > diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c > index 596f3ffb8935..2cea97c746fd 100644 > --- a/drivers/remoteproc/xlnx_r5_remoteproc.c > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > @@ -1059,7 +1059,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster, > r5_core = cluster->r5_cores[0]; > > /* Maintain backward compatibility for zynqmp by using hardcode TCM address. */ > - if (of_find_property(r5_core->np, "reg", NULL)) > + if (of_property_present(r5_core->np, "reg")) > ret = zynqmp_r5_get_tcm_node_from_dt(cluster); > else if (device_is_compatible(dev, "xlnx,zynqmp-r5fss")) > ret = zynqmp_r5_get_tcm_node(cluster); > @@ -1086,7 +1086,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster, > return ret; > } > > - if (of_find_property(dev_of_node(dev), "xlnx,tcm-mode", NULL) || > + if (of_property_present(dev_of_node(dev), "xlnx,tcm-mode") || > device_is_compatible(dev, "xlnx,zynqmp-r5fss")) { > ret = zynqmp_pm_set_tcm_config(r5_core->pm_domain_id, > tcm_mode); > @@ -1147,7 +1147,7 @@ static int zynqmp_r5_cluster_init(struct zynqmp_r5_cluster *cluster) > return -EINVAL; > } > > - if (of_find_property(dev_node, "xlnx,tcm-mode", NULL)) { > + if (of_property_present(dev_node, "xlnx,tcm-mode")) { > ret = of_property_read_u32(dev_node, "xlnx,tcm-mode", (u32 *)&tcm_mode); > if (ret) > return ret; > -- > 2.43.0 >