From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CDEEC3DA4A for ; Wed, 14 Aug 2024 15:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dbHCr0op/VQjYjFoPEioKUUX066cfRvLBk10sukcDPI=; b=fK5WXKncazxLqmGTJOM038v2OW XW/fvJ0t0k0zxuVQrXadTWq61jCzogGCnjB79ofDfAT7Xnrz/u3GiTuvvb8/fWg1sFkcOENlDxIFy P9xQKggncNbkaZDe6RTlIpdEyT/Qmc0Du0zXPm6i2QlM8lXxL9md/kCMzGjrj8gNYZQw1rN9671oH JOjNht8E2mpV9xUl5Cdf30Q17y2y+0T1NWBE5XyXXs0m7FUigbNmy/7+R3ZtmRwVSMfkaak9B4bqR cnMtcozfAaCRmaREcpmTHUXuqPPkrZbzL/9QIT6e7H0A4kFnsLQByzUfVcj8bzObZSc1DY8/OcVNq d54ILStw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seFUh-00000007PPZ-10q8; Wed, 14 Aug 2024 15:00:59 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seFU3-00000007PKM-0VLF for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 15:00:21 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-201daff5461so5317135ad.1 for ; Wed, 14 Aug 2024 08:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723647618; x=1724252418; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dbHCr0op/VQjYjFoPEioKUUX066cfRvLBk10sukcDPI=; b=Uoegsg5NAhUNSPGSODK5VnGgKWcgExe4uL+FNiiCVOS6PWb6Cd5vousMLwa10+KWmb 414+x4LVfHQMq8ACgrRbiUy63oT0RBzog1H96MffuYg01sPFiR+GHlOawaJxjJ8AS+Fa HVPywl9fVVTYRneUEMeJ5tlTsEEntGH+354yKzx+MOpZwvadlredGVN2C2dWkSaQr0gW XaLGXQMN4ohGk+zdl86gFBRGRQmj7nMFbUviiy+4Bu4SSaiTCd79FtuJ9uM/iAQYsa5j lI6HoxN/kRcFn63iMjTqtEY4KljW1YCDLTedz9qASP0jpnh7RiHLyN3e2QK4YMfGi86Q WDpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723647618; x=1724252418; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dbHCr0op/VQjYjFoPEioKUUX066cfRvLBk10sukcDPI=; b=TOr/v0t+JmL4y6qHQ1oXkihatZjorEoXpnWn6Tw8gvvCjUNlJV+hlKlgkXS/lgA8Rx EwKCvg9AUEdVULzyPlrxCDm3f0Oyl+Ql0QoI0uXStBDaNULp3knKLeQCDaHFeRymWIDG ouZY8OTUmSnVC6FEmHJ/UctWfdW2IVezP6fUUXwtOwrx8StUKG8XNCU8kMxZR0VGmpW7 Ya7wCwmgk0vp3pWjtnyzk2o4D3VjX1SB36MU4tvCNZLKphVzh/kWJ61TF3XGMa9p+3Sz td5PbwrvN49I3t1i/JgFcPj4ub95eFJnTWrZIgwyDJ+OpP9pfi7V1R8PNKIwsxCrxeVE rAyg== X-Forwarded-Encrypted: i=1; AJvYcCVJBIkD+IO4boT8SfSJJIq7LgXWOr2dV005N9AQuWlaxfE3YTd9AjxoCkPKjeRFtccGko0VsxSa91APPC1AZziL@lists.infradead.org X-Gm-Message-State: AOJu0YwT81eV6oBM7fJ8xItjse61sZss2Cfc2MVs0D2897kbdRul0IOz A/5ZiewkmwcgJbeaBdp98A4AYPjjda5TV6nASUng76KEbcukPwXx8fSilbir1IE= X-Google-Smtp-Source: AGHT+IFjkZdeCy3ttB1+N6PonqSVgzwx6/8vpCT2DGG5nYAfJZdLDmhJ/GAb7wGMXw/qa14hbL8Qqg== X-Received: by 2002:a17:902:ec90:b0:1fd:93d2:fba4 with SMTP id d9443c01a7336-201d64a5bd9mr37801815ad.48.1723647617183; Wed, 14 Aug 2024 08:00:17 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:58b0:43ab:ed9f:f0e3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1cbad6sm30554035ad.250.2024.08.14.08.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:00:16 -0700 (PDT) Date: Wed, 14 Aug 2024 09:00:13 -0600 From: Mathieu Poirier To: Peng Fan Cc: "Peng Fan (OSS)" , Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Daniel Baluta , Iuliana Prodan , Marek Vasut , "linux-remoteproc@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP Message-ID: References: <20240719-imx_rproc-v2-0-cd8549aa3f1f@nxp.com> <20240719-imx_rproc-v2-2-cd8549aa3f1f@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_080019_547779_274FA916 X-CRM114-Status: GOOD ( 54.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 02, 2024 at 04:59:45AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off > > for i.MX7ULP > > > > On Tue, Jul 30, 2024 at 08:06:22AM +0000, Peng Fan wrote: > > > > Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system > > off > > > > for i.MX7ULP > > > > > > > > On Fri, Jul 19, 2024 at 04:49:04PM +0800, Peng Fan (OSS) wrote: > > > > > From: Peng Fan > > > > > > > > > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The > > > > i.MX7ULP > > > > > Linux poweroff and restart rely on rpmsg driver to send a message > > > > > to > > > > > Cortex-M4 firmware. Then Cortex-A7 could poweroff or restart by > > > > > Cortex-M4 to configure the i.MX7ULP power controller properly. > > > > > > > > > > However the reboot and restart kernel common code use atomic > > > > notifier, > > > > > so with blocking tx mailbox will trigger kernel dump, because of > > > > > blocking mailbox will use wait_for_completion_timeout. In such > > > > > case, linux no need to wait for completion. > > > > > > > > > > Current patch is to use non-blocking tx mailbox channel when > > > > > system > > > > is > > > > > going to poweroff or restart. > > > > > > > > > > Signed-off-by: Peng Fan > > > > > --- > > > > > drivers/remoteproc/imx_rproc.c | 36 > > > > > ++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 36 insertions(+) > > > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > > > b/drivers/remoteproc/imx_rproc.c index > > > > 01cf1dfb2e87..e1abf110abc9 > > > > > 100644 > > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > > @@ -18,6 +18,7 @@ > > > > > #include #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -114,6 +115,7 @@ struct imx_rproc { > > > > > u32 entry; /* cpu start > > > > address */ > > > > > u32 core_index; > > > > > struct dev_pm_domain_list *pd_list; > > > > > + struct sys_off_data data; > > > > > > > > What is this for? I don't see it used in this patch. > > > > > > Oh, it was added when I was developing this feature, but in the end > > > this seems not needed. > > > > > > > > > > > > }; > > > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx93[] = { @@ > > > > > -1050,6 +1052,22 @@ static int imx_rproc_clk_enable(struct > > > > imx_rproc *priv) > > > > > return 0; > > > > > } > > > > > > > > > > +static int imx_rproc_sys_off_handler(struct sys_off_data *data) { > > > > > + struct rproc *rproc = data->cb_data; > > > > > + int ret; > > > > > + > > > > > + imx_rproc_free_mbox(rproc); > > > > > + > > > > > + ret = imx_rproc_xtr_mbox_init(rproc, false); > > > > > + if (ret) { > > > > > + dev_err(&rproc->dev, "Failed to request non-blocking > > > > mbox\n"); > > > > > + return NOTIFY_BAD; > > > > > + } > > > > > + > > > > > + return NOTIFY_DONE; > > > > > +} > > > > > + > > > > > static int imx_rproc_probe(struct platform_device *pdev) { > > > > > struct device *dev = &pdev->dev; @@ -1104,6 +1122,24 @@ > > static > > > > > int imx_rproc_probe(struct > > > > platform_device *pdev) > > > > > if (rproc->state != RPROC_DETACHED) > > > > > rproc->auto_boot = of_property_read_bool(np, > > > > "fsl,auto-boot"); > > > > > > > > > > + if (of_device_is_compatible(dev->of_node, "fsl,imx7ulp-cm4")) > > > > { > > > > > + ret = devm_register_sys_off_handler(dev, > > > > SYS_OFF_MODE_POWER_OFF_PREPARE, > > > > > + > > > > SYS_OFF_PRIO_DEFAULT, > > > > > + > > > > imx_rproc_sys_off_handler, rproc); > > > > > > > > Why does the mailbox needs to be set up again when the system is > > > > going down... > > > > > > As wrote in commit message: > > > "i.MX7ULP Linux poweroff and restart rely on rpmsg driver to send a > > > message," so need to set up mailbox in non-blocking way to send a > > > message to M4 side. > > > > > > > > > > > > + if (ret) { > > > > > + dev_err(dev, "register power off handler > > > > failure\n"); > > > > > + goto err_put_clk; > > > > > + } > > > > > + > > > > > + ret = devm_register_sys_off_handler(dev, > > > > SYS_OFF_MODE_RESTART_PREPARE, > > > > > + > > > > SYS_OFF_PRIO_DEFAULT, > > > > > + > > > > imx_rproc_sys_off_handler, rproc); > > > > > > > > ... and why does it need to be free'd when the system is going up? > > > > > > > > > Sorry, I not get your point. The free is in imx_rproc_sys_off_handler. > > > During system booting, the mailbox is not freed. > > > > Why is the same operation done at both startup and shutdown - that is > > not clear. > > The below commit shows request/free done in startup and shutdown. > Hope this explains what you ask. Unfortunately it doesn't. I just spent another hour trying to understand why the same operations are carried out for both shutdown and restart without success. I am out of time for this patch and have to move on to other patchset waiting to be reviewed. I suggest you ask Daniel to help clarify the changelog and comments in the code and submit another revision. Thanks, Mathieu > > commit 99b142cf7191b08adcd23f700ea0a3d7dffdd0c1 > Author: Peng Fan > Date: Fri Oct 21 12:15:25 2022 +0800 > > remoteproc: imx_rproc: Request mbox channel later > > It is possible that when remote processor crash, the communication > channel will be broken with garbage value in mailbox, such as > when Linux is issuing a message through mailbox, remote processor > crashes, we need free & rebuild the mailbox channels to make sure > no garbage value in mailbox channels. > > So move the request/free to start/stop for managing remote procesosr in > Linux, move to attach/detach for remote processor is out of control of > Linux. > > Previous, we just request mbox when attach for CM4 boot early before > Linux, but if mbox defer probe, remoteproc core will do resource cleanup > and corrupt resource table for later probe. > > So move request mbox ealier and still keep mbox request when attach > for self recovery case, but keep a check when request/free mbox. > > > > > I am currently away from the office, returning on August 12th. As such > > I will not be following up on this thread until then. > > sure. Thanks for letting me know. > > Thanks, > Peng. > > > > > > > > > Thanks, > > > Peng. > > > > > > > > > > > > + if (ret) { > > > > > + dev_err(dev, "register restart handler > > > > failure\n"); > > > > > + goto err_put_clk; > > > > > + } > > > > > + } > > > > > + > > > > > ret = rproc_add(rproc); > > > > > if (ret) { > > > > > dev_err(dev, "rproc_add failed\n"); > > > > > > > > > > -- > > > > > 2.37.1 > > > > > > > > > >