From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 612A9C52D7D for ; Wed, 14 Aug 2024 15:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=EPzjkUUFP8OjEO1Qk8lMBmVXt0 jlM0kEJnf9mqa28VdxwKkhilNRHWpL2FlC53CM+dfyvjBHzN6BoTUlIU6COVnZJXUqD8+i4AgvC8h yu/ejazLumrYfr2JRCPnmT+GYm84r0P9ubX6BQMaQlR5Np9/lY5SZzi4WI0dVVEsH8W0g539O9l1S aEneY2K0mmgAMYGJK9tB/GzbvGQviTvbuHmOqx/Pzx229jwO5j1Dei3MpP4r/LiXx74CXczLfuv6E etKI0YxKk/mfi4rQKpvfc0Mx8xX9q7/gdgJqWtG409fPmqpOg6KRFx1FPqSrezAK22khHjPo2f6/1 MK7cy+BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seG1x-00000007U8w-3ylZ; Wed, 14 Aug 2024 15:35:21 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seG1J-00000007U4x-3EGt for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 15:34:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723649680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=TS5uH/UVIhoo1xsqIjyOL1re6F/m4Da5tENHeu/ao6NsoX1NVgYvVklrnNkrJrA+Sh9cQQ hg0XhPjOwdvIVtIIhyYGkYcQAQrLHzUwP+fmTL9Ctc7s4Ntvp9DeGvRbwFQa6B69DfY/mX aaHoutqs5Gz924JaptRFV98x46DJ6sY= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-wqcK6ttoPQ2-lWr1q_1gMw-1; Wed, 14 Aug 2024 11:34:38 -0400 X-MC-Unique: wqcK6ttoPQ2-lWr1q_1gMw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b798c6b850so526416d6.0 for ; Wed, 14 Aug 2024 08:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723649678; x=1724254478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qd3L17EBGdmTNYKdWop5YhqCOAOZ9OC4Gj60Xq+yFMc=; b=nY5MAlqGMvRi+6RbGqX7klvPC4xfFLR+7od+O6M4vKDm/je7KGHUjg/IMZ+R+m2EBd fVCLNMl3HRDfbzUTY93hnugj9OirsANnBZkD3lnS6sUeLDDdjCMk+FrkKtbTDP6kMNVe yPwIg4SZXc9bY1XxO1pgUov4SqqGFTX10as2x7PhORLfbc9InTC973B6hMbbXPuk04XF A4/BUfMA9bLsNicIjQGWluGEegg0Wajvs/0RwwdtvoIys3v1ICps2WPjRgsha/AUL61U Ldac7XJd+DywstIIYFNa66ywx8ifo6pdX3OCCy88si6nybtlyjR8psfxy0NbX3Ph53Xq C3Lw== X-Forwarded-Encrypted: i=1; AJvYcCWa0kvQGN7HCl+jx51YjjiQq1MB9N+jcv5QtsA6mVrLZYcIOrrZa/buds8IAnN8xrPLjy+eOfvnvaoadWLtUuD/CopZfrt27/OmN/G3/1F5ri+WLNI= X-Gm-Message-State: AOJu0YwiKf857yJQc0wsk9mj2kfp4hMw0I2l6JAu38CNXgBSyStkU6v1 xY7TzQ3pOs4XD9YnJIUjaHe1R9F4G3JmKTQgCESBYmuAdq+CpbawjiAoBCLx6TzwjmbjGchfjL6 d/M0KTYZD6qGt/OKut7+AcjK6QNKkIm3zc7QIrM2lrFpF+zy26RcJouD0lcAvYtYMAiTmb+DZ X-Received: by 2002:ad4:5fc8:0:b0:6b9:5c25:c41e with SMTP id 6a1803df08f44-6bf5d1751admr20508856d6.3.1723649677982; Wed, 14 Aug 2024 08:34:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYJFXpQReML2ilodNHAhAn+3jsYwBR7OSYAxKuBRWJs3Oa71h5lhZj6qtdRaoMOC1R9brKfg== X-Received: by 2002:ad4:5fc8:0:b0:6b9:5c25:c41e with SMTP id 6a1803df08f44-6bf5d1751admr20508656d6.3.1723649677661; Wed, 14 Aug 2024 08:34:37 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82ca73c5sm44588296d6.69.2024.08.14.08.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 08:34:37 -0700 (PDT) Date: Wed, 14 Aug 2024 11:34:35 -0400 From: Peter Xu To: Jason Gunthorpe Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Subject: Re: [PATCH 05/19] mm/gup: Detect huge pfnmap entries in gup-fast Message-ID: References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-6-peterx@redhat.com> <67d734e4-86ea-462b-b389-6dc14c0b66f9@redhat.com> <20240814124228.GG2032816@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240814124228.GG2032816@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_083441_916029_4B32887E X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2024 at 09:42:28AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 09, 2024 at 12:59:40PM -0400, Peter Xu wrote: > > > In gup_fast_pte_range() we check after checking pte_devmap(). Do we want to > > > do it in a similar fashion here, or is there a reason to do it differently? > > > > IIUC they should behave the same, as the two should be mutual exclusive so > > far. E.g. see insert_pfn(): > > Yes, agree no functional difference, but David has a point to try to > keep the logic structurally the same in all pte/pmd/pud copies. OK, let me reorder them if that helps. > > > if (pfn_t_devmap(pfn)) > > entry = pte_mkdevmap(pfn_t_pte(pfn, prot)); > > else > > entry = pte_mkspecial(pfn_t_pte(pfn, prot)); > > > > It might change for sure if Alistair move on with the devmap work, though.. > > these two always are processed together now, so I hope that won't add much > > burden which series will land first, then we may need some care on merging > > them. I don't expect anything too tricky in merge if that was about > > removal of the devmap bits. > > Removing pte_mkdevmap can only make things simpler :) Yep. :) Thanks, -- Peter Xu