From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97241C5472F for ; Tue, 27 Aug 2024 14:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ewuwhIKt8cQXN53vReWDBXgiHXGDBL3c3E9cXVVmyDg=; b=1QNruWb43mVKRcYEm3wlvKiKfC TEjRELmkcdb9JomznPlJHHT5/oeWpiZ97vA53AyPe5a0wqb5gP58NHEwF6HvWu1R8Jjq49N5KB98w /O39hOPCGGjYkMEcfmgSExQ3V26JMQ/E4PzwEBjxQqlqBJZiniWg6ly4qRfka3tFoo44t/Dvvnob3 jLyUlYfoEP8+KzH0vtsIo9+IWcEdhy1D5az+VftMDNA0zLLjMB1+OItIb0l6aivP4evIzFo/oahT0 l8kqWASMdyIZzbtKVdLYq70JelS3u3p/SV7ed155xpEOe0ojTfwPToq4XzGb9WtkySZn+c+PIzCQT 4H+vV/ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixKR-0000000BgMK-3Ag0; Tue, 27 Aug 2024 14:37:51 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sixIa-0000000Bfyq-2URb for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 14:35:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724769356; x=1756305356; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RQV1oOHSHZntSMzGZOx612Dym+b0AKMnQySVvELMUmQ=; b=i9idrXZzluvIX4ayBkT+byyIFOabrrZEGN17UMI4AEswLEWv4dc55V1o bFwzZuxJYFiVFMH1+LwE/3T+dVFUethdQWsdi0OtkRZj9ho8D7RmAOAbf sMIoIi/NMElG2Y0HC3REmUpN6Z0MSi0hSWqyM1Yp+mutTRqZ47WuSWviP KgtT+wpO93i39zCj/W2gUogBRJdKwOm0sVOR/L9JDYZTazyECQX/w1yGa QAM2eLe4cpquCTrQ0XBFgDou6LKpBe6thG5w61RliDjUi5qLJCHtrm7pv iCZ88ODnKmKuFKDeKTWsD9xLrsujM8CVGL8fTNE4B/smfJO+mGtJwKPvf A==; X-CSE-ConnectionGUID: QSaPsHjuQwWMqwWIR729gw== X-CSE-MsgGUID: CehiXzE1TlSyQoguBU8q1g== X-IronPort-AV: E=McAfee;i="6700,10204,11177"; a="22777225" X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="22777225" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2024 07:35:54 -0700 X-CSE-ConnectionGUID: cYNwgXZWStCnmp9w4ttyGg== X-CSE-MsgGUID: b0azcHhARwOiQkQIorZPbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,180,1719903600"; d="scan'208";a="62929320" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2024 07:35:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sixIU-00000002IPm-1KJl; Tue, 27 Aug 2024 17:35:50 +0300 Date: Tue, 27 Aug 2024 17:35:50 +0300 From: Andy Shevchenko To: Chen-Yu Tsai Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] regulator: core: Fix regulator_is_supported_voltage() kerneldoc return value Message-ID: References: <20240827095550.675018-1-wenst@chromium.org> <20240827095550.675018-3-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827095550.675018-3-wenst@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_073556_695184_236E455B X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 05:55:42PM +0800, Chen-Yu Tsai wrote: > The kerneldoc for regulator_is_supported_voltage() states that the > return value is a boolean. That is not correct, as it could return an > error number if the check failed. I don't know what error number means. Is it positive? Negative? s/error number/negative error code/g (Here and everywhere else) > Fix the description by expanding it to cover the true, false and error true and false are not what is returned, right? > conditions. The description is also converted to a proper "Return" > section. ... > - * Returns a boolean. > + * Return: 1 if voltage range is support, 0 if not, or error number if supported > + * voltage can't be changed and voltage readback failed. -- With Best Regards, Andy Shevchenko