From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1E08C5479B for ; Wed, 28 Aug 2024 09:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zyVDf37sbzdokfzliFzopOO1woDs4l0bzvKjeAxUDRs=; b=bFxKsXQaDOjxPBjxsyLaNqKnmP KqWjv3QhHwvyahXCzhhbaiJN1NflY03qx5Pcj/9CnNRahGvD/iTXm5//Sh3Tn/HHFI9Gq/F06dNx7 SJvGfAgHIkaKhUBkqti9O519EsW1sEpfnhbHbeLDWqyzChW/ERzjIzOtbEre3Q3lOa+Thx9uDY/bl oBvMYRTPFn7B/Br+X2Tj6pACLheDGYMY9V8ReGHUikRzRyIZsQkpkW1JFanyHwB7N7tKX+bhVbTyb zC0VJ0LFotOdmtm617TLnUabwnIRccssCQoHG+ztP/nRLlA+mc2TqY3SFDHy1pQmBS5jC4jg8dQg3 kvTDuMWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjFIQ-0000000EnKg-2Z8q; Wed, 28 Aug 2024 09:48:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjFHZ-0000000EnAb-43py for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 09:48:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E4CBDA7; Wed, 28 Aug 2024 02:48:27 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6E543F73B; Wed, 28 Aug 2024 02:47:59 -0700 (PDT) Date: Wed, 28 Aug 2024 10:47:57 +0100 From: Sudeep Holla To: Peng Fan Cc: "Peng Fan (OSS)" , "cristian.marussi@arm.com" , Sudeep Holla , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "festevam@gmail.com" , "imx@lists.linux.dev" Subject: Re: [PATCH] firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION Message-ID: References: <20240828014746.1713728-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_024806_081295_53D4A49D X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote: > > Subject: [PATCH] firmware: arm_scmi: imx: add > > MODULE_LICENSE/DESCRIPTION > > > > From: Peng Fan > > > > Add missing MODULE_LICENSE and MODULE_DESCRIPTION > > > > Signed-off-by: Peng Fan > > --- > > > > Hi Sudeep, > > My bad for not build this as module. If you need me fix the previous > > patchset, please let me know. > > Thanks, > > Peng. > > > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c | 3 +++ > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c > > index 0df7ca135c34..ad8734d2aeab 100644 > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c > > @@ -377,3 +377,6 @@ static const struct scmi_protocol > > scmi_imx_bbm = { > > .sub_vendor_id = "IMX", > > }; > > module_scmi_protocol(scmi_imx_bbm); > > + > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver"); > > MODULE_LICENSE("GPL"); > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > > index 9ee2d204d607..1d339cfa6ecf 100644 > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > > @@ -313,3 +313,6 @@ static const struct scmi_protocol > > scmi_imx_misc = { > > .sub_vendor_id = "IMX", > > }; > > module_scmi_protocol(scmi_imx_misc); > > + > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver"); > > Just find this Typo. BBM->MISC. > I was about to ask the same. Please take time needed to push out any patch, no point in rushing and churning unnecessarily like this. Anyways, I did hit the issue last night and fixed it locally but didn't push out as it was late for today's next. Please check if https://git.kernel.org/sudeep.holla/c/for-next/scmi/updates looks OK. -- Regards, Sudeep