From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15094C54FA6 for ; Wed, 28 Aug 2024 12:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PJoy2cgS+HW0K4p2KnocRxI+9IVsCSi90PCNEOIIuJ8=; b=WH3C08WWx/8KvMUDMzLqiuKcCV JwXIJF92Nau6U9NgUIRQY03knouHP/9MR7DwUxQx8DgHUW4kFj/uWzspXNe/CsaDdR2VeZ7fHHidU XO4GWs9npzeG0oiqRtUKMkjp4ik3syrPSD7G0O6E9WLK1o4adF8CTERDZq00zuCd7pDI78pAb7V9A xSjKFVArAgCsFqQkQCLLxlNVnMYNQd0dvZS4IPLON1xO8SnElRHq01CFpLxHR8v9rswzs8MwPlwJb NjF3j77OfrPIdNpOi0XnzcbcU/O6y5xcdIh+qR6j1aZOLiBS19IR889BiAdwe6qPrEPKJmPQ2/Hk+ 0OZbS+Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjI6d-0000000FNvi-13jh; Wed, 28 Aug 2024 12:48:59 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjI1z-0000000FN4B-3r8v for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 12:44:13 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-429da8b5feaso73655875e9.2 for ; Wed, 28 Aug 2024 05:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1724849049; x=1725453849; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PJoy2cgS+HW0K4p2KnocRxI+9IVsCSi90PCNEOIIuJ8=; b=EadFgGH0onHAKCjAKNQiZpirJQNgb6L6I7n8XhvSMq6Zpt44leQmvohiE1jBhIy1hE bzqhiEYLNFP+tJmePthfslfZUzA/KyfM+qJwEngIEWKi7sy628XyTzO3rALE8beyqK7t 8R7B/2ANOw5dxrrMeEyPaViZz5obG/N0MOJ7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724849049; x=1725453849; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PJoy2cgS+HW0K4p2KnocRxI+9IVsCSi90PCNEOIIuJ8=; b=IotJ4fPZLRfqWUl2OAjQkWSA1516U7FLPmD0By6q1K6QfwESDxxqIBqC0IdwfbHU0l jPjD+XfVsr09WQiy5Nfe5769noMaOewpGHr/tdTz2zzj4081xJsjDBwLbtmmxY9v6FBk JNvXVpMXm8QNZrY2BAw/YuqQW3wpKR2Q7DSktrMmGhu5ahmNsI2AbuNpCgkK41JNAzDu cik/ofEyJqkBcKvKieWlXPkoVq6UQnnjEkk+lUeTxKSqI/aXOt2WX5IDdnxlwfubtSLd dZyhhx9GkTL2kCBD5y0bawfZfK5ymEkzBxHKB18muYWD3RjO0pqUCi0K+uOGksEko9dN SfWA== X-Forwarded-Encrypted: i=1; AJvYcCXWYgV3COK9S0oArmAx2EpZu4fvbdGefqNj53jZXjs9eVgkRrI5fBBIM0hrNZr4MPUDqNB4o0fGSns4TWdS3HSP@lists.infradead.org X-Gm-Message-State: AOJu0Yzmnjqn9kElzKNSmusxdXTYSSHjCrY1//4qgPYgFYc+/BysqYLA SxqhEppuO53sgVzqrOoZ+M5ARzEtIOCAav6ZsM8wE8+7owLPXLOeenZp3xduXdA= X-Google-Smtp-Source: AGHT+IHu+Ym/EOCxiFAA+P0FEH5X9n6NL4h+Op9J46iU85Y8xtgIQz69/IK4Rj0aOvHw6CKRmZSolA== X-Received: by 2002:a05:600c:816:b0:42b:892a:3296 with SMTP id 5b1f17b1804b1-42b892a33d0mr113204905e9.37.1724849049421; Wed, 28 Aug 2024 05:44:09 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba63abe97sm20507885e9.24.2024.08.28.05.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 05:44:09 -0700 (PDT) Date: Wed, 28 Aug 2024 14:44:07 +0200 From: Daniel Vetter To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/6] drm/exynos: hdmi: use display_info for printing display dimensions Message-ID: References: <8a6fd6de1853dbc337c5c26c65268604d3e91fe2.1724348429.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a6fd6de1853dbc337c5c26c65268604d3e91fe2.1724348429.git.jani.nikula@intel.com> X-Operating-System: Linux phenom 6.9.12-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_054411_981065_B5E5C506 X-CRM114-Status: GOOD ( 22.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 08:42:48PM +0300, Jani Nikula wrote: > Look up display dimensions from display_info instead of the EDID > directly. This will be helpful for the follow-up work. > > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter > > --- > > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 1e26cd4f8347..25d508b25921 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -883,6 +883,7 @@ static const struct drm_connector_funcs hdmi_connector_funcs = { > static int hdmi_get_modes(struct drm_connector *connector) > { > struct hdmi_context *hdata = connector_to_hdmi(connector); > + const struct drm_display_info *info = &connector->display_info; > struct edid *edid; > int ret; > > @@ -893,10 +894,10 @@ static int hdmi_get_modes(struct drm_connector *connector) > if (!edid) > goto no_edid; > > - hdata->dvi_mode = !connector->display_info.is_hdmi; > + hdata->dvi_mode = !info->is_hdmi; > DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", > (hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"), > - edid->width_cm, edid->height_cm); > + info->width_mm / 10, info->height_mm / 10); > > drm_connector_update_edid_property(connector, edid); > cec_notifier_set_phys_addr_from_edid(hdata->notifier, edid); > -- > 2.39.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch