From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12C5EC5B54A for ; Wed, 28 Aug 2024 15:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RccO/6aYSzsD64ZgEXVUnoiwa51kK0FzwBqBJe1629o=; b=PwCMaSykjhCiK5nJrMYkC5ukFH 98OMG0MMAITse+d5Vxp0KbPYJKkT2NgzWe11JbADOXhpcy2P3jdqeoQQSwCGhHWesAt/wSA94cXcH rFz+zDbbuO3RWnd8TrFNNQL12rHGQDiMNgQeQ5V3UPAB1R3VgU3wGA9PUI7x1JAIrnwE0bk+5gZHb WFsaDr8sjsFsMuGMfzy7bcoxTO2OZdySKVYFOrz+6CDe9V3CIbo2FQAbqKNVY6vjLsbPs2Naj5eGV Zi+mfIctjrEd8VwMxR9Oicw/4EUkpZ1ymUKppt3tBueQ83nEz8QLH3ChLXw5TvBLTGxmA0ZD61Ft5 /XJb/r4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjKpX-0000000G281-3RMW; Wed, 28 Aug 2024 15:43:31 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjKXE-0000000FxI8-25xI for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 15:24:38 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5bec87ececeso7550353a12.0 for ; Wed, 28 Aug 2024 08:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724858674; x=1725463474; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:from:to:cc:subject:date:message-id:reply-to; bh=RccO/6aYSzsD64ZgEXVUnoiwa51kK0FzwBqBJe1629o=; b=KjqB3HFidJX7EpZ+XaZu4Awzkdy8HACgaKUe51AkA14SGV2O3ZDSNbaOUrOyyiRfai QVz8xMsEs/lqBxneqLPuN9MH64GOEf6I33VbTv1jlw6z9Tlcoj3lU66myKBZOyFsZ1Ra oze9J5WNdWQflzA29zfy/ILz41Qg1OcqxNQRnJy/6WbD2uja922WLA1Xh9KEWvdFWTbP N2JSyjjcRRCMR8KhhuOlJdkYgcOnnfvFb3MG+SL3byZ33aA0bddY/jirUvhdLs8l8RRa GpceHhaDE7+ojRvovt64u9OjZMmuc/lZTuEv57vc1F/dhXI1YOuMVekl0asUozjOXi9S wVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724858674; x=1725463474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RccO/6aYSzsD64ZgEXVUnoiwa51kK0FzwBqBJe1629o=; b=aUUA4f+kkEjqEMaDiWT2Bit1BLpnIG8nkIU6i3sIWDr/VzQTxzSxQrhT7irmIYuiTH ooXnFmW/i6lcIRfb6difkbVk7COSFEMObOI1vqbqMn37mgxCW6kWdOze3kwzJ7EgFhei bDBsADb2LOBPjj6kMVUGvZ9damlBh65mHtU22Cpa0bcyMKSDmcHIhmU3D/Grg0j1yjYI wM+DtSqQDHhd1fiQehaZTb9Yc++IqN1qvvXwn8pLNA8rdY+vMysHrx2GBqmI2pSCHJmJ 2LnkGm9V5HHqDBDog61/H5I1it1n1osjrLXMRk+m3e9ev19Vdo/Tuqf2Ve6xtYDmogpG cUmA== X-Forwarded-Encrypted: i=1; AJvYcCWNVuYyD+xulkHka1VD0UHrmhkIcBP/2Gc5uGWs8U/wUNr7Ke8eMmP03V3JMOVrqgs+jbNVh0PQinJxRzw9Y0Z3@lists.infradead.org X-Gm-Message-State: AOJu0YyWLqEZvLpG3EvYvLcB0/HV7CEVC7bECuYtahti33OGYsGtLSNm rpU0UPQByy+J70aXw6Usc7Esd/8mUp3bbzoKFZIBhWhDpPPfVcsdksR4mdSS9Gc= X-Google-Smtp-Source: AGHT+IEGTIMf9HDmr3RD/PvAk+4C11JysnBRyFuK/mQqbOsClKq28ul4IglJqfFC2hAOgC6a2khVvQ== X-Received: by 2002:a17:906:6a29:b0:a7a:a7b8:adae with SMTP id a640c23a62f3a-a870a94fe14mr219949166b.4.1724858673188; Wed, 28 Aug 2024 08:24:33 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e594a599sm255662266b.201.2024.08.28.08.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 08:24:32 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 28 Aug 2024 17:24:39 +0200 To: Linus Walleij Subject: Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: Mail-Followup-To: Linus Walleij , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_082436_558231_D142B8EF X-CRM114-Status: GOOD ( 26.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On 10:59 Mon 26 Aug , Linus Walleij wrote: > Hi Andrea, > > thanks for your patch! Thanks for your review! > > On Tue, Aug 20, 2024 at 4:36 PM Andrea della Porta > wrote: > > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > Add minimum support for the gpio only portion. The driver is in > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > support where the gpio part can be seen as an addition. > > > > Signed-off-by: Andrea della Porta > (...) > > > +#include > > +#include > (...) > > > +static void rp1_pad_update(struct rp1_pin_info *pin, u32 clr, u32 set) > > +{ > > + u32 padctrl = readl(pin->pad); > > + > > + padctrl &= ~clr; > > + padctrl |= set; > > + > > + writel(padctrl, pin->pad); > > +} > > Looks a bit like a reimplementation of regmap-mmio? If you want to do > this why not use regmap-mmio? Agreed. I can leverage regmail_field to get rid of the reimplemented code for the pin->pad register region. Do you think it could be worth using regmap-mmio also on pin->gpio, pin->inte, pin->ints and pin->rio even though they are not doing any special field manipulation as the pin->pad case? > > > +static void rp1_set_dir(struct rp1_pin_info *pin, bool is_input) > > +{ > > + int offset = is_input ? RP1_CLR_OFFSET : RP1_SET_OFFSET; > > + > > + writel(1 << pin->offset, pin->rio + RP1_RIO_OE + offset); > > If you include bitops.h what about: > > writel(BIT(pin->offset), pin->rio + RP1_RIO_OE + offset); Ack. > > > +static int rp1_get_value(struct rp1_pin_info *pin) > > +{ > > + return !!(readl(pin->rio + RP1_RIO_IN) & (1 << pin->offset)); > > +} > > Also here Ack. > > > + > > +static void rp1_set_value(struct rp1_pin_info *pin, int value) > > +{ > > + /* Assume the pin is already an output */ > > + writel(1 << pin->offset, > > + pin->rio + RP1_RIO_OUT + (value ? RP1_SET_OFFSET : RP1_CLR_OFFSET)); > > +} > > And here Ack. > > > +static int rp1_gpio_set_config(struct gpio_chip *chip, unsigned int offset, > > + unsigned long config) > > +{ > > + struct rp1_pin_info *pin = rp1_get_pin(chip, offset); > > + unsigned long configs[] = { config }; > > + > > + return rp1_pinconf_set(pin, offset, configs, > > + ARRAY_SIZE(configs)); > > +} > > Nice that you implement this! Thanks :) > > > +static void rp1_gpio_irq_config(struct rp1_pin_info *pin, bool enable) > > +{ > > + writel(1 << pin->offset, > > + pin->inte + (enable ? RP1_SET_OFFSET : RP1_CLR_OFFSET)); > > BIT() Ack. Many thanks, Andrea > > Yours, > Linus Walleij