From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2693C636EA for ; Wed, 28 Aug 2024 17:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C3jD1GD2D85OMoUZXmxj5MRza0Bwm8fS7Y9BuB/XhZ0=; b=Lzplm2zIdf6t65WOadUUWfb1i/ kv1Zus/uZPU6UJHd/39A+IE1Ya9eXCAW9LAn0NnHUfKzOTIwGyWgk+AmYcW64A5z+RHIL/frRBiVE vCYw7GNcfryGTABc3wM+lqJAiOJ/EI0oKtpnnKgPxgJCkGq+in4edwVocImSXXiWlgFiN+po0LT5v bq1tZz9ewbUe2s+1UH4xv0LbjDOfKeTaq05gzBIdxR0jAczNexhQGJZ3PGdohZqspIjBQH6Z29rL4 lebBVa1UYbWj7XTzigDWqSDpB+8YvyPFEqXi02+yhXERsWnsXJJBzqX0D6vlEopSynJOzlniOyhYG lxsk6aZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjM5K-0000000GI5g-1Fg4; Wed, 28 Aug 2024 17:03:54 +0000 Received: from mgamail.intel.com ([198.175.65.20]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjM3n-0000000GHhr-25l6 for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 17:02:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724864540; x=1756400540; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=d9jrs1TkJucUTZDoVN8NpJX7fWNl5Stq9MMeZWjHGJI=; b=ggQwAVgKaQ6kwrLOzATZlsyQsDU9OAcPQhf9MF1H7cUsszx7f6PxTGiM G7KDQC1zm/0RWs0XR08OUYrR9AjgB+hHoMrMk4gAu0b59Srkp5I36ZU7s XibEZLbqzP7JST028D6DJMJQXD0fPkdZFxOhpU/eD5NGuaGZ1r6QSP8TT WPvl1lMZxHe8Bp3CD4AfJE0V5Wi8M/zIgw57ATxENRdiZ1xoimQ3hnPjL jhQrdm8GROi6TTlQxi/IxOoGE8f6bNN3Yzb0j5wFibsGrDCjdjG6Namdx lxy8aVrETb7dG3Y7cWxrjhqQU6nOrzyk7vE30I1WOj9RQhjuciOR5Gdz6 g==; X-CSE-ConnectionGUID: rhBUWO5eQTK9M/gJ/B0h4A== X-CSE-MsgGUID: Nb0dyMfjTYCcX/t4JLAJWg== X-IronPort-AV: E=McAfee;i="6700,10204,11178"; a="23218143" X-IronPort-AV: E=Sophos;i="6.10,183,1719903600"; d="scan'208";a="23218143" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 10:02:19 -0700 X-CSE-ConnectionGUID: 9zj+glU8SrGQjSR1jwnwiQ== X-CSE-MsgGUID: 8Mpa8hCYRYyg8emb2Azf/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,183,1719903600"; d="scan'208";a="62925332" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 10:02:17 -0700 Date: Wed, 28 Aug 2024 10:02:16 -0700 From: Andi Kleen To: James Clark Cc: irogers@google.com, linux-perf-users@vger.kernel.org, kan.liang@linux.intel.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Weilin Wang , Athira Rajeev , Dominique Martinet , Yang Jihong , Colin Ian King , Ze Gao , Yunseong Kim , Sun Haiyong , Jing Zhang , Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/7] Event parsing fixes Message-ID: References: <20240828140736.156703-1-james.clark@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828140736.156703-1-james.clark@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_100219_609060_EE28824D X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2024 at 03:07:14PM +0100, James Clark wrote: > I rebased this one and made some other fixes so that I could test it, > so I thought I'd repost it here in case it's helpful. I also added a > new test. > > But for the testing it all looks ok. > > There is one small difference where it now hides _all_ > events, when previously it would only hide some selected subset of > events like "stalled-cycles-frontend". I think this is now more > consistent across platforms because, for example, Apple M only has > cycles and instructions, and the rest of the default events would > always show as there. I'm not a big fan of hiding all of , when they are explicitly specified on the command line they should be absolutely shown. I do have tools that specify events on the command line and expect the same order/events in the output. This might well cause breakage. -Andi