From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32E6EC3DA4A for ; Mon, 19 Aug 2024 12:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Db4hN2w3m7INit2SBeLbUeRnILkMZrxR2DmZlcKp+hU=; b=Y6TPXoR5msun7L8VyHhfyiTerQ 465j7XN4LA89zoOPcN3Ae0Dzo5p9QaYZRVTNy6vcuyIdorUcwvSsLKgmSTH6kfj7bwDwMYVBU24Oy E1M4VwGXOcTRiIY+MZMJshClnzRCIyTNPemtk5RTJF/ctoDk9pZECGK5LyMOO2lZs5XwjgzmYtjBo AGj8VTuiXYO35SkNkF0GDrTR6Tmg2sa6HAnGbaqHNJ/jknb4ncVHfcUHR0lvSpmRYEkIO79E6qSyA 4w7XWQT91lKrGb3DpJJ9yNLNMfAuLQkoGrXGf0HDPE6/MXliD3UreQ3BOPSRHM9aYnGn3BMyyDtUD K2hulxog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg1NK-00000001PFw-2VR3; Mon, 19 Aug 2024 12:20:42 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg1Lk-00000001P1g-03Bf for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 12:19:05 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5bebc830406so8145a12.0 for ; Mon, 19 Aug 2024 05:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724069941; x=1724674741; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Db4hN2w3m7INit2SBeLbUeRnILkMZrxR2DmZlcKp+hU=; b=DdVePDeO0rNHauhRGr4sjaa/ujfGRKiWsXQQxcGzcKCC0rh810KmyVq7r8566qFO8X ne+J18bc6Bsvd0yR4AN6KPhIICwvwXAow/Y3jjiUYsqv3IlcXV9W4PuDQ5rYJjp9RELF EfutrndTQzOS5zvll9Z7yaPaQcmAbc9ueIdFHO5AG/tw2UaU5/GgplxCT3ZO/AZhGJc5 R2TbSmZcd+K1yOMSFjOESEAHonkCbofz7m6iL794L0oXhZ88uG+MdJPmC4vT7x+ZDcIa MzpD1x+0ppbNpWKwRd7qU0m8+lMaJKAAihBg/RsrT+NLM2nqnUShFiwb2wmFtoSbcF/0 ljfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724069941; x=1724674741; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Db4hN2w3m7INit2SBeLbUeRnILkMZrxR2DmZlcKp+hU=; b=OS4b/ch/g7uq07mh8OyXboxXZqMyuuA5E/ohm8KS5123d4qvasCuF3tz7zWznNFJUT 3XfRTCoQW8twvxXVZsNAkBLHfb/hEKx6J7lNdSbrKfDPp1XibA1awWGsDWaupFBz8q3p pcLq64R5W/8V97BqDN8sGcRYuSDTOyEp1XU1l9jBjPCnkITJeUWflO0uy6oTKXeyX09/ 51jai6I5L9x+5zHTXRxT6mf7CxXZA7ENEUUGDuYqXakAfRoLzsjyqLBGAEm+16rfm9/Z YX4ruFOBPsS/6K2VvyUDpIgtQfj25b7JmMHWSb3asBaJfy0QspVeiTX7o3OSMB5ZVZy0 q2LA== X-Forwarded-Encrypted: i=1; AJvYcCVdpN47z2alZ//S43PkKcD/S614n9VML0QKH9kkRz3XDBA8Pa3yweQARIx4IWMnelLImyyzyWPLkJoidz7IKU7d@lists.infradead.org X-Gm-Message-State: AOJu0YzEksI/N+zMuBWGhHj09d4PSNnnMTYpk2q9TlQdObOAiUtgpU6n gxV2YzqYD8Cc1W2zH3yb1D5MAb/LS7KF5zbEwFw7LjWRw9pBMfJzpBkTJ9/ZJw== X-Google-Smtp-Source: AGHT+IEoH4NgDY0zYg9fqa4QM4SVY1O10WJ1j4848W30tFwb35xVV/g6Yfo36yCo36vqfTQ8XhRfwQ== X-Received: by 2002:a05:6402:348f:b0:5b8:ccae:a8b8 with SMTP id 4fb4d7f45d1cf-5bede24bf57mr84286a12.3.1724069940865; Mon, 19 Aug 2024 05:19:00 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189857069sm10401322f8f.47.2024.08.19.05.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 05:18:59 -0700 (PDT) Date: Mon, 19 Aug 2024 12:18:57 +0000 From: Sebastian Ene To: Vincent Donnefort Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v8 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240816123906.3683425-1-sebastianene@google.com> <20240816123906.3683425-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_051904_083468_26BE31C9 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 11:28:19AM +0100, Vincent Donnefort wrote: > > [...] > > > +static int kvm_ptdump_build_levels(struct ptdump_pg_level *level, u32 start_lvl) > > +{ > > + static const char * const level_names[] = {"PGD", "PUD", "PMD", "PTE"}; > > + u32 i = 0; > > + u64 mask = 0; > > + > > + if (start_lvl > 2) { > > + pr_err("invalid start_lvl %u\n", start_lvl); > > + return -EINVAL; > > + } > > It looks like a duplicate of the if below. I will drop this. > > > + > > + if (WARN_ON_ONCE(start_lvl >= KVM_PGTABLE_LAST_LEVEL)) > > + return -EINVAL; > > + > > + for (i = 0; i < ARRAY_SIZE(stage2_pte_bits); i++) > > + mask |= stage2_pte_bits[i].mask; > > + > > + for (i = start_lvl; i < KVM_PGTABLE_MAX_LEVELS; i++) { > > + strscpy(level[i].name, level_names[i], sizeof(level[i].name)); > > + > > + level[i].num = ARRAY_SIZE(stage2_pte_bits); > > + level[i].bits = stage2_pte_bits; > > + level[i].mask = mask; > > + } > > + > > + if (start_lvl > 0) > > + strscpy(level[start_lvl].name, "PGD", sizeof(level[start_lvl].name)); > > + > > + return 0; > > +} > > + > > +static struct kvm_ptdump_guest_state > > +*kvm_ptdump_parser_init(struct kvm *kvm) > > nit: I guess it's more a "create" than an "init" as we allocate the memory. Yes, that should work as well. > > > +{ > > + struct kvm_ptdump_guest_state *st; > > + struct kvm_s2_mmu *mmu = &kvm->arch.mmu; > > + struct kvm_pgtable *pgtable = mmu->pgt; > > + int ret; > > + > > + st = kzalloc(sizeof(struct kvm_ptdump_guest_state), GFP_KERNEL_ACCOUNT); > > + if (!st) > > + return NULL; > > return ERR_PTR(-ENOMEM); ? Yep, we can encode the ENOMEM in the ptr. > > > + > > + ret = kvm_ptdump_build_levels(&st->level[0], pgtable->start_level); > > + if (ret) { > > + kfree(st); > > + return ERR_PTR(ret); > > + } > > + > > + st->ipa_marker[0].name = "Guest IPA"; > > + st->ipa_marker[1].start_address = BIT(pgtable->ia_bits); > > + st->range[0].end = BIT(pgtable->ia_bits); > > + > > + st->kvm = kvm; > > + st->parser_state = (struct ptdump_pg_state) { > > + .marker = &st->ipa_marker[0], > > + .level = -1, > > + .pg_level = &st->level[0], > > + .ptdump.range = &st->range[0], > > + }; > > + > > + return st; > > +} > > + > > [...] Thanks, Seb