From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74E92C3DA4A for ; Mon, 19 Aug 2024 10:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HCnYXKbPejxZx0vHdL+PDYgS0GrW5E1HoGp5p5wjmA8=; b=cNWfgdTfKrYmtKvBiacCjGJiIa WYvKAnVASyJwX5z7IsUFvdIMBdNXU8R1te4TzwW6nuKbvBrHgbiZKkGe5Q3oGhU5dgFTjzywcqE6r wVdn6gRFkLsJki8dlyBkYZZieuHjx/4gcDL1Vn9Sxj8sfGWVqpbgEjPi4h6PUZoqZo782bpsOJvq4 DG/NEP/8gw8rtcQo2tr6nrbG2Jfih/Y1cd34B77VPpXSV8O+e3bghMPx9T0uLujHQFmzk6QbAfBEp H3FVbGTB9aSPdqXfOvuOH68UXOskq8IBAOWZnzqFr/nYyFrYe72u07XhiFaeMBLSMP6uXBc6hCRJQ VHosDqcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfzdM-000000016cK-32AX; Mon, 19 Aug 2024 10:29:08 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfzch-000000016WW-2sUs for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 10:28:29 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-371aa511609so1144530f8f.1 for ; Mon, 19 Aug 2024 03:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724063305; x=1724668105; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HCnYXKbPejxZx0vHdL+PDYgS0GrW5E1HoGp5p5wjmA8=; b=Wbn6kVGIHUhpopzqDyualkOvO6tnbzbnY/bbUNJra+s9TX7tn7tphZH4/6atO1eHmQ okDrjPgrdy5GYM2XP5vAEhhF73mH8Ybzv4HoK2SQeHz7mKhfVts6sT7/LQdwmoGHblRZ 1P2kPMLB0K+z5WEOBJTMUIuFLS2r7MHu9TYUlLWi75KJ0MSanc/ALyAco73AN55zFr4l oU26HSkr8P8uAUK9GbITqHQmthTMTUtEvwnr3HFFDNaM00WMPUQPR/zuJxRuwFwkVFTh VF9/QwtsrIR9KqAthZ0hP/pNYbDpg/Haf4J6yvm68E58uiXcL9AnffzWxxtq56573LW6 grxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724063305; x=1724668105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HCnYXKbPejxZx0vHdL+PDYgS0GrW5E1HoGp5p5wjmA8=; b=AFkUvAsfA49fektJuIbj5tYm3SgGAaUl17N6Je5BVGi1MNHhV5s6AW5YkNMvMyv2gp Zj2SfCl3TOBTnU+mRGQOVydBdTBM3HCV0ijR5jmhRB1LtvmxVBVkbFS11JEwVbWmi85d 4EI967g1I8ut3Brg8zIvsgurl5AZvGH0Ex5WiFIZo/4FvNU5KdhX0QnTJnIyEym2mhjW PCpeuiCBaqDxid95eLHexu1Sso793pXqGnqFQ37vT/+Y+/5ntDibr4/UXL653JGG33Va dWIjEdz5qLmJBsXUjh5zz3H/uj6N94DJPGA6mR3FW7j0ZLXlRUhHVOJjYesB0QiaE86f ZtLQ== X-Forwarded-Encrypted: i=1; AJvYcCUp4JskfndyRI0+qa+PRyTdIHU6MDz4/KM71WvpjUOEkhW6Yz8EIRNfmQhVvk64aEW9rqJsw2vL8eXUoGTWv302IMAodm48TKgZ7sA4jqeU1vjT4G8= X-Gm-Message-State: AOJu0YwYEtIrCCe/o5jY6ekDFKJDUiKBq/T/s6F8zDOkEJ5uhEqHROgo jOeWtLO99gY1GAYO/DeIO8h4mO7ll8Ema4V4daYoJ+/91modG+s7thLAEt+aBA== X-Google-Smtp-Source: AGHT+IH29AZnz1h0T1T38pt3izR9PAR4PDYKW5YJTXZhxJwmI5d0SQZeuuiLw0/+rgopZIybK6w00Q== X-Received: by 2002:adf:a35d:0:b0:368:319c:9a77 with SMTP id ffacd0b85a97d-371946535f5mr5589469f8f.29.1724063305033; Mon, 19 Aug 2024 03:28:25 -0700 (PDT) Received: from google.com (203.75.199.104.bc.googleusercontent.com. [104.199.75.203]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898498e1sm10186667f8f.41.2024.08.19.03.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 03:28:24 -0700 (PDT) Date: Mon, 19 Aug 2024 11:28:19 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v8 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240816123906.3683425-1-sebastianene@google.com> <20240816123906.3683425-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816123906.3683425-6-sebastianene@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_032827_778972_514DB2B4 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [...] > +static int kvm_ptdump_build_levels(struct ptdump_pg_level *level, u32 start_lvl) > +{ > + static const char * const level_names[] = {"PGD", "PUD", "PMD", "PTE"}; > + u32 i = 0; > + u64 mask = 0; > + > + if (start_lvl > 2) { > + pr_err("invalid start_lvl %u\n", start_lvl); > + return -EINVAL; > + } It looks like a duplicate of the if below. > + > + if (WARN_ON_ONCE(start_lvl >= KVM_PGTABLE_LAST_LEVEL)) > + return -EINVAL; > + > + for (i = 0; i < ARRAY_SIZE(stage2_pte_bits); i++) > + mask |= stage2_pte_bits[i].mask; > + > + for (i = start_lvl; i < KVM_PGTABLE_MAX_LEVELS; i++) { > + strscpy(level[i].name, level_names[i], sizeof(level[i].name)); > + > + level[i].num = ARRAY_SIZE(stage2_pte_bits); > + level[i].bits = stage2_pte_bits; > + level[i].mask = mask; > + } > + > + if (start_lvl > 0) > + strscpy(level[start_lvl].name, "PGD", sizeof(level[start_lvl].name)); > + > + return 0; > +} > + > +static struct kvm_ptdump_guest_state > +*kvm_ptdump_parser_init(struct kvm *kvm) nit: I guess it's more a "create" than an "init" as we allocate the memory. > +{ > + struct kvm_ptdump_guest_state *st; > + struct kvm_s2_mmu *mmu = &kvm->arch.mmu; > + struct kvm_pgtable *pgtable = mmu->pgt; > + int ret; > + > + st = kzalloc(sizeof(struct kvm_ptdump_guest_state), GFP_KERNEL_ACCOUNT); > + if (!st) > + return NULL; return ERR_PTR(-ENOMEM); ? > + > + ret = kvm_ptdump_build_levels(&st->level[0], pgtable->start_level); > + if (ret) { > + kfree(st); > + return ERR_PTR(ret); > + } > + > + st->ipa_marker[0].name = "Guest IPA"; > + st->ipa_marker[1].start_address = BIT(pgtable->ia_bits); > + st->range[0].end = BIT(pgtable->ia_bits); > + > + st->kvm = kvm; > + st->parser_state = (struct ptdump_pg_state) { > + .marker = &st->ipa_marker[0], > + .level = -1, > + .pg_level = &st->level[0], > + .ptdump.range = &st->range[0], > + }; > + > + return st; > +} > + [...]