From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4202C52D6F for ; Mon, 19 Aug 2024 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T+1W3i8+g2sQNzk6r7xamyZJgO74Cx+unIizekLB9TE=; b=HB4qYOVGZnVoLY0u+ztMxzNGaV zsANhaNLkKqmLFMMI/b0AgrsJ432ny/k9A++vWE8xFNhqA6FcOCMnJ1OVCwfsFphdprV+O93expVc W0JFAIhRClpSDTpsjcNAEyCvg87yxaXrN9IEjdAd0PLyMoshHOVFleJWuELD/6c+jbihKt3+3jB8H /cSmc4HHqKy1h5YWjUqGbHnBtUr5XATfW0TryvF4YiKjK2v+sjlQKaaM6Y0v1g5SdzNwO69+chaUN uPrTLelBsx8DRmhXIzLn2fmMbk+2AG9jOlhIIiENmAbvgw/ZVk53Z48YLEpq8/iO1EP1MHPcYvv7+ 0ENtBtug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg68D-00000002OqT-1IA9; Mon, 19 Aug 2024 17:25:25 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg5xe-00000002M5Z-1Lea for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 17:14:31 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1fec34f94abso39164295ad.2 for ; Mon, 19 Aug 2024 10:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724087669; x=1724692469; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T+1W3i8+g2sQNzk6r7xamyZJgO74Cx+unIizekLB9TE=; b=bFhRsJULOK3b+oebERSEkyLLq/Pot8P1c6F8YkgGDThu0uUfBUg5p1rj6KJIOxCr/6 hF8UKyYf6hBGpxX7wSSyyEeLt4NIXA2euKbtlZgyZRlmelppHgPB0F5adNSNttj1V+eL B9ZAvEANSUu/3KOGDFWeAD45VIYV2Hz6n/PEnppDT+/Yl2eWru6M2gbeKxoYlMm3GFSm 0Jj5C8xRxK9KWQVvEOFlTPUCIiNI2pk5eobsxXM6vdPxejRgLKL432lYPphrB9PuRU2z Jd6+0KDtsWRxB5pyFsI/Wiej4j5F4ktcFfY/CydKrh2aDIxJxzSVIOdRngaLHcs+UE3K PNUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724087669; x=1724692469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T+1W3i8+g2sQNzk6r7xamyZJgO74Cx+unIizekLB9TE=; b=fCjoKKheCxD3Z62X58J5vsW5BrYRIOe87+C/o6TjUlkeXV5UzClgrDRsJK+b5Hd7oG jfZjXp5k9xMNyAk8Ob7ltgaX49dbSKllYc6TU6uuVgh4FkbefMfuMHOB+/IxuX9PNOE+ xNiYuxLlZ7CtrcAu2DPYVQpLFGaS+hGif6zFoE8tpdiBTFjTnv3nA1D9RbJLwCgNxm4r xa22WNWKDls4Gp6CJp3snHyj7SGkMrvi+sA7R5otBrv9ZLUKVB7nqEni1/KtIeIb6VQf xQHnN1cgUaX8L6rPxcqvw4OW3bhqLcddPaYHOt/M8TcbCxRau/HyfJSQxZVF08cwoI2i VTbg== X-Forwarded-Encrypted: i=1; AJvYcCUPXZNZiH1rSOd+PhotssuvBe/k0Be0oWc6X5MI+fHC4VyYR7sPsFMmGML0DVawvES43ymlY+98zIaNCvux+a+LsiSSx0Ae4PGa3FMHK9egKbjDx2g= X-Gm-Message-State: AOJu0Yyv1sVe37DSePaLN0SH6AD11zaRxfQPW5J0G5sjLqtcqsPKJbLX /n3F0Lxcf8awCMyc88+WI3QfaYb2pp9DNCq7VboApgTf25Fl1F8Q X-Google-Smtp-Source: AGHT+IGbr2onx4ALkUToG2oYkiUzveBUM0PwKcKZAeoti+0kD3JnIpr3+bOL7x2PCFhQQkIUjj3OUg== X-Received: by 2002:a17:902:e84b:b0:202:18de:b419 with SMTP id d9443c01a7336-20218deb7a8mr81679975ad.63.1724087668636; Mon, 19 Aug 2024 10:14:28 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:f80c:1483:bced:7f88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-202592bdf7fsm6166015ad.181.2024.08.19.10.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 10:14:28 -0700 (PDT) Date: Mon, 19 Aug 2024 10:14:25 -0700 From: Dmitry Torokhov To: Conor Dooley Cc: Krzysztof Kozlowski , Arnd Bergmann , Mark Brown , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding Message-ID: References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> <20240819045813.2154642-10-dmitry.torokhov@gmail.com> <20240819-backstab-fanatic-54788c691f9c@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819-backstab-fanatic-54788c691f9c@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_101430_381662_4DC50AA0 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 05:48:06PM +0100, Conor Dooley wrote: > On Mon, Aug 19, 2024 at 08:49:10AM -0700, Dmitry Torokhov wrote: > > On Mon, Aug 19, 2024 at 03:02:07PM +0200, Krzysztof Kozlowski wrote: > > > On Sun, Aug 18, 2024 at 09:58:06PM -0700, Dmitry Torokhov wrote: > > > > > > > > + - keypad,num-columns > > > > + - keypad,num-rows > > > > + > > > > required: > > > > - compatible > > > > - reg > > > > - interrupts > > > > - - samsung,keypad-num-columns > > > > - - samsung,keypad-num-rows > > > > + > > > > +if: > > > > > > put allOf: here and this within allOf, so you the "if" could grow in the > > > future. > > > > Hmm, there is already "allOf" at the beginning of the file, so adding > > another one results in complaints about duplicate "allOf". I can move it > > all to the top, like this: > > > > allOf: > > - $ref: input.yaml# > > - $ref: matrix-keymap.yaml# > > - if: > > required: > > - linux,keymap > > then: > > properties: > > samsung,keypad-num-columns: false > > samsung,keypad-num-rows: false > > patternProperties: > > '^key-[0-9a-z]+$': false > > else: > > properties: > > keypad,num-columns: false > > keypad,num-rows: false > > required: > > - samsung,keypad-num-columns > > - samsung,keypad-num-rows > > > > Is this OK? I don't quite like that "tweaks" are listed before main > > body of properties. > > The normal thing to do is to put the allOf at the end, not the start, in > cases like this, for the reason you mention. I see, thanks. It would be nice if it could combine several "allOf"s into one internally. Thanks. -- Dmitry