From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46F19C3DA4A for ; Mon, 19 Aug 2024 14:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PgIQHKvxINV8ovUdofvk90SRsFNtQrsv8SYAZXy1GIw=; b=1Xl7Wa8y11UsINy5dh5ye4MiOK yJ4Og+oExkE0xe9yrhgj9heGER/1n0B2RHG8TNDbeCyyB2VMcD983ehESDnGJyBY1JUV7byZVpePe QRrJ2yKZoseyqlot6G0n70xCOnjgOQzAg4YsDYR3lcpIer2n5zzGbIdfh5TWmTV004VjmHKui7+z8 VnSRA2y/YOXaOxzYe6Dr9MjB+Zh2J9aUIB+cdPvhTU5KbNp0BR9GeziKxGjoZY/1b8ZQiLf1bVpdg rY06+0cF9g+bZrFfzLtbdJs+ycia1KCoDV8SBqP/9EjBeyM4dUuiPLa5a3yxRmzN4G+GZIDUUWK1L 26Qn6+0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg3g7-00000001orU-3yGD; Mon, 19 Aug 2024 14:48:16 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg3f0-00000001oey-02zO for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 14:47:07 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-71275436546so3726864b3a.1 for ; Mon, 19 Aug 2024 07:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724078825; x=1724683625; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PgIQHKvxINV8ovUdofvk90SRsFNtQrsv8SYAZXy1GIw=; b=SfpfVxYW2Ds7p54DwhBW9EPZn+LH41mJnpPQi1F17rCFdwJ5yuYXwHfQNiBrod1X8x ebSbPuG7Q8YnC4Aw8gX2+HpCDMpYZQZxUeydkMuT2BTKzdzNbZlriTrsVNc1IIRq3VHn qaOJU+sMlUz3aQMYmwJZGBKPnB9ga/JANWLHIv+SwvQZqS+g5kF7GeNN8T6h8rhcK6ET d+RrVNtLDRkVdyf6t5IasrGwaL84U4px2lzhNfscccaxqToIFsqyTbCuYaApTXmOPx1+ a3q1LTrQedScOdx7e11WcRW5Kvvjice56HCYBW2ogbVfLB0NmERj4v3oYrjLvVbLFOM2 wV5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724078825; x=1724683625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgIQHKvxINV8ovUdofvk90SRsFNtQrsv8SYAZXy1GIw=; b=KxF7HhX8biWlpDs3O1AhdYQdDp2aZWK6qM1+kocJdaJPNJgVlogQre2MrI4xysWiWN KGyf2w2LOOpv9VGWAb5x7DxVxyPjNgUbIQTf4JOs3X0VdL6rTzD5lPFBP3vJq1XLsfL3 OICeWD6FakeA/je9+bnkP/7Ai42VVNd9vMQVtcklwlLgubYxmiv8vKvXB2bzUvSpd8SK y0eFE+0OrkVunn6h3W6KP7FcXDq0UfZdfx7NnetkDdYjBrvCK1tPijk/wlrzsHjmm14d HC8LehnT0KdISMhnDCj1+MECWXrAZVCPev6+Px07CVWQDKwG6fEUhmFMfAlNORSCCIFG Rv3w== X-Forwarded-Encrypted: i=1; AJvYcCWL8T0BSdHyXhHxvlB0N2UQ2MsngGBuW4BFn+XPPZi24F0UZLlBF+yEBeg81kPdlV+gmMhMf3bdol1KhRnD+u88D7DBgS4kjrEX3x2/RRaDk89Gm5E= X-Gm-Message-State: AOJu0Ywf6lx1dcCASIke4Vc8zf4raLB4qgmMZp5p/3iu7a9OKXmWAIVp FHN5Rg9fIaK11T6vCk1UkUL8TAPjojzOmtdixsl5F75h11YtmjYRVAek4Q== X-Google-Smtp-Source: AGHT+IGrCgLg0GXxkzDgwGDOBKGFKORKGgvOeeHFPa54by/bTROcalylrW+u03hvlcCh5NVWpjksHQ== X-Received: by 2002:a05:6a20:c90e:b0:1c4:c305:121c with SMTP id adf61e73a8af0-1c9050261edmr14517485637.42.1724078824487; Mon, 19 Aug 2024 07:47:04 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:f80c:1483:bced:7f88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127af16628sm6884782b3a.144.2024.08.19.07.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 07:47:04 -0700 (PDT) Date: Mon, 19 Aug 2024 07:47:01 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Cc: Arnd Bergmann , Mark Brown , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 05/14] Input: samsung-keypad - use devm to disable runtime PM Message-ID: References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> <20240819045813.2154642-6-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_074706_142957_25910F83 X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 02:54:39PM +0200, Krzysztof Kozlowski wrote: > On Sun, Aug 18, 2024 at 09:58:02PM -0700, Dmitry Torokhov wrote: > > To make sure that runtime PM is disabled at the right time relative > > to all other devm-managed resources use devm_add_action_or_reset() > > to register a handler that will disable it. > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/input/keyboard/samsung-keypad.c | 24 +++++++++++++----------- > > 1 file changed, 13 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c > > index 7adcd2657bca..924327de4d8f 100644 > > --- a/drivers/input/keyboard/samsung-keypad.c > > +++ b/drivers/input/keyboard/samsung-keypad.c > > @@ -310,6 +310,13 @@ samsung_keypad_parse_dt(struct device *dev) > > } > > #endif > > > > +static void samsung_disable_runtime_pm(void *data) > > +{ > > + struct samsung_keypad *keypad = data; > > + > > + pm_runtime_disable(&keypad->pdev->dev); > > +} > > + > > static int samsung_keypad_probe(struct platform_device *pdev) > > { > > const struct samsung_keypad_platdata *pdata; > > @@ -420,11 +427,16 @@ static int samsung_keypad_probe(struct platform_device *pdev) > > > > device_init_wakeup(&pdev->dev, pdata->wakeup); > > platform_set_drvdata(pdev, keypad); > > + > > pm_runtime_enable(&pdev->dev); > > + error = devm_add_action_or_reset(&pdev->dev, samsung_disable_runtime_pm, > > + keypad); > > + if (error) > > + return error; > > I think you are open-coding devm_pm_runtime_enable(). Ah, I didn't realize we had it. Thanks! -- Dmitry