From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C27A5C52D6F for ; Mon, 19 Aug 2024 15:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xwNCdzYfm502YO+gdgho2F7EWViMhewsDliJcvxl3mY=; b=qb0eHmrLoaXEFwRKe6L4N5jpXM uxNiiSRyWd6D+Pk5ETPcCsFnDsAqOtbptw80FkWJAGcyGKZ8CRbYhslIgLktDWEjSqmBvvUXJMenI xPHGKqp/YLfrbhnnS3MqbnRy7RK2TXhPAhK9KOzafvRhtP/y43EIVXOV+NehfAxaVNTenyGJcDUIk qt4nWJg0nbJURvgBiGMMR5VfeEI/El72PJRRyAMNJuZ1Nn4XB8aLZQBhxHF+4zll52Skg9pleye4q y/nyZBBqC+/qSORHyUK0dR+88kbMWQU8+ElBudSyqlvyJ1XDjmw7Rkt/sWcUSmqA6ytbxn+ZnLN77 xdjgx1xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4Nd-00000001xPh-0jEs; Mon, 19 Aug 2024 15:33:13 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4Mw-00000001xFv-2Ps5 for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 15:32:32 +0000 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2d3ce556df9so2593752a91.0 for ; Mon, 19 Aug 2024 08:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724081548; x=1724686348; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xwNCdzYfm502YO+gdgho2F7EWViMhewsDliJcvxl3mY=; b=potvCM5JFvm4TeBi9bT54z6MaG9f3NVp39fNGCN3yYw+VM82lUIaRf7N87OEVl6ozD x9jUN22aaXFbzC0NnQZCbODPMNV8oiUfUZAlLFD75JrzDlshQbTFQgWAF4l/OBr7Ei7E DcfWUvw4RKUbby6AGj13m7PiO+ttF5/llvi6HQWvludBlGjUwIIgUw5PTbFv2VFg9zqf 184CdsdgXj4YC1VA70doe9f4axd5IFHWP0xGittlHkqTDAufuHVRkXpykPEatkBWlwo6 zzRB2peV/eLcO3JRgUx9o/qB15LWDBOEHRD6cuM3ayRTii6Gh21/9ywNDLw0lkixjN4D uxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724081548; x=1724686348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xwNCdzYfm502YO+gdgho2F7EWViMhewsDliJcvxl3mY=; b=jVlD+SGG4UKM9rTA4aJEJDQJpXW17WZzbcqFBQFQOu7LdIf74mnPPpDLbv6ElKQeht xjp4724Q38TZyyLIdW4k4/wwcD/zyD8HhKiYII59p2Ou4TqT6w/DQK6kcYhgsJjYs0Ba gbHi1RiMpmOBX7+8VAlY44mimB12l7IQz6tUzIcLrvGVQFoYeVP103SiW/tALB/wTQEn /LQVO687jLS5GbiAxZWYoZbP6qRar81YdzEQ6atWpxQLFlio3gVOJq0wnJxqv+35uCvp Sn8pCgJeC27yI0LFDgjiY+i3xlvXE7y88j56Hve9sldoby0beblOBNx6SdUvnpbXFO9u x2Tg== X-Forwarded-Encrypted: i=1; AJvYcCU90sXIVn/Y4EgaYL5OJh1PiDMDf3bD5n8A1obgdwv3hGQxc7Goaw2tZfDCkyf+OF2JCeL3MuGlBItQySvSQsDW1vjjCUl5L4cMkBO7qwzVrVkwXzI= X-Gm-Message-State: AOJu0Yw2KxSRPa3A2QiPF+Fm2EFz+yNv5P67+3E0uv8V/TilZpZmveVL 0OU9Mki/YqKLQryz2DAAlvFbbToT0WxUNJFrnvaxdjlUuUbPTc3jwVIYKlvCNaE= X-Google-Smtp-Source: AGHT+IE/XR0ngoLW1xfBcf6BCEcckpp4YsYG2yv409hGZPpf7SP8xRVmb1yZCKcoWtCTUsOyfjciOg== X-Received: by 2002:a17:90a:f68d:b0:2ca:4a6f:1dd with SMTP id 98e67ed59e1d1-2d3e0e41f2emr9178712a91.41.1724081548587; Mon, 19 Aug 2024 08:32:28 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:903:55bf:2534:1807]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d3e2330f26sm7379940a91.0.2024.08.19.08.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 08:32:28 -0700 (PDT) Date: Mon, 19 Aug 2024 09:32:25 -0600 From: Mathieu Poirier To: Vignesh Raghavendra Cc: Andrew Davis , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Tero Kristo , Philipp Zabel , Hari Nagalla , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Message-ID: References: <20240802152109.137243-1-afd@ti.com> <20240802152109.137243-4-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_083230_657656_F34D6B54 X-CRM114-Status: GOOD ( 25.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Vignesh. On Mon, Aug 19, 2024 at 02:02:31PM +0530, Vignesh Raghavendra wrote: > [...] > > Hi Mathieu > > On 16/08/24 20:06, Mathieu Poirier wrote: > >>> +/* > >>> + * Attach to a running M4 remote processor (IPC-only mode) > >>> + * > >>> + * The remote processor is already booted, so there is no need to issue any > >>> + * TI-SCI commands to boot the M4 core. This callback is used only in IPC-only > >>> + * mode. > >>> + */ > >>> +static int k3_m4_rproc_attach(struct rproc *rproc) > >>> +{ > >>> + struct k3_m4_rproc *kproc = rproc->priv; > >>> + int ret; > >>> + > >>> + ret = k3_m4_rproc_ping_mbox(kproc); > >>> + if (ret) > >>> + return ret; > >>> + > >>> + return 0; > >>> +} > >>> + > >>> +/* > >>> + * Detach from a running M4 remote processor (IPC-only mode) > >>> + * > >>> + * This rproc detach callback performs the opposite operation to attach > >>> + * callback, the M4 core is not stopped and will be left to continue to > >>> + * run its booted firmware. This callback is invoked only in IPC-only mode. > >>> + */ > >>> +static int k3_m4_rproc_detach(struct rproc *rproc) > >>> +{ > >>> + return 0; > >>> +} > >> Please remove. > > Forget this comment since it would cause an error in __rproc_detach(). > > > >> Other than the above I'm good with this driver. That said I can't move forward > >> without a nod from the DT crew. I also noticed a fair amount of code > >> duplication with the k3_r5 and k3_dsp drivers. Dealing with that should not be > >> part of the current work but will need to be done before another k3 driver can > >> be merged. > >> > > > The above still apply though. > > Me or Nishanth will pick up the SoC DT patches via TI SoC tree, once the > driver patches are merged. Feel free to ignore those but queue > dt-bindings (already has DT maintainers ack) and driver patches via > rproc tree. > Can you provide a link where the DT maintainers have acknowledged the bindings? > > -- > Regards > Vignesh