From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8286C5320E for ; Tue, 20 Aug 2024 09:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9uw31df0yYgKhnrg0jo5JCLCW+oyFKfIyOyEgw5hHhk=; b=Hr1Z6fH3TRsnr6/w3RfGgCX7G0 ILZebG4tcYtGI06aI6I362lbAcvIhrV6Ws+JK5kPn7Xx2W0My7nnlEOTDdXNTQ8zyi6KR4YyX9RMP Ca8wcAsz6hU+wVoWFDVJ9b9hrQvTHxf3X6za2yjhn5WgwPUS9VdikiZHdgHPxo6RbskIRK1Qtvp1a jPns8QMvSOn3XC8ffSdA6lfwHEaPmCGTG1TFemWNgkxBMUvupZeAcnxIagedn5FBlIOiT5S7dEba7 ewLHOJjcmYJD+2I58BIhAfimy4rPpjdy1/xWJ+Fe9yYTBOxhtd5aYhJDM8D3zzOypIOT2fLj+kkuQ hVxxb4kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgL3R-00000004Xai-1EJQ; Tue, 20 Aug 2024 09:21:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgL0s-00000004X25-43Np for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 09:18:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 025ABDA7; Tue, 20 Aug 2024 02:19:16 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 037253F66E; Tue, 20 Aug 2024 02:18:48 -0700 (PDT) Date: Tue, 20 Aug 2024 10:18:46 +0100 From: Mark Rutland To: Jing Zhang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Shuai Xue Subject: Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing Message-ID: References: <1724068110-45239-1-git-send-email-renyu.zj@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1724068110-45239-1-git-send-email-renyu.zj@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_021851_079459_CD843356 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 07:48:30PM +0800, Jing Zhang wrote: > The alibaba_uncore_pmu driver forgot to clear all interrupt status > in the interrupt processing function. After the PMU counter overflow > interrupt occurred, an interrupt storm occurred, causing the system > to hang. > > Therefore, clear the correct interrupt status in the interrupt handling > function to fix it. > > Signed-off-by: Jing Zhang Presumably this should have Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC") ... right? With that: Acked-by: Mark Rutland Mark. > --- > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > index 38a2947..c6ff1bc 100644 > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data) > } > > /* clear common counter intr status */ > - clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1); > + clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status); > writel(clr_status, > drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR); > } > -- > 1.8.3.1 >