From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1717FC5320E for ; Tue, 20 Aug 2024 09:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WTMIq8RvZ+4NlBwezuXtVax+xuPwWSnLWLO4NP4jWu8=; b=EzkXN6iF0l4to13ui0MaN4RqvB FqsxXsYM/dnDmejCCwj9PslbQXVGSiSjFO8KrR3B3puntVcS9n2La0CJI8qvrz7s2bUiYDwgufSYO eyUkQJ7Big7ec7vepnUO1sIg9MEjFgv+LUdePytdUroPdfenq7jrQprALCcUuxvbme48RYXQKH9UB iW1XvQt/IMdptqEq7ZoTAVeOwSrBRw3zQL4NDJJtuf/Y2o+SwSimsSRtyC4uhtwbW31fPahkpUw4J xdrkxEQLUWjoyVbbEN0Vc1nF1vmk1Pkfr69yS8plt/uuv3psafUD4C7jiYV8ivJldLL22emSOvjmT QHxqrCmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgL64-00000004Y4k-2YDd; Tue, 20 Aug 2024 09:24:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgL5N-00000004Xto-1e7Q for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 09:23:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1324DA7; Tue, 20 Aug 2024 02:23:54 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3D463F66E; Tue, 20 Aug 2024 02:23:27 -0700 (PDT) Date: Tue, 20 Aug 2024 10:23:25 +0100 From: Mark Rutland To: Robin Murphy Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ilkka@os.amperecomputing.com Subject: Re: [PATCH 6/8] perf/arm-cmn: Refactor DTC PMU register access Message-ID: References: <4854a6b2-805a-4705-b2d2-df723cfc1311@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4854a6b2-805a-4705-b2d2-df723cfc1311@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_022329_494467_64C093CC X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 05:41:30PM +0100, Robin Murphy wrote: > On 16/08/2024 11:29 am, Mark Rutland wrote: > > On Fri, Aug 09, 2024 at 08:15:45PM +0100, Robin Murphy wrote: > > > Annoyingly, we're soon going to have to cope with PMU registers moving > > > about. This will mostly be straightforward, except for the hard-coding > > > of CMN_PMU_OFFSET for the DTC PMU registers. As a first step, refactor > > > those accessors to allow for encapsulating a variable offset without > > > making a big mess all over. > > > > > > Signed-off-by: Robin Murphy > > > --- > > > drivers/perf/arm-cmn.c | 64 ++++++++++++++++++++++++------------------ > > > 1 file changed, 36 insertions(+), 28 deletions(-) > > > > Aside from a minoe comment below this looks fine to me. > > > > > struct arm_cmn_dtc { > > > void __iomem *base; > > > + void __iomem *pmu_base; > > > int irq; > > > - int irq_friend; > > > + s8 irq_friend; > > > > Unrelated change? > > > > AFAICT there's no reason for 'irq_friend' to change from 'int' to 's8', > > and nothing in the commit message explains it. > > Oops, I had meant to note in the commit message that this is a little > structure repacking where there was a hole already, to compensate for adding > the new member... I shall un-forget that for v2. Cool, with that: Acked-by: Mark Rutland Mark.