From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88282C531DC for ; Tue, 20 Aug 2024 16:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cqVmNf36unFHBK+FfoUHfv7AMu5TB9aKm0xHrMHZXeI=; b=jJtu8sdLprQGOUZceaVxrOOUAv Atcq5ALbJPOseSUfl9HjX+BqWLk6fvNsXVhXGo54B0tndswIYTLNogEO4EoqukZxcYul34lIQdZPT mCmvy8WJdciIg6eHvMUs3dXi82QubnuWjkEAUY4a7aAzKu84XD12q0O973UZ/T3eGo27IVbUTAk6B B0VXcghPYdShmTwnW8FdPqOsBC/NyQ3kg23dUK1lvqgBVqujXbNiBF5Jbw5zzMxk24Kwjq4FZMHUd bWDlhA0MV6Xq27yQ/ly0ImpEF9dvz/9R8fZfM47bogbDW3z55BTtWsVGXCImTkq8kQcXdhhWKL5vz EZR7HJOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgRHd-00000005us3-3s07; Tue, 20 Aug 2024 16:00:35 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgQ12-00000005b2J-1LSQ for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 14:39:21 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42807cb6afdso32305e9.1 for ; Tue, 20 Aug 2024 07:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724164758; x=1724769558; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cqVmNf36unFHBK+FfoUHfv7AMu5TB9aKm0xHrMHZXeI=; b=s6IqWHQkfjNti3vS7DAi1A7s4IN165Qs5BrqQ3p5aGW5OADiy01GESCn/vXicxk5Em z7Sijy1c9b5FUeSkU+KWxUKEalGHhHbC1mxTuC5FLIxURkqkhOyAx4yNOn8gaji4JShz j5iZPS0STBRso5IBLc64guNEWb2ctSkkl+RDqojy6P2ZOfU1nDLRhr7T7NupbyAzihle C7UQltLw+xQF92TJ+4ewzTuU9rc3ukxclIeQCm4aWUKkP8aD8E88h7pMDuWxKZAyZ1Wj 8R6BLDKd7mz9kXxTKp6C//9TEECb7P8p8AFk0AcAqWEF4IC2rRZSOLaZUG9CmrqKRiSo XiQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724164758; x=1724769558; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cqVmNf36unFHBK+FfoUHfv7AMu5TB9aKm0xHrMHZXeI=; b=bn8DItNGcoDB4FyKZ9AalCxej8BkdsGC80Fr8/1XxL8HQsoJLvXqCCAmIvZv3TbYY+ 68lbpxaEBSrsYZR17Pn7Dns/8N2Lm723FkTbn9s7JsUneiJRQgNChN5FNRswkngJo4yi BNFf+kCoC3ztHZ0uUEc7K4HdPJOLNxpAhWCCGUg3rikFnwG6bpz4lR4V9Zn44qm1gDY7 r79dQVwN/86wfCUY8hokqa1wrKQRXRpeU8z55zgEbtdIQZkmXvGa2Gftir/7P5jNxm5y O3BcD8ePIt3qjQhZGGvwkXNJQcY/2G7l/9VBnjNOqiSEW4vkpe/nvJWcHQjgeU6wGlEN 9lMA== X-Forwarded-Encrypted: i=1; AJvYcCVECj0SywBkLu2rAqHVboekWFVsVvP0e45qYnOMK2JYi3QdrcCK4EFiXGpYcLCJjY7y4ZaR+CMQkYIstlyXwkxqnYWtDLE4+v2Ak9zpC0Qm/GPkulA= X-Gm-Message-State: AOJu0YztZyWCl1cY+0bOXSZchLgWdAKViSOcRATBmTf24bMi16POaSQS 5fwB7Wfh1jWande/IQaggIBVTDQpue12qL+6T+8yYmzCGG/AnHY9DezmrQ9kHw== X-Google-Smtp-Source: AGHT+IGIk3MuqZdFNT/V7eQCmxiAfwHKBaInvEhxBOOQ8nVu90AHYeozvhTj6iSXtj9NeYtV9xajCA== X-Received: by 2002:a05:600c:3d8d:b0:426:5d89:896d with SMTP id 5b1f17b1804b1-42ab78c2de8mr553675e9.1.1724164758048; Tue, 20 Aug 2024 07:39:18 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded29303sm196157775e9.15.2024.08.20.07.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 07:39:17 -0700 (PDT) Date: Tue, 20 Aug 2024 14:39:16 +0000 From: Sebastian Ene To: Marc Zyngier Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v8 3/6] arm64: ptdump: Use the mask from the state structure Message-ID: References: <20240816123906.3683425-1-sebastianene@google.com> <20240816123906.3683425-4-sebastianene@google.com> <86seuzxq27.wl-maz@kernel.org> <86o75nxody.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86o75nxody.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_073920_450272_642E50E6 X-CRM114-Status: GOOD ( 40.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2024 at 03:25:13PM +0100, Marc Zyngier wrote: > On Tue, 20 Aug 2024 15:13:27 +0100, > Sebastian Ene wrote: > > > > On Tue, Aug 20, 2024 at 02:49:04PM +0100, Marc Zyngier wrote: > > > On Fri, 16 Aug 2024 13:39:03 +0100, > > > Sebastian Ene wrote: > > > > > > > > Printing the descriptor attributes requires accessing a mask which has a > > > > different set of attributes for stage-2. In preparation for adding support > > > > for the stage-2 pagetables dumping, use the mask from the local context > > > > and not from the globally defined pg_level array. Store a pointer to > > > > the pg_level array in the ptdump state structure. This will allow us to > > > > extract the mask which is wrapped in the pg_level array and use it for > > > > descriptor parsing in the note_page. > > > > > > > > Signed-off-by: Sebastian Ene > > > > --- > > > > arch/arm64/include/asm/ptdump.h | 1 + > > > > arch/arm64/mm/ptdump.c | 13 ++++++++----- > > > > 2 files changed, 9 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h > > > > index bd5d3ee3e8dc..71a7ed01153a 100644 > > > > --- a/arch/arm64/include/asm/ptdump.h > > > > +++ b/arch/arm64/include/asm/ptdump.h > > > > @@ -44,6 +44,7 @@ struct ptdump_pg_level { > > > > */ > > > > struct ptdump_pg_state { > > > > struct ptdump_state ptdump; > > > > + struct ptdump_pg_level *pg_level; > > > > struct seq_file *seq; > > > > const struct addr_marker *marker; > > > > const struct mm_struct *mm; > > > > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c > > > > index 404751fd30fe..ca53ef274a8b 100644 > > > > --- a/arch/arm64/mm/ptdump.c > > > > +++ b/arch/arm64/mm/ptdump.c > > > > @@ -117,7 +117,7 @@ static const struct ptdump_prot_bits pte_bits[] = { > > > > } > > > > }; > > > > > > > > -static struct ptdump_pg_level pg_level[] __ro_after_init = { > > > > +static struct ptdump_pg_level kernel_pg_levels[] __ro_after_init = { > > > > Hi Marc, > > > > > > > Do you actually need this sort of renaming? Given that it is static, > > > this looks like some slightly abusive repainting which isn't warranted > > > here. > > > > I applied Will's suggestion from > > https://lore.kernel.org/all/20240705111229.GB9231@willie-the-truck/ > > > > > > > > > I also didn't understand the commit message: you're not tracking any > > > mask here, but a page table level. You are also not using it for > > > anything yet, see below. > > > > and I missed updating the commit message. > > > > > > > > > > > > { /* pgd */ > > > > .name = "PGD", > > > > .bits = pte_bits, > > > > @@ -192,6 +192,7 @@ void note_page(struct ptdump_state *pt_st, unsigned long addr, int level, > > > > u64 val) > > > > { > > > > struct ptdump_pg_state *st = container_of(pt_st, struct ptdump_pg_state, ptdump); > > > > + struct ptdump_pg_level *pg_level = st->pg_level; > > > > > > This is what I mean. What is this pg_level used for? > > > > I make use of it to extract the name based on the level. The suggestion > > that Will made allowed me to keep the code with less changes. > > Err, I see that now. It'd be good if you described what actually > happens, because it is almost impossible to understand it from reading > the patch. Yes, let me re-write the commit message in the next version, Thanks, Seb > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.