From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ADC9C3DA4A for ; Tue, 20 Aug 2024 21:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H5Wfc7SpUB43gQpOzvYVCumAuS/D3QJGlE7NYs8JIZw=; b=H5rJI5G87Q1bc1UjcK9jw5Bm5B fLXQhXh9Y5uH6SWkS/2kDjiZy4r6z7vEvV9gq+v/G8cjGktLLJcpK9Q1HuncP9Dl6Z6ZYjVlV20NH kUTGPjHEv66d4KC1ul8mTRvPkLjL8cEBm6LF3+II4Kkp//aUEhfN3nTrT9gvoZxPaGgb17CAOLgaj 4F3/nG7tQ9ZOuv+I3bNHCYQvo7rpUHdvl2Z7/Jl2LHhZpBkbtXs8PTbIi55S7YT62NjdByjML9Ewq 4nGruRgRd26NbVyrARy5mYbmUd963DRjcPZBT9ATq+k6BbdjZNfref8QulzJKgElhKHHfv0a2hOZ8 LI9IFv+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgWhK-00000006iop-2BZw; Tue, 20 Aug 2024 21:47:26 +0000 Received: from out-174.mta1.migadu.com ([2001:41d0:203:375::ae]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgWgb-00000006ihb-0V5P for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 21:46:43 +0000 Date: Tue, 20 Aug 2024 14:46:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724190396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H5Wfc7SpUB43gQpOzvYVCumAuS/D3QJGlE7NYs8JIZw=; b=bVLhXX6ACG+AY083jKB2/YB67GL6xAZr+SctARVwqeTMLpzBMAOsbVM3WfbSqm6zh4r76g mUOj8v69L8QwaHRe/MwKm2OIxiAjn57MgwvJeITtSabcZPct2IubEQED4HP0TiUhukeenb +Ke9R7UHP+O8lmiVp5iK3gTnBhrf2nk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Alexander Potapenko , stable@vger.kernel.org Subject: Re: [PATCH 01/12] KVM: arm64: Make ICC_*SGI*_EL1 undef in the absence of a vGICv3 Message-ID: References: <20240820100349.3544850-1-maz@kernel.org> <20240820100349.3544850-2-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820100349.3544850-2-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_144641_622364_659B320A X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2024 at 11:03:38AM +0100, Marc Zyngier wrote: > On a system with a GICv3, if a guest hasn't been configured with > GICv3 and that the host is not capable of GICv2 emulation, > a write to any of the ICC_*SGI*_EL1 registers is trapped to EL2. > > We therefore try to emulate the SGI access, only to hit a NULL > pointer as no private interrupt is allocated (no GIC, remember?). > > The obvious fix is to give the guest what it deserves, in the > shape of a UNDEF exception. > > Reported-by: Alexander Potapenko > Signed-off-by: Marc Zyngier > Cc: stable@vger.kernel.org LGTM, and just as an FYI I do plan on grabbing this for 6.11 -- Thanks, Oliver