From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6CCAC3DA4A for ; Tue, 20 Aug 2024 23:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pwtQbLYsFWwvfXXtgan0g6RHZJGMppl5MqjZKi/sPao=; b=XmofRDggwFXofVb9Nt5uJGbNXD tcXMZ2kqVAmRGTrjJHRYOTm6J9M6TO7ViM9LQgtX8LaSE05MrDX70gaFv/7ccAtuVpU1KcYpz8cvg Xf7iz3oEwacU5EJxiP6iau1AvR2FTuQlNgP1eDacRr711TwIXsuxQ9PIJChbkr6ypwWU7mZqfUMx6 NJiZXpNT1jBuCCA9tGNPV73cFRxXbN2vkplZahAFe50Fh2TuFa5A6oy1JmbtRCaNg4kUVn1RBpV/8 oFDgYJUwyWHFqzu6OR8xCLXdCvVik+u96i77LMuZX4XaaBzJ77AgUHxpXsJjy0vOHCFn+XFE2hwVF gA4hSNGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgYMz-00000006wSg-2zic; Tue, 20 Aug 2024 23:34:33 +0000 Received: from out-171.mta1.migadu.com ([95.215.58.171]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgYMH-00000006wN9-1x80 for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 23:33:51 +0000 Date: Tue, 20 Aug 2024 16:33:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724196826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwtQbLYsFWwvfXXtgan0g6RHZJGMppl5MqjZKi/sPao=; b=N0XgiVxFcOhGDMyiWiGS98Cz/VCq3n0Z+pgSMRTwv2GH/Q5e0cPDpWKiH/BqXVumxvQX3+ b2/5+regFQBHfgrqfBPukxC15aciH5i8T7nLdfSssAGHQniZo9mFIrGU16Q+l47nQOX95S +SMn5Awjl/Ifua6k6MCz29aiO2QYpkA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Alexander Potapenko Subject: Re: [PATCH 04/12] KVM: arm64: Force GICv3 traps activa when no irqchip is configured on VHE Message-ID: References: <20240820100349.3544850-1-maz@kernel.org> <20240820100349.3544850-5-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820100349.3544850-5-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_163349_673555_40F25C4A X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org s/activa/active/ On Tue, Aug 20, 2024 at 11:03:41AM +0100, Marc Zyngier wrote: > On a VHE system, no GICv3 traps get configured when no irqchip is > present. This is not quite matching the "no GICv3" semantics that > we want to present. > > Force such traps to be configured in this case. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/vgic/vgic.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > index 974849ea7101..2caa64415ff3 100644 > --- a/arch/arm64/kvm/vgic/vgic.c > +++ b/arch/arm64/kvm/vgic/vgic.c > @@ -917,10 +917,13 @@ void kvm_vgic_flush_hwstate(struct kvm_vcpu *vcpu) > > void kvm_vgic_load(struct kvm_vcpu *vcpu) > { > - if (unlikely(!vgic_initialized(vcpu->kvm))) > + if (unlikely(!irqchip_in_kernel(vcpu->kvm) || !vgic_initialized(vcpu->kvm))) { Doesn't !vgic_initialized(vcpu->kvm) also cover the case of no irqchip in kernel? -- Thanks, Oliver