From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8784CC52D6F for ; Wed, 21 Aug 2024 16:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vlQGzGWk8tm0muGf8AU98KPFAWS2rZ3ejTpHnzVFAeM=; b=pHZx0p8cNyuUlt1dD05WlfZ/BB Rz92hS0jLIXp1z6oG+eWn5QRX7q8dickcYKXQ1ZQ0P+AZawahC3Rm6uvq1rJR7nm+4vHDC9WBNZO5 uAMsuIQPgPQldjaMLYC+0TjvyGRg+xryvRPeg6/aVck5Y0s82NasPWceYh9sPGijU1PBrAZKThK5x dLlfimrvynrHu3tYZyEhN5yD/+SVcrKipcSD+Tq9Mq7TZxFqJZzSoF/1BBBLjQn3QW3l7dPOSWn6T UCdhBW1PBbLGRD16aEsQ2sBZgaRsovTzr4adIoKsPRgzi4BLwBW3opP4M992pDgg2GSMMY3VkeIWQ z34K+2wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgobc-00000009pNj-1Xz4; Wed, 21 Aug 2024 16:54:44 +0000 Received: from out-189.mta1.migadu.com ([2001:41d0:203:375::bd]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgoas-00000009pGW-3YEe for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 16:54:00 +0000 Date: Wed, 21 Aug 2024 09:53:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724259236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vlQGzGWk8tm0muGf8AU98KPFAWS2rZ3ejTpHnzVFAeM=; b=DtfrdYkV68G2vLS7xazpLrwqXKOB8+hUKiu+fgS9cXylowM4cw6AsBFHKCeKSSbmzxZFTk eLeti0zxH3xtakjmF9lVvK29Ebh/Wfse6rz7P47ZItEpRwXu/cE4RCSjCeq2jdVFNVfpWn gUZw1wFLoOLWmOXVa1H2J3aETUp18cE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Alexander Potapenko , stable@vger.kernel.org Subject: Re: [PATCH 01/12] KVM: arm64: Make ICC_*SGI*_EL1 undef in the absence of a vGICv3 Message-ID: References: <20240820100349.3544850-1-maz@kernel.org> <20240820100349.3544850-2-maz@kernel.org> <86le0qxhsn.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86le0qxhsn.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_095359_048717_D6462635 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 21, 2024 at 11:59:52AM +0100, Marc Zyngier wrote: > On Tue, 20 Aug 2024 22:46:30 +0100, > Oliver Upton wrote: > > > > On Tue, Aug 20, 2024 at 11:03:38AM +0100, Marc Zyngier wrote: > > > On a system with a GICv3, if a guest hasn't been configured with > > > GICv3 and that the host is not capable of GICv2 emulation, > > > a write to any of the ICC_*SGI*_EL1 registers is trapped to EL2. > > > > > > We therefore try to emulate the SGI access, only to hit a NULL > > > pointer as no private interrupt is allocated (no GIC, remember?). > > > > > > The obvious fix is to give the guest what it deserves, in the > > > shape of a UNDEF exception. > > > > > > Reported-by: Alexander Potapenko > > > Signed-off-by: Marc Zyngier > > > Cc: stable@vger.kernel.org > > > > LGTM, and just as an FYI I do plan on grabbing this for 6.11 > > Great, thanks. Are you planning to route this via arm64, given that > Paolo is away for a bit? Yup, exactly that. I'll send the PR in the next day or two when I have some time to kick the tires on everything. -- Thanks, Oliver